test: 테스트 코드 추가 및 수정

Author: 01-binary

packages/notion-to-utils/src/client/getFileUrl.spec.ts

@@ -23,10 +23,10 @@ const getFileUrlValidMock = {
       files: [
         {
           file: {
-            url: 'https://~~',
-            expiry_time: 'string',
+            url: 'https://example.com/file.pdf',
+            expiry_time: '2023-05-05T12:00:00.000Z',
           },
-          name: 'test',
+          name: 'test.pdf',
           type: 'file',
         },
       ],
@@ -46,9 +46,27 @@ const getFileUrlInValidMock = {
   },
 };
 
+const getFileUrlExternalMock = {
+  object: 'page',
+  properties: {
+    [KEY]: {
+      type: 'files',
+      files: [
+        {
+          name: 'External File',
+          type: 'external',
+          external: {
+            url: 'https://example.com/external-file.pdf',
+          },
+        },
+      ],
+      id: '1',
+    },
+  },
+};
+
 describe('getFileUrl', () => {
-  it('should return fileUrl when valid pageId, valid propertyKey are provided', async () => {
-    // Mock the notionClient.pages.retrieve method
+  it('유효한 pageId와 유효한 propertyKey가 제공될 때 fileUrl을 반환한다', async () => {
     notionClient.pages.retrieve = vi
       .fn()
       .mockResolvedValue(getFileUrlValidMock);
@@ -57,23 +75,57 @@ describe('getFileUrl', () => {
     expect(fileUrl).toEqual(
       getFileUrlValidMock.properties[KEY].files[0]?.file.url
     );
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
   });
 
-  it('should return undefined when invalid pageId, valid propertyKey are provided', async () => {
+  it('유효하지 않은 pageId와 유효한 propertyKey가 제공될 때 undefined를 반환한다', async () => {
     notionClient.pages.retrieve = vi
       .fn()
       .mockResolvedValue(getFileUrlInValidMock);
 
     const fileUrl = await notionClient.getFileUrl(TEST_ID, KEY);
     expect(fileUrl).toBeUndefined();
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
   });
 
-  it('should return undefined when valid pageId, invalid propertyKey are provided', async () => {
+  it('유효한 pageId와 유효하지 않은 propertyKey가 제공될 때 undefined를 반환한다', async () => {
     notionClient.pages.retrieve = vi
       .fn()
       .mockResolvedValue(getFileUrlValidMock);
 
-    const fileUrl = await notionClient.getFileUrl(TEST_ID, 'temp');
+    const fileUrl = await notionClient.getFileUrl(TEST_ID, 'invalidKey');
     expect(fileUrl).toBeUndefined();
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
+  });
+
+  it('외부 파일 타입에 대해 undefined를 반환한다', async () => {
+    notionClient.pages.retrieve = vi
+      .fn()
+      .mockResolvedValue(getFileUrlExternalMock);
+
+    const fileUrl = await notionClient.getFileUrl(TEST_ID, KEY);
+    expect(fileUrl).toBeUndefined();
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
+  });
+
+  it('API 오류를 적절히 처리한다', async () => {
+    notionClient.pages.retrieve = vi
+      .fn()
+      .mockRejectedValue(new Error('API Error'));
+
+    await expect(notionClient.getFileUrl(TEST_ID, KEY)).rejects.toThrow(
+      'API Error'
+    );
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
   });
 });

packages/notion-to-utils/src/client/getPageProperties.spec.ts

@@ -20,43 +20,80 @@ const getPagePropertiesMock = {
   properties: {
     Category: { id: '1', type: 'text', text: { content: 'Category A' } },
     Slug: { id: '2', type: 'text', text: { content: 'slug-value' } },
+    Date: { id: '3', type: 'date', date: { start: '2023-05-01' } },
   },
 };
 
 describe('getPageProperties', () => {
-  it('should return properties when valid pageId is provided', async () => {
-    // Mock the notionClient.pages.retrieve method
+  it('유효한 pageId가 제공되고 keys가 없을 때 모든 속성을 반환한다', async () => {
     notionClient.pages.retrieve = vi
       .fn()
       .mockResolvedValue(getPagePropertiesMock);
 
-    // Test when no keys are provided (should return all properties)
     const properties = await notionClient.getPageProperties(TEST_ID);
     expect(properties).toEqual(getPagePropertiesMock.properties);
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
   });
 
-  it('should return properties when valid pageId, keys are provided', async () => {
-    // Mock the notionClient.pages.retrieve method
+  it('유효한 pageId와 keys가 제공될 때 지정된 속성만 반환한다', async () => {
     notionClient.pages.retrieve = vi
       .fn()
       .mockResolvedValue(getPagePropertiesMock);
 
     const filteredProperties = await notionClient.getPageProperties(TEST_ID, [
       'Category',
+      'Date',
     ]);
 
     expect(filteredProperties).toEqual({
       Category: getPagePropertiesMock.properties.Category,
+      Date: getPagePropertiesMock.properties.Date,
+    });
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
     });
   });
 
-  it('should return undefined when invalid pageId is provided', async () => {
+  it('유효하지 않은 pageId가 제공될 때 undefined를 반환한다', async () => {
     notionClient.pages.retrieve = vi.fn().mockResolvedValue(null);
 
     const filteredProperties = await notionClient.getPageProperties(TEST_ID, [
       'Category',
     ]);
 
     expect(filteredProperties).toBeUndefined();
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
+  });
+
+  it('유효한 pageId가 제공되지만 일치하는 keys가 없을 때 빈 객체를 반환한다', async () => {
+    notionClient.pages.retrieve = vi
+      .fn()
+      .mockResolvedValue(getPagePropertiesMock);
+
+    const filteredProperties = await notionClient.getPageProperties(TEST_ID, [
+      'NonExistentKey',
+    ]);
+
+    expect(filteredProperties).toEqual({});
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
+  });
+
+  it('API 오류를 적절히 처리한다', async () => {
+    notionClient.pages.retrieve = vi
+      .fn()
+      .mockRejectedValue(new Error('API Error'));
+
+    await expect(notionClient.getPageProperties(TEST_ID)).rejects.toThrow(
+      'API Error'
+    );
+    expect(notionClient.pages.retrieve).toHaveBeenCalledWith({
+      page_id: TEST_ID,
+    });
   });
 });