Final cleanup

Author: 0x19

TODO.md

@@ -2,7 +2,5 @@
 
 List of things that I still need to do in order to make GoESL completed
 
-
-[] Unit Tests
-[] Better documentation
+[x] Better documentation
 [] Freeswitch WIKI Golang page (proposal)

client_test.go

@@ -82,8 +82,6 @@ func (s *OutboundServer) Stop() {
 // NewOutboundServer - Will instanciate new outbound server
 func NewOutboundServer(addr string) (*OutboundServer, error) {
 	if len(addr) < 2 {
-
-		// Try to see if GOES_OUTBOUND_SERVER_ADDR is set. If it's set use that one ...
 		addr = os.Getenv("GOES_OUTBOUND_SERVER_ADDR")
 
 		if addr == "" {
@@ -93,7 +91,7 @@ func NewOutboundServer(addr string) (*OutboundServer, error) {
 
 	server := OutboundServer{
 		Addr:  addr,
-		Proto: "tcp", // Not seeing reason why this could become configurable at this moment
+		Proto: "tcp",
 		Conns: make(chan SocketConnection),
 	}
 

constants.go

@@ -6,8 +6,6 @@
 
 package goesl
 
-import ()
-
 // StringInSlice - Will check if string in list. This is equivalent to python if x in []
 func StringInSlice(str string, list []string) bool {
 	for _, value := range list {

semaphore.go

@@ -8,9 +8,10 @@ package goesl
 
 var (
 
-	// Size of buffer when we read from connection
+	// Size of buffer when we read from connection.
+	// 1024 << 6 == 65536
 	ReadBufferSize = 1024 << 6
 
-	// Supported freeswitch events that we can/wish to parse out
+	// Freeswitch events that we can handle (have logic for it)
 	AvailableMessageTypes = []string{"auth/request", "text/disconnect-notice", "text/event-json", "text/event-plain", "api/response", "command/reply"}
 )