Only validate package fields for internal packages (#136)

Author: 0x80

src/isolate.ts

@@ -10,8 +10,8 @@ import {
   adaptInternalPackageManifests,
   adaptTargetPackageManifest,
   readManifest,
-  writeManifest,
   validateManifestMandatoryFields,
+  writeManifest,
 } from "./lib/manifest";
 import {
   getBuildOutputDir,
@@ -133,6 +133,15 @@ export function createIsolator(config?: IsolateConfig) {
       }
     );
 
+    /** Validate mandatory fields for all internal packages that will be isolated */
+    for (const packageName of internalPackageNames) {
+      const packageDef = packagesRegistry[packageName];
+      validateManifestMandatoryFields(
+        packageDef.manifest,
+        getRootRelativeLogPath(packageDef.absoluteDir, workspaceRootDir)
+      );
+    }
+
     const packedFilesByName = await packDependencies({
       internalPackageNames,
       packagesRegistry,

src/lib/registry/create-packages-registry.ts

@@ -2,7 +2,6 @@ import fs from "fs-extra";
 import { globSync } from "glob";
 import path from "node:path";
 import { useLogger } from "../logger";
-import { validateManifestMandatoryFields } from "../manifest";
 import type { PackageManifest, PackagesRegistry } from "../types";
 import { isRushWorkspace, readTypedJson, readTypedJsonSync } from "../utils";
 import { findPackagesGlobs } from "./helpers";
@@ -47,9 +46,6 @@ export async function createPackagesRegistry(
             path.join(absoluteDir, "package.json")
           );
 
-          /** Validate mandatory fields for all packages */
-          validateManifestMandatoryFields(manifest, rootRelativeDir);
-
           return {
             manifest,
             rootRelativeDir,