fix: PKCS8 format private key validating issue #326

0xJacky · 0xJacky · commit 979a1d5326b2 · 2024-03-14T22:49:34.000+08:00
diff --git a/internal/cert/helper.go b/internal/cert/helper.go
@@ -27,7 +27,12 @@ func IsPrivateKey(pemStr string) bool {
 	}
 
 	_, errECDSA := x509.ParseECPrivateKey(block.Bytes)
-	return errECDSA == nil
+	if errECDSA == nil {
+		return true
+	}
+
+	_, errPKC := x509.ParsePKCS8PrivateKey(block.Bytes)
+	return errPKC == nil
 }
 
 // IsCertificatePath checks if the file at the given path is a certificate or not exists.

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,12 @@ func IsPrivateKey(pemStr string) bool {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`_, errECDSA := x509.ParseECPrivateKey(block.Bytes)`
`30`		`- return errECDSA == nil`
	`30`	`+ if errECDSA == nil {`
	`31`	`+ return true`
	`32`	`+ }`
	`33`	`+`
	`34`	`+ _, errPKC := x509.ParsePKCS8PrivateKey(block.Bytes)`
	`35`	`+ return errPKC == nil`
`31`	`36`	`}`
`32`	`37`
`33`	`38`	`// IsCertificatePath checks if the file at the given path is a certificate or not exists.`