Skip to content

Commit f91e551

Browse files
committed
fix(cert): update revoke logic #1179
1 parent b486cc6 commit f91e551

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ jobs:
291291
with:
292292
accountId: ${{ secrets.CF_ACCOUNT_ID }}
293293
apiToken: ${{ secrets.CF_R2_API_TOKEN }}
294+
wranglerVersion: "4.21.1"
294295
command: |
295296
r2 object put nginx-ui-dev-build/${{ env.DIST }}.tar.gz --file ./${{ env.DIST }}.tar.gz
296297
r2 object put nginx-ui-dev-build/${{ env.DIST }}.tar.gz.digest --file ./${{ env.DIST }}.tar.gz.digest

api/certificate/revoke.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,9 @@ func RevokeCert(c *gin.Context) {
8585
logChan := make(chan string, 1)
8686
errChan := make(chan error, 1)
8787

88-
certLogger := &cert.Logger{}
88+
certLogger := cert.NewLogger()
8989
certLogger.SetWebSocket(ws)
90+
defer certLogger.Close()
9091

9192
go cert.RevokeCert(payload, certLogger, logChan, errChan)
9293

@@ -105,7 +106,6 @@ func RevokeCert(c *gin.Context) {
105106
logger.Error(err)
106107
return
107108
}
108-
return
109109
}
110110

111111
// Update certificate status in database

app/src/views/certificate/CertificateList/Certificate.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ const { processingStatus } = storeToRefs(globalStore)
5050
<template #afterActions="{ record }">
5151
<RemoveCert
5252
:id="record.id"
53+
:disabled="processingStatus.auto_cert_processing"
5354
@removed="() => refTable.refresh()"
5455
/>
5556
</template>

app/src/views/certificate/components/RemoveCert.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import websocket from '@/lib/websocket'
55
66
const props = defineProps<{
77
id: number
8+
disabled?: boolean
89
}>()
910
1011
const emit = defineEmits(['removed'])
@@ -83,6 +84,7 @@ function handleCancel() {
8384
type="link"
8485
size="small"
8586
danger
87+
:disabled
8688
@click="handleDelete"
8789
>
8890
{{ $gettext('Delete') }}

0 commit comments

Comments
 (0)