fix/clap: duplicate names, add regression tests (#1791)

Author: drahnr

bin/node/src/main.rs

@@ -6,6 +6,8 @@ use clap::{Parser, Subcommand};
 use miden_node_utils::logging::OpenTelemetry;
 
 mod commands;
+#[cfg(test)]
+mod tests;
 
 // COMMANDS
 // ================================================================================================

bin/node/src/tests.rs

@@ -0,0 +1,37 @@
+use clap::Parser;
+
+use crate::Cli;
+
+fn parse(args: &[&str]) -> Result<Cli, clap::Error> {
+    Cli::try_parse_from(std::iter::once("miden-node").chain(args.iter().copied()))
+}
+
+#[test]
+fn store_bootstrap_parses() {
+    let _ = parse(&["store", "bootstrap"]);
+}
+
+#[test]
+fn block_producer_start_parses() {
+    let _ = parse(&["block-producer", "start"]);
+}
+
+#[test]
+fn validator_bootstrap_parses() {
+    let _ = parse(&["validator", "bootstrap"]);
+}
+
+#[test]
+fn validator_start_parses() {
+    let _ = parse(&["validator", "start"]);
+}
+
+#[test]
+fn bundled_bootstrap_parses() {
+    let _ = parse(&["bundled", "bootstrap"]);
+}
+
+#[test]
+fn bundled_start_parses() {
+    let _ = parse(&["bundled", "start"]);
+}

crates/utils/src/clap/rocksdb.rs

@@ -12,12 +12,14 @@ pub(crate) const BENCH_ROCKSDB_MAX_OPEN_FDS: i32 = 512;
 #[derive(clap::Args, Clone, Debug, PartialEq, Eq)]
 pub struct NullifierTreeRocksDbOptions {
     #[arg(
+        id = "nullifier_tree_rocksdb_max_open_fds",
         long = "nullifier_tree.rocksdb.max_open_fds",
         default_value_t = DEFAULT_ROCKSDB_MAX_OPEN_FDS,
         value_name = "NULLIFIER_TREE__ROCKSDB__MAX_OPEN_FDS"
     )]
     pub max_open_fds: i32,
     #[arg(
+        id = "nullifier_tree_rocksdb_max_cache_size",
         long = "nullifier_tree.rocksdb.max_cache_size",
         default_value_t = DEFAULT_ROCKSDB_CACHE_SIZE,
         value_name = "NULLIFIER_TREE__ROCKSDB__CACHE_SIZE"
@@ -35,12 +37,14 @@ impl Default for NullifierTreeRocksDbOptions {
 #[derive(clap::Args, Clone, Debug, PartialEq, Eq)]
 pub struct AccountTreeRocksDbOptions {
     #[arg(
+        id = "account_tree_rocksdb_max_open_fds",
         long = "account_tree.rocksdb.max_open_fds",
         default_value_t = DEFAULT_ROCKSDB_MAX_OPEN_FDS,
         value_name = "ACCOUNT_TREE__ROCKSDB__MAX_OPEN_FDS"
     )]
     pub max_open_fds: i32,
     #[arg(
+        id = "account_tree_rocksdb_max_cache_size",
         long = "account_tree.rocksdb.max_cache_size",
         default_value_t = DEFAULT_ROCKSDB_CACHE_SIZE,
         value_name = "ACCOUNT_TREE__ROCKSDB__CACHE_SIZE"