Merge pull request #1947 from 0xPolygon/revert-1941-v2.5.6-candidate

Revert "V2.5.6 candidate"

Author: pratikspatil024

.github/workflows/kurtosis-e2e.yml

@@ -20,31 +20,15 @@ env:
 
 jobs:
   e2e-tests:
-    runs-on: ubuntu-latest
+    name: E2E Tests
+    runs-on: ubuntu24.04-16core-64GB-600SSD-bor
     timeout-minutes: 30
 
     steps:
-      # This is needed because the job fails with "System.IO.IOException: No space left on device".
-      - name: Free disk space
-        uses: jlumbroso/[email protected]
-        with:
-          android: false
-          docker-images: false
-          dotnet: true
-          haskell: true
-          large-packages: false
-          swap-storage: false
-          tool-cache: true
-
       - name: Install dependencies on Linux
         if: runner.os == 'Linux'
         run: sudo apt update && sudo apt install build-essential
 
-      - name: Install Go
-        uses: actions/setup-go@v6
-        with:
-          go-version: 'stable'
-
       - name: Checkout bor
         uses: actions/checkout@v5
         with:
@@ -68,7 +52,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: 0xPolygon/kurtosis-pos
-          ref: v1.2.6
+          ref: v1.2.2
           path: kurtosis-pos
 
       - name: Pre kurtosis run

.github/workflows/kurtosis-stateless-e2e.yml

@@ -1,4 +1,4 @@
-name: Stateless Sync E2E Tests
+name: Stateless Sync Tests
 
 on:
   push:
@@ -20,22 +20,11 @@ env:
 
 jobs:
   e2e-tests:
-    runs-on: ubuntu-latest
+    name: E2E Tests
+    runs-on: ubuntu24.04-16core-64GB-600SSD-bor
     timeout-minutes: 45
 
     steps:
-      # This is needed because the job fails with "System.IO.IOException: No space left on device".
-      - name: Free disk space
-        uses: jlumbroso/[email protected]
-        with:
-          android: false
-          docker-images: false
-          dotnet: true
-          haskell: true
-          large-packages: false
-          swap-storage: false
-          tool-cache: true
-
       - name: Install dependencies on Linux
         if: runner.os == 'Linux'
         run: sudo apt update && sudo apt install build-essential
@@ -63,7 +52,7 @@ jobs:
         uses: actions/checkout@v5
         with:
           repository: 0xPolygon/kurtosis-pos
-          ref: v1.2.6
+          ref: v1.2.2
           path: kurtosis-pos
 
       - name: Pre kurtosis run

consensus/bor/bor.go

@@ -252,8 +252,7 @@ type Bor struct {
 	// The block time defined by the miner. Needs to be larger or equal to the consensus block time. If not set (default = 0), the miner will use the consensus block time.
 	blockTime time.Duration
 
-	// Cache to store the actual times of the parent blocks
-	parentActualTimeCache *lru.Cache
+	lastMinedBlockTime time.Time
 
 	quit      chan struct{}
 	closeOnce sync.Once
@@ -327,8 +326,6 @@ func New(
 		},
 	})
 
-	c.parentActualTimeCache, _ = lru.New(10)
-
 	// make sure we can decode all the GenesisAlloc in the BorConfig.
 	for key, genesisAlloc := range c.config.BlockAlloc {
 		if _, err := decodeGenesisAlloc(genesisAlloc); err != nil {
@@ -1020,31 +1017,20 @@ func (c *Bor) Prepare(chain consensus.ChainHeaderReader, header *types.Header) e
 
 	if c.blockTime > 0 && c.config.IsRio(header.Number) {
 		// Only enable custom block time for Rio and later
-
-		parentBlockTime := time.Unix(int64(parent.Time), 0)
-		// Default to parent block timestamp
-		parentActualBlockTime := parentBlockTime
-		// If we have the parent's ActualTime locally (by parent hash), prefer it
-		if c.parentActualTimeCache != nil {
-			if v, ok := c.parentActualTimeCache.Get(header.ParentHash); ok {
-				if at, ok := v.(time.Time); ok && at.After(parentBlockTime) {
-					parentActualBlockTime = at
-				}
-			}
+		parentActualTime := c.lastMinedBlockTime
+		if parentActualTime.IsZero() || parentActualTime.Before(time.Unix(int64(parent.Time), 0)) {
+			parentActualTime = time.Unix(int64(parent.Time), 0)
 		}
-		actualNewBlockTime := parentActualBlockTime.Add(c.blockTime)
+		actualNewBlockTime := parentActualTime.Add(c.blockTime)
+		c.lastMinedBlockTime = actualNewBlockTime
 		header.Time = uint64(actualNewBlockTime.Unix())
 		header.ActualTime = actualNewBlockTime
 	} else {
 		header.Time = parent.Time + CalcProducerDelay(number, succession, c.config)
 	}
 
-	now := time.Now()
-	if header.Time < uint64(now.Unix()) {
-		header.Time = uint64(now.Unix())
-		if c.blockTime > 0 && c.config.IsRio(header.Number) {
-			header.ActualTime = now
-		}
+	if header.Time < uint64(time.Now().Unix()) {
+		header.Time = uint64(time.Now().Unix())
 	}
 
 	return nil
@@ -1323,10 +1309,6 @@ func (c *Bor) Seal(chain consensus.ChainHeaderReader, block *types.Block, witnes
 		return err
 	}
 
-	if c.parentActualTimeCache != nil && !header.ActualTime.IsZero() {
-		c.parentActualTimeCache.Add(header.Hash(), header.ActualTime)
-	}
-
 	// Wait until sealing is terminated or delay timeout.
 	log.Info("Waiting for slot to sign and propagate", "number", number, "hash", header.Hash(), "delay-in-sec", uint(delay), "delay", common.PrettyDuration(delay))
 

consensus/bor/bor_test.go

@@ -50,7 +50,7 @@ func (s *fakeSpanner) CommitSpan(ctx context.Context, _ borTypes.Span, _ []stake
 }
 
 // newChainAndBorForTest centralizes common Bor + HeaderChain initialization for tests
-func newChainAndBorForTest(t *testing.T, sp Spanner, borCfg *params.BorConfig, devFake bool, signerAddr common.Address, genesisTime uint64) (*core.BlockChain, *Bor) {
+func newChainAndBorForTest(t *testing.T, sp Spanner, borCfg *params.BorConfig, devFake bool, signerAddr common.Address) (*core.BlockChain, *Bor) {
 	cfg := &params.ChainConfig{ChainID: big.NewInt(1), Bor: borCfg}
 
 	b := &Bor{chainConfig: cfg, config: cfg.Bor, DevFakeAuthor: devFake}
@@ -76,9 +76,8 @@ func newChainAndBorForTest(t *testing.T, sp Spanner, borCfg *params.BorConfig, d
 	if devFake && signerAddr != (common.Address{}) {
 		b.authorizedSigner.Store(&signer{signer: signerAddr})
 	}
-	b.parentActualTimeCache, _ = lru.New(10)
 
-	genspec := &core.Genesis{Config: cfg, Timestamp: genesisTime}
+	genspec := &core.Genesis{Config: cfg}
 	db := rawdb.NewMemoryDatabase()
 	_ = genspec.MustCommit(db, triedb.NewDatabase(db, triedb.HashDefaults))
 	chain, err := core.NewBlockChain(rawdb.NewMemoryDatabase(), genspec, b, core.DefaultConfig())
@@ -393,7 +392,7 @@ func TestPerformSpanCheck(t *testing.T) {
 		t.Run(c.name, func(t *testing.T) {
 			sp := &fakeSpanner{vals: []*valset.Validator{{Address: addr2, VotingPower: 1}}}
 			borCfg := &params.BorConfig{Sprint: map[string]uint64{"0": 64}, Period: map[string]uint64{"0": 2}}
-			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{}, uint64(time.Now().Unix()))
+			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{})
 
 			var parents []*types.Header
 			var parentHash common.Hash
@@ -470,7 +469,7 @@ func TestGetVeBlopSnapshot(t *testing.T) {
 		t.Run(c.name, func(t *testing.T) {
 			sp := &fakeSpanner{vals: c.spVals}
 			borCfg := &params.BorConfig{Sprint: map[string]uint64{"0": 64}, Period: map[string]uint64{"0": 2}, RioBlock: big.NewInt(0)}
-			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{}, uint64(time.Now().Unix()))
+			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{})
 			h := &types.Header{Number: big.NewInt(int64(c.targetNum))}
 			snap, err := b.getVeBlopSnapshot(chain.HeaderChain(), h, nil, c.checkNewSpan)
 			require.NoError(t, err)
@@ -517,7 +516,7 @@ func TestSnapshot(t *testing.T) {
 			sp := &fakeSpanner{vals: c.spVals}
 			// Configure RioBlock far in the future so IsRio(header.Number) == false
 			borCfg := &params.BorConfig{Sprint: map[string]uint64{"0": 64}, Period: map[string]uint64{"0": 2}, RioBlock: big.NewInt(1_000_000)}
-			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{}, uint64(time.Now().Unix()))
+			chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{})
 			gen := chain.HeaderChain().GetHeaderByNumber(0)
 			require.NotNil(t, gen)
 			target := &types.Header{Number: big.NewInt(1), ParentHash: gen.Hash()}
@@ -591,7 +590,7 @@ func TestCustomBlockTimeValidation(t *testing.T) {
 				Period:   map[string]uint64{"0": tc.consensusPeriod},
 				RioBlock: big.NewInt(0), // Enable Rio from genesis
 			}
-			chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(time.Now().Unix()))
+			chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1)
 			b.blockTime = tc.blockTime
 
 			// Get genesis block as parent
@@ -627,7 +626,7 @@ func TestCustomBlockTimeCalculation(t *testing.T) {
 			Period:   map[string]uint64{"0": 2},
 			RioBlock: big.NewInt(0),
 		}
-		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(time.Now().Unix()))
+		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1)
 		b.blockTime = 5 * time.Second
 
 		genesis := chain.HeaderChain().GetHeaderByNumber(0)
@@ -653,7 +652,7 @@ func TestCustomBlockTimeCalculation(t *testing.T) {
 			Period:   map[string]uint64{"0": 2},
 			RioBlock: big.NewInt(0),
 		}
-		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(time.Now().Unix()))
+		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1)
 		b.blockTime = 3 * time.Second
 
 		genesis := chain.HeaderChain().GetHeaderByNumber(0)
@@ -679,23 +678,22 @@ func TestCustomBlockTimeCalculation(t *testing.T) {
 			Period:   map[string]uint64{"0": 2},
 			RioBlock: big.NewInt(0),
 		}
-		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(time.Now().Unix()))
+		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1)
 		b.blockTime = 4 * time.Second
 
 		genesis := chain.HeaderChain().GetHeaderByNumber(0)
 		require.NotNil(t, genesis)
 		baseTime := genesis.Time
-		parentHash := genesis.Hash()
 
 		if baseTime > 10 {
-			b.parentActualTimeCache.Add(parentHash, time.Unix(int64(baseTime-10), 0))
+			b.lastMinedBlockTime = time.Unix(int64(baseTime-10), 0)
 		} else {
-			b.parentActualTimeCache.Add(parentHash, time.Unix(0, 0))
+			b.lastMinedBlockTime = time.Unix(0, 0)
 		}
 
 		header := &types.Header{
 			Number:     big.NewInt(1),
-			ParentHash: parentHash,
+			ParentHash: genesis.Hash(),
 		}
 
 		err := b.Prepare(chain.HeaderChain(), header)
@@ -720,7 +718,7 @@ func TestCustomBlockTimeBackwardCompatibility(t *testing.T) {
 			BackupMultiplier: map[string]uint64{"0": 2},
 			RioBlock:         big.NewInt(0),
 		}
-		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(time.Now().Unix()))
+		chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1)
 		b.blockTime = 0
 
 		genesis := chain.HeaderChain().GetHeaderByNumber(0)
@@ -738,53 +736,6 @@ func TestCustomBlockTimeBackwardCompatibility(t *testing.T) {
 	})
 }
 
-func TestCustomBlockTimeClampsToNowAlsoUpdatesActualTime(t *testing.T) {
-	t.Parallel()
-
-	addr1 := common.HexToAddress("0x1")
-	// Force parent time far in the past so that after adding blockTime, header.Time is still < now
-	// and the "clamp to now" block triggers.
-	pastParentTime := time.Now().Add(-10 * time.Minute).Unix()
-
-	sp := &fakeSpanner{vals: []*valset.Validator{{Address: addr1, VotingPower: 1}}}
-	borCfg := &params.BorConfig{
-		Sprint:   map[string]uint64{"0": 64},
-		Period:   map[string]uint64{"0": 2},
-		RioBlock: big.NewInt(0), // Rio enabled from genesis
-	}
-	chain, b := newChainAndBorForTest(t, sp, borCfg, true, addr1, uint64(pastParentTime))
-
-	// Enable custom block time (must be >= Period to avoid validation error)
-	b.blockTime = 5 * time.Second
-
-	genesis := chain.HeaderChain().GetHeaderByNumber(0)
-	require.NotNil(t, genesis)
-
-	header := &types.Header{
-		Number:     big.NewInt(1),
-		ParentHash: genesis.Hash(),
-	}
-
-	before := time.Now()
-	err := b.Prepare(chain.HeaderChain(), header)
-	after := time.Now()
-
-	require.NoError(t, err)
-
-	// Validate the clamp happened: header.Time should be "now-ish", not the past-derived time.
-	require.GreaterOrEqual(t, int64(header.Time), before.Unix(), "header.Time should be clamped up to now")
-	require.LessOrEqual(t, int64(header.Time), after.Unix()+1, "header.Time should be close to now")
-
-	// Critical regression assertion:
-	// When custom blockTime is enabled for Rio, clamping header.Time to now must also set ActualTime = now.
-	require.False(t, header.ActualTime.IsZero(), "ActualTime should be set when blockTime > 0 and Rio is enabled")
-	require.GreaterOrEqual(t, header.ActualTime.Unix(), before.Unix(), "ActualTime should be updated to now when clamping occurs")
-	require.LessOrEqual(t, header.ActualTime.Unix(), after.Unix()+1, "ActualTime should be close to now when clamping occurs")
-
-	// Optional: since clamping sets both from the same `now`, they should match on Unix seconds.
-	require.Equal(t, int64(header.Time), header.ActualTime.Unix(), "header.Time and ActualTime should align after clamping")
-}
-
 func TestVerifySealRejectsOversizedDifficulty(t *testing.T) {
 	t.Parallel()
 
@@ -806,7 +757,7 @@ func TestVerifySealRejectsOversizedDifficulty(t *testing.T) {
 	}
 
 	// devFake=false, we need real signatures for the sake of this test
-	chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{}, uint64(time.Now().Unix()))
+	chain, b := newChainAndBorForTest(t, sp, borCfg, false, common.Address{})
 
 	parent := chain.HeaderChain().GetHeaderByNumber(0)
 	require.NotNil(t, parent)

core/parallel_state_processor.go

@@ -182,7 +182,7 @@ func (task *ExecutionTask) Settle() {
 
 	coinbaseBalance := task.finalStateDB.GetBalance(task.coinbase)
 
-	task.finalStateDB.ApplyMVWriteSet(task.statedb.MVWriteList())
+	task.finalStateDB.ApplyMVWriteSet(task.statedb.MVFullWriteList())
 
 	for _, l := range task.statedb.GetLogs(task.tx.Hash(), task.blockNumber.Uint64(), task.blockHash, task.blockTime) {
 		task.finalStateDB.AddLog(l)

core/state/journal.go

@@ -23,7 +23,6 @@ import (
 	"sort"
 
 	"github.com/ethereum/go-ethereum/common"
-	"github.com/ethereum/go-ethereum/core/blockstm"
 	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/holiman/uint256"
 )
@@ -324,7 +323,6 @@ func (ch selfDestructChange) revert(s *StateDB) {
 	obj := s.getStateObject(ch.account)
 	if obj != nil {
 		obj.selfDestructed = false
-		RevertWrite(s, blockstm.NewSubpathKey(ch.account, SuicidePath))
 	}
 }
 

core/state/statedb.go

@@ -421,7 +421,7 @@ func (s *StateDB) ApplyMVWriteSet(writes []blockstm.WriteDescriptor) {
 				s.SetCode(addr, sr.GetCode(addr))
 			case SuicidePath:
 				stateObject := s.getStateObject(addr)
-				if stateObject != nil && sr.HasSelfDestructed(addr) {
+				if stateObject != nil {
 					s.SelfDestruct(addr)
 				}
 			default: