Skip to content

Conversation

@kamuikatsurgi
Copy link
Member

Description

Bor's implementation was based on EIP-7212 (the original P256 precompile proposal) with a gas cost of 3450, while upstream go-ethereum implemented EIP-7951 (a newer revision) with a gas cost of 6900.

@claude
Copy link

claude bot commented Jan 30, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.58%. Comparing base (ed902e3) to head (5d6a0a7).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
core/vm/contracts.go 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2030      +/-   ##
===========================================
- Coverage    49.59%   49.58%   -0.01%     
===========================================
  Files          874      873       -1     
  Lines       150517   150507      -10     
===========================================
- Hits         74652    74635      -17     
- Misses       70837    70840       +3     
- Partials      5028     5032       +4     
Files with missing lines Coverage Δ
params/protocol_params.go 84.21% <ø> (ø)
core/vm/contracts.go 74.94% <0.00%> (-0.27%) ⬇️

... and 20 files with indirect coverage changes

Files with missing lines Coverage Δ
params/protocol_params.go 84.21% <ø> (ø)
core/vm/contracts.go 74.94% <0.00%> (-0.27%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@marcello33 marcello33 merged commit e61aaf9 into develop Feb 2, 2026
18 of 22 checks passed
@kamuikatsurgi kamuikatsurgi deleted the kamui/fix-secp256r1-gas branch February 2, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants