fix: rename methods to be more idiomatic

Author: minhd-vu

cmd/p2p/sensor/api.go

@@ -62,7 +62,7 @@ func handleAPI(server *ethp2p.Server, counter *prometheus.CounterVec, conns *p2p
 			url := peer.Node().URLv4()
 			peerID := peer.Node().ID().String()
 			name := peer.Fullname()
-			connectedAt := conns.GetPeerConnectedAt(peerID)
+			connectedAt := conns.PeerConnectedAt(peerID)
 			if connectedAt.IsZero() {
 				continue
 			}
@@ -79,8 +79,8 @@ func handleAPI(server *ethp2p.Server, counter *prometheus.CounterVec, conns *p2p
 			peers[url] = msgs
 		}
 
-		head := conns.GetHeadBlock()
-		oldest := conns.GetOldestBlock()
+		head := conns.HeadBlock()
+		oldest := conns.OldestBlock()
 
 		data := apiData{
 			ENR:       server.NodeInfo().ENR,

cmd/p2p/sensor/sensor.go

@@ -284,7 +284,7 @@ var SensorCmd = &cobra.Command{
 				peersGauge.Set(float64(server.PeerCount()))
 				db.WritePeers(cmd.Context(), server.Peers(), time.Now())
 
-				metrics.Update(conns.GetHeadBlock().Block, conns.GetOldestBlock())
+				metrics.Update(conns.HeadBlock().Block, conns.OldestBlock())
 
 				urls := []string{}
 				for _, peer := range server.Peers() {

p2p/conns.go

@@ -107,9 +107,9 @@ func (c *Conns) Nodes() []*enode.Node {
 	return nodes
 }
 
-// GetPeerConnectedAt returns the connection time for a peer by their ID.
+// PeerConnectedAt returns the connection time for a peer by their ID.
 // Returns zero time if the peer is not found.
-func (c *Conns) GetPeerConnectedAt(peerID string) time.Time {
+func (c *Conns) PeerConnectedAt(peerID string) time.Time {
 	c.mu.RLock()
 	defer c.mu.RUnlock()
 
@@ -125,15 +125,15 @@ func (c *Conns) Blocks() *Cache[common.Hash, BlockCache] {
 	return c.blocks
 }
 
-// GetOldestBlock returns the oldest block the sensor will fetch parents for.
+// OldestBlock returns the oldest block the sensor will fetch parents for.
 // This is set once at initialization to the head block and acts as a floor
 // to prevent the sensor from crawling backwards indefinitely.
-func (c *Conns) GetOldestBlock() *types.Header {
+func (c *Conns) OldestBlock() *types.Header {
 	return c.oldest.Get()
 }
 
-// GetHeadBlock returns the current head block packet.
-func (c *Conns) GetHeadBlock() eth.NewBlockPacket {
+// HeadBlock returns the current head block packet.
+func (c *Conns) HeadBlock() eth.NewBlockPacket {
 	return c.head.Get()
 }
 

p2p/protocol.go

@@ -103,7 +103,7 @@ func NewEthProtocol(version uint, opts EthProtocolOptions) ethp2p.Protocol {
 				peerFullname: p.Fullname(),
 			}
 
-			head := c.conns.GetHeadBlock()
+			head := c.conns.HeadBlock()
 			status := eth.StatusPacket{
 				ProtocolVersion: uint32(version),
 				NetworkID:       opts.NetworkID,
@@ -310,7 +310,7 @@ func (c *conn) getParentBlock(ctx context.Context, header *types.Header) error {
 		return nil
 	}
 
-	oldestBlock := c.conns.GetOldestBlock()
+	oldestBlock := c.conns.OldestBlock()
 
 	// Check cache first before querying the database
 	cache, ok := c.conns.Blocks().Peek(header.ParentHash)