Merge pull request #441 from jhkimqd/jihwan/fix-monitor-close-time

jhkimqd · web-flow · commit 8546da2751a8 · 2024-11-25T17:51:46.000+09:00
fix: monitor stuck on wait when closing
diff --git a/cmd/monitor/monitor.go b/cmd/monitor/monitor.go
@@ -193,14 +193,10 @@ func monitor(ctx context.Context) error {
 		}
 	}()
 
-	// Give time for the UI to attempt rendering.
-	time.Sleep(5 * time.Second)
 	if !isUiRendered {
 		// If UI cannot be rendered and returns, close the goroutine.
 		ctx.Done()
 	}
-	// Give time for goroutine to finish.
-	time.Sleep(1 * time.Second)
 	// Receive the errors from errChan and return to exit.
 	err = <-errChan
 	return err

Original file line number	Diff line number	Diff line change
`@@ -193,14 +193,10 @@ func monitor(ctx context.Context) error {`
`193`	`193`	`}`
`194`	`194`	`}()`
`195`	`195`
`196`		`- // Give time for the UI to attempt rendering.`
`197`		`- time.Sleep(5 * time.Second)`
`198`	`196`	`if !isUiRendered {`
`199`	`197`	`// If UI cannot be rendered and returns, close the goroutine.`
`200`	`198`	`ctx.Done()`
`201`	`199`	`}`
`202`		`- // Give time for goroutine to finish.`
`203`		`- time.Sleep(1 * time.Second)`
`204`	`200`	`// Receive the errors from errChan and return to exit.`
`205`	`201`	`err = <-errChan`
`206`	`202`	`return err`