unit test

Author: ARR552

cmd/ulxly/ulxly.go

@@ -600,7 +600,7 @@ func logAndReturnJsonError(ctx context.Context, client *ethclient.Client, tx *ty
 		return err
 	}
 
-	reason, decodeErr := smcerror.DecodeInterfaceSmcErrorCode(jsonError.Data)
+	reason, decodeErr := smcerror.DecodeSmcErrorCode(jsonError.Data)
 	if decodeErr != nil {
 		log.Error().Err(err).Msg("unable to decode smart contract error")
 		return err

errors/smc.go

@@ -233,7 +233,7 @@ var ErrorMessages = map[string]string{
         "0x3a64d973":"OnlyChainsWithPessimisticProofsError",
 }
 
-func DecodeInterfaceSmcErrorCode(errorCode interface{}) (string, error) {
+func DecodeSmcErrorCode(errorCode interface{}) (string, error) {
     codeStr, ok := errorCode.(string)
 	if !ok {
 		return "", errors.New("jsonError.Data is not a string, unable to decode smart contract error")
@@ -243,10 +243,3 @@ func DecodeInterfaceSmcErrorCode(errorCode interface{}) (string, error) {
     }
     return codeStr + " (unknown selector)", nil
 }
-
-func DecodeStringSmcErrorCode(errorCode string) string {
-    if msg, exists := ErrorMessages[errorCode]; exists {
-        return msg
-    }
-    return errorCode + " (unknown selector)"
-}

errors/smc_test.go

@@ -0,0 +1,33 @@
+package errors_test
+
+import (
+	"testing"
+
+    "github.com/0xPolygon/polygon-cli/errors"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestDecodeSmcErrorCode (t *testing.T) {
+    reason, err := errors.DecodeSmcErrorCode("0x1a070d9a")
+	require.NoError(t, err)
+    assert.Equal(t, "InitSequencedBatchDoesNotMatchError", reason)
+
+    reason, err = errors.DecodeSmcErrorCode("0x52ad525a")
+	require.NoError(t, err)
+    assert.Equal(t, "InvalidPessimisticProofError", reason)
+
+    reason, err = errors.DecodeSmcErrorCode("0x9aad315a")
+	require.NoError(t, err)
+    assert.Equal(t, "0x9aad315a (unknown selector)", reason)
+
+    var emptyInterface interface{}
+    reason, err = errors.DecodeSmcErrorCode(emptyInterface)
+	require.Error(t, err)
+
+    code := "0x3bbd317c"
+    reason, err = errors.DecodeSmcErrorCode(code)
+	require.NoError(t, err)
+    assert.Equal(t, "0x3bbd317c (unknown selector)", reason)
+}
+