fix: remove as required if there is a default

Author: minhd-vu

cmd/cdk/cdk.go

@@ -675,7 +675,4 @@ func init() {
 	gerCmd.AddCommand(gerInspectCmd)
 	gerCmd.AddCommand(gerDumpCmd)
 	gerCmd.AddCommand(gerMonitorCmd)
-
-	// Mark required flags
-	flag.MarkPersistentFlagRequired(CDKCmd, flag.RPCURL)
 }

cmd/contract/cmd.go

@@ -176,5 +176,4 @@ func init() {
 
 	// Mark required flags
 	flag.MarkFlagRequired(Cmd, ArgAddress)
-	flag.MarkFlagRequired(Cmd, flag.RPCURL)
 }

cmd/dumpblocks/dumpblocks.go

@@ -194,9 +194,6 @@ func init() {
 	f.StringVarP(&inputDumpblocks.Mode, "mode", "m", "json", "the output format [json, proto]")
 	f.Uint64VarP(&inputDumpblocks.BatchSize, "batch-size", "b", 150, "batch size for requests (most providers cap at 1000)")
 	f.StringVarP(&inputDumpblocks.FilterStr, "filter", "F", "{}", "filter output based on tx to and from, not setting a filter means all are allowed")
-
-	// Mark required flags
-	flag.MarkFlagRequired(DumpblocksCmd, flag.RPCURL)
 }
 
 // writeResponses writes the data to either stdout or a file if one is provided.

cmd/fixnoncegap/fixnoncegap.go

@@ -233,7 +233,6 @@ func init() {
 	f.Uint64Var(&inputFixNonceGapArgs.maxNonce, ArgMaxNonce, 0, "override max nonce value instead of getting it from the pool")
 
 	// Mark required flags
-	flag.MarkFlagRequired(FixNonceGapCmd, flag.RPCURL)
 	flag.MarkFlagRequired(FixNonceGapCmd, flag.PrivateKey)
 }
 

cmd/fund/cmd.go

@@ -89,10 +89,6 @@ func init() {
 	// Require at least one method to specify target accounts
 	FundCmd.MarkFlagsOneRequired("addresses", "key-file", "number")
 
-	// Mark required flags
-	flag.MarkFlagRequired(FundCmd, flag.RPCURL)
-	flag.MarkFlagRequired(FundCmd, flag.PrivateKey)
-
 	// Funder contract parameters.
 	f.StringVar(&params.FunderAddress, "contract-address", "", "address of pre-deployed Funder contract")
 }

cmd/loadtest/app.go

@@ -297,10 +297,6 @@ v3, uniswapv3 - perform UniswapV3 swaps`)
 	f.UintVar(&ltp.ReceiptRetryInitialDelayMs, "receipt-retry-initial-delay-ms", 100, "initial delay in milliseconds for receipt polling (uses exponential backoff with jitter)")
 
 	// TODO Compression
-
-	// Mark required flags
-	flag.MarkPersistentFlagRequired(LoadtestCmd, flag.RPCURL)
-	flag.MarkPersistentFlagRequired(LoadtestCmd, flag.PrivateKey)
 }
 
 func initSubCommands() {

cmd/metricsToDash/metricsToDash.go

@@ -1,4 +1,4 @@
-package metricsToDash
+package metricstodash
 
 import (
 	"fmt"

cmd/monitor/cmd.go

@@ -88,9 +88,6 @@ func init() {
 	f.IntVarP(&subBatchSize, "sub-batch-size", "s", 50, "number of requests per sub-batch")
 	f.IntVarP(&blockCacheLimit, "cache-limit", "c", 200, "number of cached blocks for the LRU block data structure (Min 100)")
 	f.StringVarP(&intervalStr, "interval", "i", "5s", "amount of time between batch block RPC calls")
-
-	// Mark required flags
-	flag.MarkFlagRequired(MonitorCmd, flag.RPCURL)
 }
 
 func checkFlags() (err error) {

cmd/publish/publish.go

@@ -143,7 +143,4 @@ func init() {
 	f.Uint64Var(&publishInputArgs.jobQueueSize, "job-queue-size", 100, "number of jobs we can put in the job queue for workers to process")
 	f.StringVar(&publishInputArgs.inputFileName, "file", "", "provide a filename with transactions to publish")
 	f.Uint64Var(&publishInputArgs.rateLimit, "rate-limit", 0, "rate limit in txs per second (default: no limit)")
-
-	// Mark required flags
-	flag.MarkFlagRequired(Cmd, flag.RPCURL)
 }

cmd/root.go

@@ -32,7 +32,7 @@ import (
 	"github.com/0xPolygon/polygon-cli/cmd/fund"
 	"github.com/0xPolygon/polygon-cli/cmd/hash"
 	"github.com/0xPolygon/polygon-cli/cmd/loadtest"
-	"github.com/0xPolygon/polygon-cli/cmd/metricsToDash"
+	"github.com/0xPolygon/polygon-cli/cmd/metricstodash"
 	"github.com/0xPolygon/polygon-cli/cmd/mnemonic"
 	"github.com/0xPolygon/polygon-cli/cmd/monitor"
 	"github.com/0xPolygon/polygon-cli/cmd/monitorv2"
@@ -153,7 +153,7 @@ func NewPolycliCommand() *cobra.Command {
 		fund.FundCmd,
 		hash.HashCmd,
 		loadtest.LoadtestCmd,
-		metricsToDash.MetricsToDashCmd,
+		metricstodash.MetricsToDashCmd,
 		mnemonic.MnemonicCmd,
 		monitor.MonitorCmd,
 		monitorv2.MonitorV2Cmd,