fix: empty if

minhd-vu · minhd-vu · commit ec6dd2e913a0 · 2025-10-21T21:37:53.000-04:00
diff --git a/p2p/database/datastore.go b/p2p/database/datastore.go
@@ -400,12 +400,8 @@ func (d *Datastore) writeFirstSeen(newHeader *DatastoreHeader, block *DatastoreB
 		newHeader.SensorFirstSeen = block.DatastoreHeader.SensorFirstSeen
 	}
 
-	// Preserve earlier hash timing if it exists
-	if !block.TimeFirstSeenHash.IsZero() && block.TimeFirstSeenHash.Before(tfs) {
-		// Keep existing hash timing
-		// (no need to reassign since we're reading and writing to the same block)
-	} else {
-		// Set new hash timing
+	// Set hash timing if it doesn't exist or if new timestamp is earlier
+	if block.TimeFirstSeenHash.IsZero() || tfs.Before(block.TimeFirstSeenHash) {
 		block.TimeFirstSeenHash = tfs
 		block.SensorFirstSeenHash = d.sensorID
 	}

Original file line number	Diff line number	Diff line change
`@@ -400,12 +400,8 @@ func (d Datastore) writeFirstSeen(newHeader DatastoreHeader, block *DatastoreB`
`400`	`400`	`newHeader.SensorFirstSeen = block.DatastoreHeader.SensorFirstSeen`
`401`	`401`	`}`
`402`	`402`
`403`		`- // Preserve earlier hash timing if it exists`
`404`		`- if !block.TimeFirstSeenHash.IsZero() && block.TimeFirstSeenHash.Before(tfs) {`
`405`		`- // Keep existing hash timing`
`406`		`- // (no need to reassign since we're reading and writing to the same block)`
`407`		`- } else {`
`408`		`- // Set new hash timing`
	`403`	`+ // Set hash timing if it doesn't exist or if new timestamp is earlier`
	`404`	`+ if block.TimeFirstSeenHash.IsZero() \|\| tfs.Before(block.TimeFirstSeenHash) {`
`409`	`405`	`block.TimeFirstSeenHash = tfs`
`410`	`406`	`block.SensorFirstSeenHash = d.sensorID`
`411`	`407`	`}`