chore: nits + fixes

Signed-off-by: Ji Hwan <[email protected]>

Author: jhkimqd

p2p/database/noop.go

@@ -26,7 +26,7 @@ func (n *NoopDatabase) WriteBlock(ctx context.Context, peer *enode.Node, block *
 }
 
 // WriteBlockHeaders does nothing.
-func (n *NoopDatabase) WriteBlockHeaders(ctx context.Context, headers []*types.Header, tfs time.Time) {
+func (n *NoopDatabase) WriteBlockHeaders(ctx context.Context, headers []*types.Header, tfs time.Time, isParent bool) {
 }
 
 // WriteBlockHashes does nothing.
@@ -83,4 +83,4 @@ func (n *NoopDatabase) ShouldWritePeers() bool {
 // NodeList returns an empty list.
 func (n *NoopDatabase) NodeList(ctx context.Context, limit int) ([]string, error) {
 	return []string{}, nil
-}
+}

p2p/protocol.go

@@ -146,12 +146,6 @@ func NewEthProtocol(version uint, opts EthProtocolOptions) ethp2p.Protocol {
 
 			ctx := opts.Context
 
-			// Register connection with the manager if available
-			if opts.ConnManager != nil {
-				opts.ConnManager.AddConnection(p.Node().ID().String(), c)
-				defer opts.ConnManager.RemoveConnection(p.Node().ID().String())
-			}
-
 			// Handle all the of the messages here.
 			for {
 				msg, err := rw.ReadMsg()