fix: Disable sample recording if SendOnly is enabled for load testing#647
Merged
leovct merged 3 commits into0xPolygon:mainfrom Jul 15, 2025
Merged
Conversation
IvanBelyakoff
changed the title
jhkimqd
previously approved these changes
Jul 11, 2025
Contributor
jhkimqd
left a comment
jhkimqd
left a comment
There was a problem hiding this comment.
Small nitpick, otherwise lgtm!
Contributor
|
@IvanBelyakoff could you also run |
IvanBelyakoff
force-pushed
the
fix/disable-light-summary-on-send-only
branch
from
785ffe1 to
f0a38e3
Compare
IvanBelyakoff
force-pushed
the
fix/disable-light-summary-on-send-only
branch
from
f0a38e3 to
744ea76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case SendOnly is enabled for load testing, no light summary is provided. But the test still calls recordSample, which does not make sense, and eats all the RAM during long heavy load testing.
Disable light summary if SendOnly is enabled.