Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Commit 318c074

Browse files
committed
fix: add V4 NFT docs to algolia_meta
1 parent 6e6328b commit 318c074

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

mdx/guides/0x-v4-nft-features-over.mdx renamed to mdx/guides/0x-v4-nft-features-overview.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
> Note: This feature is in beta and is subject to change. Testnet deployments coming soon. Mainnet deployments are pending audit.
44
> We invite you to join our [Discord](https://discord.com/invite/YyG9fkK) and share feedback in the [#dev-feature-feedback](https://discord.com/channels/435912040142602260/936366257521954857).
55
6-
We are adding support for ERC721<>ERC20 and ERC1155<>ERC20 orders to 0x v4. Contracts can be found [here](https://github.com/0xProject/protocol/tree/refactor/nft-orders/contracts/zero-ex/contracts/src/features/nft_orders). Contract interfaces are also in [this doc](https://0x.org/docs/guides/0x-v4-nft-contract-interfaces)
6+
We are adding support for ERC721<\>ERC20 and ERC1155<\>ERC20 orders to 0x v4. Contracts can be found [here](https://github.com/0xProject/protocol/tree/refactor/nft-orders/contracts/zero-ex/contracts/src/features/nft_orders). Contract interfaces are also in [this doc](https://0x.org/docs/guides/0x-v4-nft-contract-interfaces)
77

88
## Basics
99

@@ -132,7 +132,7 @@ For expensive chains like Ethereum mainnet, disbursing multiple fees would be co
132132
133133
A **sell** order must use WETH instead of ETH, since we require the ERC20 `transferFrom` functionality to transfer WETH from the maker to the taker. Even so, the taker can choose to *receive* ETH when filling a WETH sell order by setting the `unwrapNativeToken` parameter to `true` in `sellERC721` or `sellERC1155`.
134134
135-
A **buy** order can specify either ETH or WETH, i.e. the buyer can indicate whether they would like to receive ETH or WETH. A ** WETH sell order can be filled by a taker using ETH: the `buyERC721` and `buyERC1155` functions are `payable` and the `msg.value` can be used to fill a WETH sell order.
135+
A **buy** order can specify either ETH or WETH, i.e. the buyer can indicate whether they would like to receive ETH or WETH. A **WETH** sell order can be filled by a taker using ETH: the `buyERC721` and `buyERC1155` functions are `payable` and the `msg.value` can be used to fill a WETH sell order.
136136
137137
## `onERC721Received` and `onERC1155Received`
138138

ts/components/governance/hero.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ export const GovernanceHero: React.FC<GovernanceHeroProps> = (props) => {
242242
const wCeloAmount = Web3Wrapper.toUnitAmount(wCeloBalance, 18);
243243
const zrxUSD = zrxAmount.multipliedBy(res['0x'].usd);
244244
const maticUSD = maticAmount.multipliedBy(res['matic-network'].usd);
245-
const wCeloUSD = wCeloAmount.multipliedBy(res['celo'].usd);
245+
const wCeloUSD = wCeloAmount.multipliedBy(res.celo.usd);
246246

247247
const treasuryTokenTransferData = await backendClient.getTreasuryTokenTransfersAsync();
248248
const totalDistributed = parseTotalDistributed(treasuryTokenTransferData);

ts/pages/governance/treasury_breakdown.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -227,15 +227,15 @@ export const TreasuryBreakdown: React.FC<TreasuryBreakdownProps> = (props) => {
227227
const treasuryTokenPrices = await backendClient.getTreasuryTokenPricesAsync();
228228
const getTokenPrice = (tokenSymbol: string) => {
229229
const symbolIdMap: { [symbol: string]: string } = {
230-
'ZRX': '0x',
231-
'MATIC': 'matic-network',
232-
'wCELO': 'celo'
233-
}
230+
ZRX: '0x',
231+
MATIC: 'matic-network',
232+
wCELO: 'celo',
233+
};
234234
const priceId = symbolIdMap[tokenSymbol];
235235
const price = treasuryTokenPrices[priceId].usd;
236236

237237
return price;
238-
}
238+
};
239239
const zrxAmount = Web3Wrapper.toUnitAmount(zrxBalance, 18);
240240
const maticAmount = Web3Wrapper.toUnitAmount(maticBalance, 18);
241241
const wCeloAmount = Web3Wrapper.toUnitAmount(wCeloBalance, 18);

ts/utils/algolia_meta.json

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,24 @@
1818
}
1919
},
2020
"guides": {
21+
"0x-v4-nft-features-overview": {
22+
"title": "0x V4 NFT Features Overview",
23+
"subtitle": "Learn about the NFT features of the 0x V4 Protocol",
24+
"description": "Learn about the NFT features of the 0x V4 Protocol",
25+
"tags": ["NFT", "Protocol Developer"],
26+
"topics": ["NFT", "Protocol Developer"],
27+
"difficulty": "Intermediate",
28+
"path": "guides/0x-v4-nft-features-overview.mdx"
29+
},
30+
"0x-v4-nft-contract-interfaces": {
31+
"title": "0x V4 NFT contract interfaces",
32+
"subtitle": "Learn the in-depth details about the 0x V4 NFT contract interfaces",
33+
"description": "Learn the in-depth details about the 0x V4 NFT contract interfaces",
34+
"tags": ["NFT", "Protocol Developer"],
35+
"topics": ["NFT", "Protocol Developer"],
36+
"difficulty": "Intermediate",
37+
"path": "guides/0x-v4-nft-contract-interfaces.mdx"
38+
},
2139
"migrate-0x-api-from-v0-to-v1": {
2240
"title": "Migrate 0x API integrations from the v0 to v1 endpoints",
2341
"subtitle": "Learn how to migrate your existing 0x API integration to use the v1 endpoints",

0 commit comments

Comments
 (0)