Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Commit 9ee69f1

Browse files
authored
Merge pull request #382 from 0xProject/zeip-84
[WIP] Adding ZEIP-84
2 parents 55a79b6 + 535e4a9 commit 9ee69f1

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

ts/pages/governance/data.ts

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,45 @@ export const proposals: Proposals = {
444444
],
445445
},
446446
},
447+
84: {
448+
zeipId: 84,
449+
title: 'OrderSignerRegistry',
450+
summary: [
451+
`Currently, in order to market make on 0x v4, you must hold balances in a normal Ethereum address. 0x Labs has gotten feedback from market makers that it would be useful to be able to store funds in a contract to be able to more easily reuse funds for different market making strategies (e.g. on-chain quoting strategies) and to allow for more complex funds management.`,
452+
`Signature types that support contract wallets were available in versions 2 and 3 of 0x, so this is bringing v4 into parity with respect to that functionality.`,
453+
],
454+
url: 'https://github.com/0xProject/ZEIPs/issues/84',
455+
voteStartDate: moment(1619024400, 'X'),
456+
voteEndDate: moment(1619485760, 'X'),
457+
benefit: {
458+
title: 'Benefit',
459+
summary: [
460+
`Bringing this feature to 0x v4 will unlock additional capital from market makers who use contract wallets to store their funds. More market making capital means better prices for consumers of liquidity (such as Matcha users).`,
461+
],
462+
rating: 3,
463+
links: [
464+
{
465+
text: 'Features specifications',
466+
url: 'https://protocol.0x.org/',
467+
},
468+
],
469+
},
470+
risks: {
471+
title: 'Risk',
472+
summary: [
473+
`Contracts were thoroughly reviewed internally, and spot-checked by Consensys Diligence. No vulnerabilities were found.`,
474+
`However, these changes do modify a risk-sensitive part of the codebase: the logic of settling NativeOrder fills.`,
475+
`0x V4 architecture comes with the ability to modify or rollback specific features, without halting the entire pipeline of smart contracts. This means that if a vulnerability is found (0x Labs offers generous bug bounties), it is possible to rollback the functionality that exposes the risk.`,
476+
],
477+
rating: 2,
478+
links: [
479+
{
480+
text: '0x v4 Bug Bounty',
481+
url: 'https://blog.0xproject.com/0x-protocol-v4-bug-bounty-fd0c1942b9a',
482+
},
483+
],
484+
},
485+
},
447486
};
448487

449488
export const stagingProposals: Proposals = {
@@ -471,3 +510,4 @@ export const ZERO_TALLY: TallyInterface = {
471510
yes: new BigNumber(0),
472511
no: new BigNumber(0),
473512
};
513+
// tslint:disable:max-file-line-count

0 commit comments

Comments
 (0)