fix: TS related issues after updating TS to a supported version

Author: kimpers

package.json

@@ -17,7 +17,7 @@
         "eslint": "eslint 'ts/**/*.{ts,tsx}'",
         "lint": "tslint --format stylish --project . 'ts/**/*.ts' 'ts/**/*.tsx'",
         "fix": "yarn lint --fix",
-        "pre_push": "yarn lint:prettier && yarn lint && yarn test",
+        "pre_push": "yarn typecheck && yarn lint:prettier && yarn lint && yarn test",
         "update:tools": "aws s3 sync --delete s3://docs-markdown/ mdx/tools/ --profile $(npm config get awscli_profile)",
         "dev": "npm run update:tools && node --max-old-space-size=16384 ./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode development --content-base public",
         "deploy_dogfood": "npm run update:tools && yarn index_docs --environment dogfood && npm run build:prod && aws s3 sync ./public/. s3://dogfood.0xproject.com --profile $(npm config get awscli_profile) --region us-east-1 --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers && ./cdn-cache-clear.sh dogfood",
@@ -38,7 +38,7 @@
         "@0x/contract-addresses": "^4.1.0",
         "@0x/contract-wrappers": "^13.18.0",
         "@0x/contracts-dev-utils": "^1.0.2",
-        "@0x/contracts-treasury": "^1.0.2",
+        "@0x/contracts-treasury": "^1.4.2",
         "@0x/json-schemas": "^6.4.0",
         "@0x/order-utils": "^10.0.1",
         "@0x/subproviders": "^6.6.1",
@@ -125,7 +125,7 @@
         "sass-loader": "^7.1.0",
         "semver": "5.5.0",
         "semver-sort": "0.0.4",
-        "styled-components": "^5.0.0",
+        "styled-components": "^5.3.1",
         "thenby": "^1.2.3",
         "truffle-contract": "2.0.1",
         "urql": "^2.0.4",
@@ -169,7 +169,7 @@
         "@types/react-syntax-highlighter": "^10.2.1",
         "@types/react-transition-group": "^4.2.0",
         "@types/redux": "^3.6.0",
-        "@types/styled-components": "4.1.1",
+        "@types/styled-components": "^5.1.15",
         "@types/valid-url": "^1.0.2",
         "@types/web3-provider-engine": "^14.0.0",
         "@types/yargs": "^11.0.0",
@@ -206,7 +206,7 @@
         "ts-node": "^8.3.0",
         "tslint": "5.11.0",
         "tslint-config-0xproject": "^0.0.2",
-        "typescript": "^3.7.4",
+        "typescript": "^3.8.3",
         "unist-util-find-after": "^2.0.4",
         "unist-util-modify-children": "^1.1.4",
         "unist-util-select": "^2.0.2",

ts/blockchain.ts

@@ -622,7 +622,7 @@ export class Blockchain {
         const provider = this._contractWrappers.getProvider();
         const web3Wrapper = new Web3Wrapper(provider);
         const exchangeAbi = this._contractWrappers.exchange.abi;
-        web3Wrapper.abiDecoder.addABI(exchangeAbi);
+        web3Wrapper.abiDecoder.addABI(exchangeAbi as any);
         const receipt = await web3Wrapper.awaitTransactionSuccessAsync(txHash);
         return receipt;
     }
@@ -935,9 +935,9 @@ export class Blockchain {
     }
     private async _updateDefaultGasPriceAsync(): Promise<void> {
         try {
-            const localStorageSpeed = localStorage.getItem('gas-speed');
-            const { gasPriceInWei } = await backendClient.getGasInfoAsync(localStorageSpeed || 'standard');
-            this._defaultGasPrice = gasPriceInWei;
+            const { price } = await backendClient.getGasInfoAsync('standard');
+            // HACK: this is not supporting EIP1559 but this file is legacy and not used anywhere
+            this._defaultGasPrice = new BigNumber(price);
         } catch (err) {
             return;
         }

ts/pages/mesh/mesh_stats.tsx

@@ -28,7 +28,7 @@ const fetchOrders = async () => fetchUtils.requestAsync(ordersBaseUrl, ordersPat
 export const MeshStats: React.FC = () => {
     const [meshFetchedSnapshot, setMeshSnapshot] = useState<{ meshNodes: MeshNodeMetaData[] }>();
     const [meshData, setMeshData] = useState<{ numActiveNodes: number; numEdges: number }>();
-    const [orders, setOrders] = useState();
+    const [orders, setOrders] = useState<{ total: number }>();
 
     const [nodeDetails, setNodeDetails] = useState<{ data?: MeshNodeMetaData; isVisible: boolean }>({
         data: undefined,

ts/style/theme.ts

@@ -27,13 +27,7 @@ export interface IThemeInterface {
 }
 
 // tslint:disable:no-unnecessary-type-assertion
-const {
-    default: styled,
-    css,
-    createGlobalStyle,
-    keyframes,
-    ThemeProvider,
-} = styledComponents as styledComponents.ThemedStyledComponentsModule<IThemeInterface>;
+const { default: styled, css, createGlobalStyle, keyframes, ThemeProvider } = styledComponents;
 // tslint:enable:no-unnecessary-type-assertion
 
 export { styled, css, createGlobalStyle, keyframes, ThemeProvider };

ts/utils/order_utils.ts

@@ -48,7 +48,7 @@ export const orderHashUtils = {
         // format, we only assert that we were indeed passed a string.
         assert.isString('orderHash', orderHash);
         const schemaValidator = new SchemaValidator();
-        const isValid = schemaValidator.validate(orderHash, schemas.orderHashSchema).valid;
+        const isValid = schemaValidator.isValid(orderHash, schemas.orderHashSchema);
         return isValid;
     },