Always compare both tfm AND rid for matching the target in a lock file

Fixes #90

Author: 0xced

CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 * All nodes of the graph can now contain clickable links to their corresponding nuget.org page. This new behavior can be enabled by setting the `ChiselGraphIncludeLinks` MSBuild property to `true`. See the [ChiselGraphIncludeLinks](https://github.com/0xced/Chisel#chiselgraphincludelinks) documentation in the README for more information.
 * The graph now includes a title that defaults to `Dependency graph of $(MSBuildProjectName) ($(TargetFramework))`. See the [ChiselGraphTitle](https://github.com/0xced/Chisel#chiselgraphtitle) documentation in the README for more information.
 * The version numbers in the graph are now displayed with a `@` symbol instead of a `/` symbol when [ChiselGraphIncludeVersions](https://github.com/0xced/Chisel#chiselgraphincludeversions) is enabled.
+* Fixed a bug where Chisel could fail with ArgumentException: Multiple targets are matching … Reported by @codeguru42 in #90.
 
 ## [1.1.2][1.1.2] - 2025-02-17
 

src/Chisel/LockFileExtensions.cs

@@ -11,16 +11,17 @@ internal static class LockFileExtensions
 {
     public static (IReadOnlyDictionary<string, Package> Packages, IReadOnlyCollection<Package> Roots) ReadPackages(this LockFile lockFile, string tfm, string? rid, Predicate<Package>? filter = null)
     {
+        var runtimeIdentifier = string.IsNullOrEmpty(rid) ? null : rid;
         var frameworks = lockFile.PackageSpec?.TargetFrameworks?.Where(e => e.TargetAlias == tfm).ToList() ?? [];
         var framework = frameworks.Count switch
         {
             0 => throw new ArgumentException($"Target framework \"{tfm}\" is not available in assets at \"{lockFile.Path}\" (JSON path: project.frameworks.*.targetAlias)", nameof(tfm)),
             1 => frameworks[0],
             _ => throw new ArgumentException($"Multiple target frameworks are matching \"{tfm}\" in assets at \"{lockFile.Path}\" (JSON path: project.frameworks.*.targetAlias)", nameof(tfm)),
         };
-        var targets = lockFile.Targets.Where(e => e.TargetFramework == framework.FrameworkName && (string.IsNullOrEmpty(rid) || e.RuntimeIdentifier == rid)).ToList();
+        var targets = lockFile.Targets.Where(e => e.TargetFramework == framework.FrameworkName && e.RuntimeIdentifier == runtimeIdentifier).ToList();
         // https://github.com/NuGet/NuGet.Client/blob/6.10.0.52/src/NuGet.Core/NuGet.ProjectModel/LockFile/LockFileTarget.cs#L17
-        var targetId = framework.FrameworkName + (string.IsNullOrEmpty(rid) ? "" : $"/{rid}");
+        var targetId = framework.FrameworkName + (string.IsNullOrEmpty(runtimeIdentifier) ? "" : $"/{runtimeIdentifier}");
         var target = targets.Count switch
         {
             0 => throw new ArgumentException($"Target \"{targetId}\" is not available in assets at \"{lockFile.Path}\" (JSON path: targets)", nameof(rid)),

tests/Chisel.Tests/DependencyGraphTest.cs

@@ -178,11 +178,14 @@ public async Task PollyGraphIgnoreGlob(bool includeLinks, [CombinatorialValues("
         await Verify(writer.ToString(), format == "graphviz" ? "gv" : "mmd").UseParameters(includeLinks, format);
     }
 
-    [Fact]
-    public void ValidProjectVersion()
+    [Theory]
+    [InlineData("win-x64")]
+    [InlineData("")]
+    [InlineData(null)]
+    public void ValidProjectVersion(string? rid)
     {
         var lockFile = new LockFileFormat().Read(GetAssetsPath("SqlClientGraph.json"));
-        var (packages, roots) = lockFile.ReadPackages(tfm: "net8.0-windows", rid: "win-x64", package => package.IsProjectReference || SqlClientCopyLocalPackages.Contains(package.Name));
+        var (packages, roots) = lockFile.ReadPackages(tfm: "net8.0-windows", rid: rid, package => package.IsProjectReference || SqlClientCopyLocalPackages.Contains(package.Name));
         var graph = new DependencyGraph(packages, roots, ignores: []);
 
         graph.EnumerateUnsatisfiedProjectDependencies().Should().BeEmpty();