Fix potential infinite loop in TryGetOriginalTargetFrameworkAttribute
#567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential infinite loop that could occur when a custom
IAssemblyResolverimplementation callsTryGetOriginalTargetFrameworkAttributeon the source module. If this method encounters a generic attribute, upon resolving its name, it will call theMemberRefconstructor, which will callResolveTypeDef, which can create an infinite loop and lead to a stack overflow.Since the TargetFrameworkAttribute is not generic, a simple and easy fix is to just skip the processing of all attributes that are generic using the same condition as used in the
MemberRefconstructor to prevent theResolveTypeDefcall.