Commit 9dc0ec6
committed
refactor: document Quant validation rationale, demote extreme benchmark to log-only
Finding 1 (Quant forgeable): intentional design choice, now documented
in NatSpec. All functions are internal pure; the expected pattern is a
single create() at construction. Per-call validation would penalize
correct usage for a scenario that only arises from explicit wrap() misuse.
Finding 2 (extreme benchmark): the 80% savings threshold was a property
of the 12:1 slot ratio, not the library. Converted to log-only so it
serves as documentation rather than a misleading regression gate.
Real-life benchmark (>= 32%) remains as the CI gate.1 parent 013cc6f commit 9dc0ec6
File tree
3 files changed
+15
-7
lines changed- src
- test/showcase
3 files changed
+15
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
69 | 68 | | |
70 | 69 | | |
71 | 70 | | |
72 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
81 | 83 | | |
82 | 84 | | |
83 | 85 | | |
| |||
0 commit comments