Update NewAccessKey to return a boolean for success and adjust tests accordingly

Author: klaidliadon

access_key.go

@@ -49,18 +49,18 @@ func (a AccessKey) GetPrefix() string {
 	return strings.Join(parts[:len(parts)-1], Separator)
 }
 
-func NewAccessKey(ctx context.Context, projectID uint64) AccessKey {
+func NewAccessKey(ctx context.Context, projectID uint64) (AccessKey, bool) {
 	version, ok := GetVersion(ctx)
 	if !ok {
-		return DefaultEncoding.Encode(ctx, projectID)
+		return DefaultEncoding.Encode(ctx, projectID), true
 	}
 
 	for _, e := range SupportedEncodings {
 		if e.Version() == version {
-			return e.Encode(ctx, projectID)
+			return e.Encode(ctx, projectID), true
 		}
 	}
-	return ""
+	return "", false
 }
 
 type Encoding interface {

access_key_test.go

@@ -14,7 +14,8 @@ func TestAccessKeyEncoding(t *testing.T) {
 	t.Run("v0", func(t *testing.T) {
 		ctx := authcontrol.WithVersion(context.Background(), 0)
 		projectID := uint64(12345)
-		accessKey := authcontrol.NewAccessKey(ctx, projectID)
+		accessKey, ok := authcontrol.NewAccessKey(ctx, projectID)
+		require.True(t, ok)
 		t.Log("=> k", accessKey)
 
 		outID, err := accessKey.GetProjectID()
@@ -25,7 +26,8 @@ func TestAccessKeyEncoding(t *testing.T) {
 	t.Run("v1", func(t *testing.T) {
 		ctx := authcontrol.WithVersion(context.Background(), 1)
 		projectID := uint64(12345)
-		accessKey := authcontrol.NewAccessKey(ctx, projectID)
+		accessKey, ok := authcontrol.NewAccessKey(ctx, projectID)
+		require.True(t, ok)
 		t.Log("=> k", accessKey)
 		outID, err := accessKey.GetProjectID()
 		require.NoError(t, err)
@@ -34,15 +36,17 @@ func TestAccessKeyEncoding(t *testing.T) {
 	t.Run("v2", func(t *testing.T) {
 		ctx := authcontrol.WithVersion(context.Background(), 2)
 		projectID := uint64(12345)
-		accessKey := authcontrol.NewAccessKey(ctx, projectID)
+		accessKey, ok := authcontrol.NewAccessKey(ctx, projectID)
+		require.True(t, ok)
 		t.Log("=> k", accessKey, "| prefix =>", accessKey.GetPrefix())
 		outID, err := accessKey.GetProjectID()
 		require.NoError(t, err)
 		require.Equal(t, projectID, outID)
 
 		ctx = authcontrol.WithPrefix(ctx, "newprefix:dev")
 
-		accessKey2 := authcontrol.NewAccessKey(ctx, projectID)
+		accessKey2, ok := authcontrol.NewAccessKey(ctx, projectID)
+		require.True(t, ok)
 		t.Log("=> k", accessKey2, "| prefix =>", accessKey2.GetPrefix())
 		outID, err = accessKey2.GetProjectID()
 		require.NoError(t, err)
@@ -56,7 +60,8 @@ func TestAccessKeyEncoding(t *testing.T) {
 
 func TestDecode(t *testing.T) {
 	ctx := authcontrol.WithVersion(context.Background(), 2)
-	accessKey := authcontrol.NewAccessKey(ctx, 237)
+	accessKey, ok := authcontrol.NewAccessKey(ctx, 237)
+	require.True(t, ok)
 	t.Log("=> k", accessKey, "| prefix =>", accessKey.GetPrefix())
 }
 

go.work.sum

@@ -15,6 +15,7 @@ github.com/xhit/go-str2duration/v2 v2.1.0/go.mod h1:ohY8p+0f07DiV6Em5LKB0s2YpLtX
 golang.org/x/crypto v0.27.0/go.mod h1:1Xngt8kV6Dvbssa53Ziq6Eqn0HqbZi5Z6R0ZpwQzt70=
 golang.org/x/mod v0.17.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
 golang.org/x/net v0.28.0/go.mod h1:yqtgsTWOOnlGLG9GFRrK3++bGOUEkNBoHZc8MEDWPNg=
+golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
 golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
 golang.org/x/oauth2 v0.24.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
 golang.org/x/sys v0.23.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=