Skip to content

Commit 3d2a62c

Browse files
authored
improvements (#181)
1 parent a18d350 commit 3d2a62c

File tree

17 files changed

+141
-176
lines changed

17 files changed

+141
-176
lines changed

cmd/chain-ethgas/main.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ import (
44
"context"
55
"fmt"
66
"log"
7+
"log/slog"
8+
"os"
79
"time"
810

911
"github.com/0xsequence/ethkit/ethgas"
1012
"github.com/0xsequence/ethkit/ethmonitor"
1113
"github.com/0xsequence/ethkit/ethrpc"
1214
"github.com/0xsequence/ethkit/util"
13-
"github.com/goware/logger"
1415
)
1516

1617
var ETH_NODE_URL = "http://localhost:8545"
@@ -68,7 +69,7 @@ func main() {
6869
}()
6970
defer monitor.Stop()
7071

71-
logger := logger.NewLogger(logger.LogLevel_INFO)
72+
logger := slog.New(slog.NewTextHandler(os.Stdout, nil))
7273

7374
gasGague, err := ethgas.NewGasGauge(logger, monitor, 1, false)
7475
if err != nil {

cmd/chain-receipts/main.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import (
55
"context"
66
"fmt"
77
"log"
8+
"log/slog"
9+
"os"
810
"sync"
911
"time"
1012

@@ -16,7 +18,6 @@ import (
1618
"github.com/0xsequence/ethkit/go-ethereum/core/types"
1719
"github.com/0xsequence/ethkit/go-ethereum/crypto"
1820
"github.com/0xsequence/ethkit/util"
19-
"github.com/goware/logger"
2021
)
2122

2223
var ETH_NODE_URL = "http://localhost:8545"
@@ -84,7 +85,11 @@ func listener(provider *ethrpc.Provider, monitorOptions ethmonitor.Options, rece
8485
// monitorSub := monitor.Subscribe()
8586
// defer monitorSub.Unsubscribe()
8687

87-
receiptListener, err := ethreceipts.NewReceiptsListener(logger.NewLogger(logger.LogLevel_INFO), provider, monitor, receiptListenerOptions)
88+
logger := slog.New(slog.NewTextHandler(os.Stdout, &slog.HandlerOptions{
89+
Level: slog.LevelInfo,
90+
}))
91+
92+
receiptListener, err := ethreceipts.NewReceiptsListener(logger, provider, monitor, receiptListenerOptions)
8893
if err != nil {
8994
log.Fatal(err)
9095
}

cmd/chain-watch/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"encoding/json"
66
"fmt"
77
"log"
8+
"log/slog"
89
"math/big"
910
"os"
1011
"path/filepath"
@@ -16,7 +17,6 @@ import (
1617
"github.com/0xsequence/ethkit/util"
1718
rediscache "github.com/goware/cachestore-redis"
1819
cachestore "github.com/goware/cachestore2"
19-
"github.com/goware/logger"
2020
"github.com/goware/pp"
2121
)
2222

@@ -93,7 +93,7 @@ func main() {
9393
// monitorOptions.StartBlockNumber = big.NewInt(3754824)
9494
// monitorOptions.Bootstrap = true
9595

96-
monitorOptions.Logger = logger.NewLogger(logger.LogLevel_DEBUG)
96+
monitorOptions.Logger = slog.Default()
9797
monitorOptions.DebugLogging = true
9898

9999
// monitorOptions.TrailNumBlocksBehindHead = 4

cmd/ethkit/_receipts.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ package main
33
import (
44
"context"
55
"fmt"
6+
"log/slog"
67
"time"
78

89
"github.com/0xsequence/ethkit/ethmonitor"
910
"github.com/0xsequence/ethkit/ethreceipts"
1011
"github.com/0xsequence/ethkit/ethrpc"
11-
"github.com/goware/logger"
1212
"github.com/spf13/cobra"
1313
)
1414

@@ -33,15 +33,15 @@ type watch struct {
3333
func (c *watch) Run(cmd *cobra.Command, args []string) {
3434
fmt.Println("xx")
3535

36-
log := logger.NewLogger(logger.LogLevel_DEBUG)
36+
logger := slog.Default()
3737

3838
provider, err := ethrpc.NewProvider("https://xxx")
3939
if err != nil {
4040
panic(err)
4141
}
4242

4343
monitorOptions := ethmonitor.DefaultOptions
44-
monitorOptions.Logger = log
44+
monitorOptions.Logger = logger
4545
monitorOptions.WithLogs = true
4646
monitorOptions.BlockRetentionLimit = 1000
4747

@@ -50,7 +50,7 @@ func (c *watch) Run(cmd *cobra.Command, args []string) {
5050
panic(err)
5151
}
5252

53-
receipts, err := ethreceipts.NewReceiptsListener(log, provider, monitor)
53+
receipts, err := ethreceipts.NewReceiptsListener(logger, provider, monitor)
5454
if err != nil {
5555
panic(err)
5656
}

cmd/ethkit/wallet.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
"github.com/0xsequence/ethkit/go-ethereum/accounts/keystore"
1515
"github.com/0xsequence/ethkit/go-ethereum/common"
1616
"github.com/spf13/cobra"
17-
"golang.org/x/crypto/ssh/terminal"
17+
"golang.org/x/term"
1818
)
1919

2020
func init() {
@@ -261,7 +261,7 @@ func fileExists(filename string) bool {
261261

262262
func readSecretInput(prompt string) ([]byte, error) {
263263
fmt.Print(prompt)
264-
password, err := terminal.ReadPassword(int(syscall.Stdin))
264+
password, err := term.ReadPassword(int(syscall.Stdin))
265265
if err != nil {
266266
return nil, err
267267
}

ethgas/ethgas.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ package ethgas
33
import (
44
"context"
55
"fmt"
6+
"log/slog"
67
"math/big"
78
"sort"
89
"sync/atomic"
910

1011
"github.com/0xsequence/ethkit/ethmonitor"
11-
"github.com/goware/logger"
1212
)
1313

1414
const (
@@ -23,7 +23,7 @@ var (
2323
)
2424

2525
type GasGauge struct {
26-
log logger.Logger
26+
log *slog.Logger
2727
monitor *ethmonitor.Monitor
2828
chainID uint64
2929
gasPriceBidReader GasPriceReader
@@ -79,7 +79,7 @@ func (p SuggestedGasPrice) WithMin(minWei *big.Int) SuggestedGasPrice {
7979
return p
8080
}
8181

82-
func NewGasGaugeWei(log logger.Logger, monitor *ethmonitor.Monitor, minGasPriceInWei uint64, useEIP1559 bool) (*GasGauge, error) {
82+
func NewGasGaugeWei(log *slog.Logger, monitor *ethmonitor.Monitor, minGasPriceInWei uint64, useEIP1559 bool) (*GasGauge, error) {
8383
if minGasPriceInWei == 0 {
8484
return nil, fmt.Errorf("minGasPriceInWei cannot be 0, pass at least 1")
8585
}
@@ -106,7 +106,7 @@ func NewGasGaugeWei(log logger.Logger, monitor *ethmonitor.Monitor, minGasPriceI
106106
}, nil
107107
}
108108

109-
func NewGasGauge(log logger.Logger, monitor *ethmonitor.Monitor, minGasPriceInGwei uint64, useEIP1559 bool) (*GasGauge, error) {
109+
func NewGasGauge(log *slog.Logger, monitor *ethmonitor.Monitor, minGasPriceInGwei uint64, useEIP1559 bool) (*GasGauge, error) {
110110
if minGasPriceInGwei >= ONE_GWEI {
111111
return nil, fmt.Errorf("minGasPriceInGwei argument expected to be passed as Gwei, but your units look like wei")
112112
}

ethgas/ethgas_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package ethgas_test
22

33
import (
44
"context"
5+
"log/slog"
56
"testing"
67
"time"
78

@@ -10,7 +11,6 @@ import (
1011
"github.com/0xsequence/ethkit/ethrpc"
1112
"github.com/0xsequence/ethkit/util"
1213
"github.com/go-chi/httpvcr"
13-
"github.com/goware/logger"
1414
"github.com/stretchr/testify/assert"
1515
)
1616

@@ -54,7 +54,7 @@ func TestGasGauge(t *testing.T) {
5454
assert.NoError(t, err)
5555

5656
// Setup gas tracker
57-
gasGauge, err := ethgas.NewGasGauge(logger.NewLogger(logger.LogLevel_DEBUG), monitor, 1, false)
57+
gasGauge, err := ethgas.NewGasGauge(slog.Default(), monitor, 1, false)
5858
assert.NoError(t, err)
5959

6060
// wait before we start to ensure any other http requests above are completed

ethmempool/ethmempool.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@ package ethmempool
33
import (
44
"context"
55
"fmt"
6+
"log/slog"
67
"strings"
78
"sync"
89
"sync/atomic"
910

1011
"github.com/0xsequence/ethkit/go-ethereum/rpc"
11-
"github.com/goware/logger"
1212
)
1313

1414
type Options struct {
15-
Logger logger.Logger
15+
Logger *slog.Logger
1616
}
1717

1818
type Mempool struct {
1919
options Options
2020

21-
log logger.Logger
21+
log *slog.Logger
2222
nodeWebsocketURL string
2323
client *rpc.Client
2424
subscribers []*subscriber

0 commit comments

Comments
 (0)