Skip to content

Commit 5c62291

Browse files
authored
Merge pull request #177 from 0xsequence/Fix/regexValidateAbi
Validate ABI function name and signatures
2 parents 93b8ef2 + bd24a04 commit 5c62291

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Assets/SequenceSDK/Ethereum/Tests/ABIRegexTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ public void TestMatchesFunctionName(string input, bool expected)
3232
[TestCase("functionName(a,)", false)]
3333
[TestCase("functionName() ", false)]
3434
[TestCase("function_-123Name()", true)]
35+
[TestCase("function_-123Name(int[])", true)]
36+
[TestCase("functionName(a[],a)", true)]
37+
[TestCase("functionName(a[5],a)", true)]
38+
[TestCase("functionName(a[][],a)", true)]
3539
public void TestMatchesFunctionABI(string input, bool expected)
3640
{
3741
bool result = ABIRegex.MatchesFunctionABI(input);

Packages/Sequence-Unity/Sequence/SequenceSDK/Ethereum/Contract/ABIRegex.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ public static class ABIRegex
44
{
55

66
public const string FunctionNameRegex = @"^[A-Z|a-z|_,-|0-9]+$";
7-
public const string FunctionABIRegex = @"^[A-Z|a-z|_,-|0-9]+\(([A-Z|a-z|0-9]+(, *[A-Z|a-z|0-9]+)*)?\)$";
7+
public const string FunctionABIRegex = @"^[A-Z|a-z|_,-|0-9]+\(([A-Za-z0-9\[\]]+(, *[A-Za-z0-9\[\]]+)*)?\)$";
88

99
public static bool MatchesFunctionName(string input)
1010
{

Packages/Sequence-Unity/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "xyz.0xsequence.waas-unity",
3-
"version": "3.17.3",
3+
"version": "3.17.4",
44
"displayName": "Sequence Embedded Wallet SDK",
55
"description": "A Unity SDK for the Sequence WaaS API",
66
"unity": "2021.3",

0 commit comments

Comments
 (0)