Merge pull request #303 from 0xsequence/Fix/connected-wallet-address

added RemoveConnectedWalletAddress, check if address is null or empty

Author: andygruening

Assets/SequenceSDK/WaaS/Tests/SequenceLoginTests.cs

@@ -0,0 +1,23 @@
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using NUnit.Framework;
+using Sequence.EmbeddedWallet;
+using UnityEngine;
+using UnityEngine.TestTools;
+
+namespace Sequence.WaaS.Tests
+{
+    public class SequenceLoginTests 
+    {
+        [Test]
+        public void TestSetConnectedWalletAddressNull()
+        {
+            LogAssert.Expect(LogType.Error, "The connected wallet address cannot be null or empty.");
+
+            Assert.Throws<ArgumentNullException>(
+                () => SequenceLogin.GetInstance().SetConnectedWalletAddress(null)
+            );
+        }
+    }
+}

Assets/SequenceSDK/WaaS/Tests/SequenceLoginTests.cs.meta

@@ -72,8 +72,19 @@ public static SequenceLogin GetInstanceToFederateAuth(Address connectedWalletAdd
 
         public void SetConnectedWalletAddress(Address connectedWalletAddress)
         {
+            if (connectedWalletAddress == null)
+            {
+                Debug.LogError($"The connected wallet address cannot be null or empty.");
+                throw new ArgumentNullException(nameof(connectedWalletAddress));
+            }
+            
             _connectedWalletAddress = connectedWalletAddress;
         }
+        
+        public void RemoveConnectedWalletAddress()
+        {
+            _connectedWalletAddress = null;
+        }
 
         [Obsolete("Use GetInstance() instead.")]
         public SequenceLogin(IValidator validator = null, IAuthenticator authenticator = null, IWaaSConnector connector = null, bool automaticallyFederateAccountsWhenPossible = true, Address connectedWalletAddress = null)
@@ -123,7 +134,7 @@ public void ResetSessionId()
         public void ResetLoginAfterTest()
         {
             _connector = this;
-            SetConnectedWalletAddress(null);
+            RemoveConnectedWalletAddress();
             SetupAuthenticator();
         }
 

Packages/Sequence-Unity/Sequence/SequenceSDK/EmbeddedWallet/SequenceLogin.cs

@@ -1,6 +1,6 @@
 {
   "name": "xyz.0xsequence.waas-unity",
-  "version": "4.2.3",
+  "version": "4.2.4",
   "displayName": "Sequence Embedded Wallet SDK",
   "description": "A Unity SDK for Sequence APIs",
   "unity": "2021.3",