Merge pull request #302 from 0xsequence/Fix/google-login-hint

andygruening · web-flow · commit efbbfbfc4ebc · 2025-06-03T20:37:55.000+02:00
Checking if the cached email value is empty to avoid having the 'login_hint' inside the sign-in url
diff --git a/Packages/Sequence-Unity/Sequence/SequenceSDK/Authentication/OpenIdAuthenticator.cs b/Packages/Sequence-Unity/Sequence/SequenceSDK/Authentication/OpenIdAuthenticator.cs
@@ -231,7 +231,8 @@ private string GenerateSignInUrl(string baseUrl, string clientId, string state)
 
             string url =
                 $"{baseUrl}?response_type=code+id_token&client_id={clientId}&redirect_uri={_redirectUrl}&scope=openid+email&state={state}/";
-            if (PlayerPrefs.HasKey(LoginEmail))
+            
+            if (PlayerPrefs.HasKey(LoginEmail) && !string.IsNullOrEmpty(PlayerPrefs.GetString(LoginEmail)))
             {
                 url = url.RemoveTrailingSlash() + $"&login_hint={PlayerPrefs.GetString(LoginEmail)}".AppendTrailingSlashIfNeeded();
                 url = url.Replace(" ", "");
diff --git a/Packages/Sequence-Unity/package.json b/Packages/Sequence-Unity/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xyz.0xsequence.waas-unity",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "displayName": "Sequence Embedded Wallet SDK",
   "description": "A Unity SDK for Sequence APIs",
   "unity": "2021.3",

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,8 @@ private string GenerateSignInUrl(string baseUrl, string clientId, string state)`
`231`	`231`
`232`	`232`	`string url =`
`233`	`233`	`$"{baseUrl}?response_type=code+id_token&client_id={clientId}&redirect_uri={_redirectUrl}&scope=openid+email&state={state}/";`
`234`		`- if (PlayerPrefs.HasKey(LoginEmail))`
	`234`	`+`
	`235`	`+ if (PlayerPrefs.HasKey(LoginEmail) && !string.IsNullOrEmpty(PlayerPrefs.GetString(LoginEmail)))`
`235`	`236`	`{`
`236`	`237`	`url = url.RemoveTrailingSlash() + $"&login_hint={PlayerPrefs.GetString(LoginEmail)}".AppendTrailingSlashIfNeeded();`
`237`	`238`	`url = url.Replace(" ", "");`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "xyz.0xsequence.waas-unity",`
`3`		`- "version": "4.2.0",`
	`3`	`+ "version": "4.2.1",`
`4`	`4`	`"displayName": "Sequence Embedded Wallet SDK",`
`5`	`5`	`"description": "A Unity SDK for Sequence APIs",`
`6`	`6`	`"unity": "2021.3",`