Skip to content

Commit 340ebb2

Browse files
authored
Merge pull request #340 from 0xsequence/Fix/marketplace-return-types
fixed marketplace return types for ListAllListingsForCollectible and ListAllOffersForCollectible
2 parents 8f9f488 + 90ed04e commit 340ebb2

File tree

8 files changed

+31
-30
lines changed

8 files changed

+31
-30
lines changed

Plugins/SequencePlugin/Source/SequencePlugin/Private/Marketplace/SequenceMarketplace.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -284,18 +284,18 @@ void USequenceMarketplace::ListListingsForCollectible(const int64 ChainID, const
284284

285285
void USequenceMarketplace::ListAllListingsForCollectible(const int64 ChainID,
286286
const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter,
287-
TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure)
287+
TSuccessCallback<TArray<FSeqOrder>> OnSuccess, const FFailureCallback& OnFailure)
288288
{
289289
const FString Args = BuildArgs<FSeqListCollectibleListingsArgs>(FSeqListCollectibleListingsArgs{ ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty()});
290-
OrderArray.Empty();
290+
RawOrderArray.Empty();
291291

292-
return ListAllListingsForCollectibleHelper(ChainID, ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Orders, const bool IsDone)
292+
return ListAllListingsForCollectibleHelper(ChainID, ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqOrder>& Orders, const bool IsDone)
293293
{
294-
OrderArray.Append(Orders);
294+
RawOrderArray.Append(Orders);
295295

296296
if(IsDone)
297297
{
298-
OnSuccess(OrderArray);
298+
OnSuccess(RawOrderArray);
299299
}
300300
}, OnFailure);
301301
}
@@ -313,18 +313,18 @@ void USequenceMarketplace::ListOffersForCollectible(const int64 ChainID, const F
313313
}, OnFailure);
314314
}
315315

316-
void USequenceMarketplace::ListAllOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure)
316+
void USequenceMarketplace::ListAllOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqOrder>> OnSuccess, const FFailureCallback& OnFailure)
317317
{
318318
const FString Args = BuildArgs<FSeqListCollectibleListingsArgs>(FSeqListCollectibleListingsArgs{ ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty()});
319-
OrderArray.Empty();
319+
RawOrderArray.Empty();
320320

321-
return ListAllOffersForCollectibleHelper(ChainID, ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Orders, bool IsDone)
321+
return ListAllOffersForCollectibleHelper(ChainID, ContractAddress, TokenID, Filter, FSeqMarketplacePage::Empty(), [this, OnSuccess](const TArray<FSeqOrder>& Orders, bool IsDone)
322322
{
323-
OrderArray.Append(Orders);
323+
RawOrderArray.Append(Orders);
324324

325325
if(IsDone)
326326
{
327-
OnSuccess(OrderArray);
327+
OnSuccess(RawOrderArray);
328328
}
329329
}, OnFailure);
330330
}
@@ -402,7 +402,7 @@ void USequenceMarketplace::GetCollectibleOrder(const int64 ChainID, const FStrin
402402

403403
void USequenceMarketplace::ListAllListingsForCollectibleHelper(const int64 ChainID, const FString& ContractAddress,
404404
const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page,
405-
TFunction<void(TArray<FSeqCollectibleOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure)
405+
TFunction<void(TArray<FSeqOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure)
406406
{
407407
ListListingsForCollectible(ChainID, ContractAddress, TokenID, Filter, Page, [ChainID, ContractAddress, Filter, TokenID, this, OnSuccess, OnFailure](const FSeqListCollectibleListingsReturn& CollectiblesReturn)
408408
{
@@ -422,7 +422,7 @@ void USequenceMarketplace::ListAllListingsForCollectibleHelper(const int64 Chain
422422

423423
void USequenceMarketplace::ListAllOffersForCollectibleHelper(const int64 ChainID, const FString& ContractAddress,
424424
const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page,
425-
TFunction<void(TArray<FSeqCollectibleOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure)
425+
TFunction<void(TArray<FSeqOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure)
426426
{
427427
ListOffersForCollectible(ChainID, ContractAddress, TokenID, Filter, Page, [ChainID, ContractAddress, Filter, TokenID, this, OnSuccess, OnFailure](const FSeqListCollectibleOffersReturn& CollectiblesReturn)
428428
{

Plugins/SequencePlugin/Source/SequencePlugin/Private/Subsystems/SequenceMarketplaceBP.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ void USequenceMarketplaceBP::ListListingsForCollectible(const FString& ContractA
172172

173173
void USequenceMarketplaceBP::ListAllListingsForCollectible(const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter Filter, FOnListAllListingsForCollectible OnSuccess, FOnFailure OnFailure)
174174
{
175-
const TSuccessCallback<TArray<FSeqCollectibleOrder>> OnApiSuccess = [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Listings)
175+
const TSuccessCallback<TArray<FSeqOrder>> OnApiSuccess = [this, OnSuccess](const TArray<FSeqOrder>& Listings)
176176
{
177177
OnSuccess.ExecuteIfBound(Listings);
178178
};
@@ -204,7 +204,7 @@ void USequenceMarketplaceBP::ListOffersForCollectible(const FString& ContractAdd
204204

205205
void USequenceMarketplaceBP::ListAllOffersForCollectible(const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter Filter, FOnListAllOffersForCollectible OnSuccess, FOnFailure OnFailure)
206206
{
207-
const TSuccessCallback<TArray<FSeqCollectibleOrder>> OnApiSuccess = [this, OnSuccess](const TArray<FSeqCollectibleOrder>& Offers)
207+
const TSuccessCallback<TArray<FSeqOrder>> OnApiSuccess = [this, OnSuccess](const TArray<FSeqOrder>& Offers)
208208
{
209209
OnSuccess.ExecuteIfBound(Offers);
210210
};

Plugins/SequencePlugin/Source/SequencePlugin/Public/Marketplace/SequenceMarketplace.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ class SEQUENCEPLUGIN_API USequenceMarketplace : public UObject
1919
const FString PATH = "/rpc/Marketplace/";
2020

2121
TArray<FSeqCollectibleOrder> OrderArray;
22+
TArray<FSeqOrder> RawOrderArray;
2223

2324
//private functions
2425

@@ -37,8 +38,8 @@ class SEQUENCEPLUGIN_API USequenceMarketplace : public UObject
3738
void ListAllCollectibleOffersWithHighestPricedOfferFirstHelper(const int64 ChainID, const FString& ContractAddress, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TFunction<void(TArray<FSeqCollectibleOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure);
3839
void GetCollectibleOrder(int64 ChainID, const FString& Endpoint, const FSeqGetCollectibleOrderArgs& Args,
3940
TSuccessCallback<FSeqCollectibleOrder> OnSuccess, const FFailureCallback& OnFailure);
40-
void ListAllListingsForCollectibleHelper(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TFunction<void(TArray<FSeqCollectibleOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure);
41-
void ListAllOffersForCollectibleHelper(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TFunction<void(TArray<FSeqCollectibleOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure);
41+
void ListAllListingsForCollectibleHelper(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TFunction<void(TArray<FSeqOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure);
42+
void ListAllOffersForCollectibleHelper(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, const FSeqMarketplacePage& Page, TFunction<void(TArray<FSeqOrder>, bool)> OnSuccess, const FFailureCallback& OnFailure);
4243

4344
public:
4445

@@ -183,7 +184,7 @@ class SEQUENCEPLUGIN_API USequenceMarketplace : public UObject
183184
* @param OnSuccess handler for success, takes in a TArray of FSeqCollectibleOrder
184185
* @param OnFailure handler for failure, takes in a FSequenceError
185186
*/
186-
void ListAllListingsForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure);
187+
void ListAllListingsForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqOrder>> OnSuccess, const FFailureCallback& OnFailure);
187188

188189
/**
189190
* Get offers for a collectible
@@ -206,7 +207,7 @@ class SEQUENCEPLUGIN_API USequenceMarketplace : public UObject
206207
* @param OnSuccess handler for success, takes in a TArray of FSeqCollectibleOrder
207208
* @param OnFailure handler for failure, takes in a FSequenceError
208209
*/
209-
void ListAllOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqCollectibleOrder>> OnSuccess, const FFailureCallback& OnFailure);
210+
void ListAllOffersForCollectible(const int64 ChainID, const FString& ContractAddress, const FString& TokenID, const FSeqCollectiblesFilter& Filter, TSuccessCallback<TArray<FSeqOrder>> OnSuccess, const FFailureCallback& OnFailure);
210211

211212
/**
212213
* Get the floor order for a collectible

Plugins/SequencePlugin/Source/SequencePlugin/Public/Marketplace/Structs/SeqListCollectibleListingsReturn.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ struct SEQUENCEPLUGIN_API FSeqListCollectibleListingsReturn
1414
public:
1515

1616
UPROPERTY(EditAnywhere, BlueprintReadWrite, Category = "Collectibles")
17-
TArray<FSeqCollectibleOrder> Listings;
17+
TArray<FSeqOrder> Listings;
1818

1919
UPROPERTY(EditAnywhere, BlueprintReadWrite, Category = "Collectibles")
2020
FSeqMarketplacePage Page;
@@ -36,7 +36,7 @@ struct SEQUENCEPLUGIN_API FSeqListCollectibleListingsReturn
3636

3737
// Convert CollectibleOrders array to JSON
3838
TArray<TSharedPtr<FJsonObject>> collectibleOrdersList;
39-
for (FSeqCollectibleOrder order : Listings)
39+
for (FSeqOrder order : Listings)
4040
{
4141
collectibleOrdersList.Add(order.GetJson());
4242
}

Plugins/SequencePlugin/Source/SequencePlugin/Public/Marketplace/Structs/SeqListCollectibleOffersReturn.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ struct SEQUENCEPLUGIN_API FSeqListCollectibleOffersReturn
1414
public:
1515

1616
UPROPERTY(EditAnywhere, BlueprintReadWrite, Category = "Collectibles")
17-
TArray<FSeqCollectibleOrder> Offers;
17+
TArray<FSeqOrder> Offers;
1818

1919
UPROPERTY(EditAnywhere, BlueprintReadWrite, Category = "Collectibles")
2020
FSeqMarketplacePage Page;
@@ -36,7 +36,7 @@ struct SEQUENCEPLUGIN_API FSeqListCollectibleOffersReturn
3636

3737
// Convert CollectibleOrders array to JSON
3838
TArray<TSharedPtr<FJsonObject>> collectibleOrdersList;
39-
for (FSeqCollectibleOrder order : Offers)
39+
for (FSeqOrder order : Offers)
4040
{
4141
collectibleOrdersList.Add(order.GetJson());
4242
}

Plugins/SequencePlugin/Source/SequencePlugin/Public/Subsystems/SequenceMarketplaceBP.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ class SEQUENCEPLUGIN_API USequenceMarketplaceBP : public UGameInstanceSubsystem
2121
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnGetHighestPriceOfferForCollectible, FSeqTokenMetaData, TokenMetadata, FSeqOrder, Order);
2222
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnGetLowestPriceListingForCollectible, FSeqTokenMetaData, TokenMetadata, FSeqOrder, Order);
2323
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnGetHighestPriceListingForCollectible, FSeqTokenMetaData, TokenMetadata, FSeqOrder, Order);
24-
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnListListingsForCollectible, const TArray<FSeqCollectibleOrder>&, Orders, FSeqMarketplacePage, Page);
25-
DECLARE_DYNAMIC_DELEGATE_OneParam(FOnListAllListingsForCollectible, const TArray<FSeqCollectibleOrder>&, Orders);
26-
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnListOffersForCollectible, const TArray<FSeqCollectibleOrder>&, Orders, FSeqMarketplacePage, Page);
27-
DECLARE_DYNAMIC_DELEGATE_OneParam(FOnListAllOffersForCollectible, const TArray<FSeqCollectibleOrder>&, Orders);
24+
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnListListingsForCollectible, const TArray<FSeqOrder>&, Orders, FSeqMarketplacePage, Page);
25+
DECLARE_DYNAMIC_DELEGATE_OneParam(FOnListAllListingsForCollectible, const TArray<FSeqOrder>&, Orders);
26+
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnListOffersForCollectible, const TArray<FSeqOrder>&, Orders, FSeqMarketplacePage, Page);
27+
DECLARE_DYNAMIC_DELEGATE_OneParam(FOnListAllOffersForCollectible, const TArray<FSeqOrder>&, Orders);
2828
DECLARE_DYNAMIC_DELEGATE_TwoParams(FOnGetFloorOrder, FSeqTokenMetaData, TokenMetadata, FSeqOrder, Order);
2929
DECLARE_DYNAMIC_DELEGATE_OneParam(FOnFailure, FString, Error);
3030

Plugins/SequenceTests/Source/SequenceTests/Private/MarketplaceEndToEndTests/ListAllListingsForCollectibleTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ bool FListAllListingsForCollectible::RunTest(const FString& Parameters)
4949

5050
UMarketplaceRequestsTestData* MarketplaceTestData = UMarketplaceRequestsTestData::Make(1);
5151

52-
const TSuccessCallback<TArray<FSeqCollectibleOrder>> GenericSuccess = [this, MarketplaceTestData](TArray<FSeqCollectibleOrder> Orders)
52+
const TSuccessCallback<TArray<FSeqOrder>> GenericSuccess = [this, MarketplaceTestData](TArray<FSeqOrder> Orders)
5353
{
5454
if(Orders.Num() == 0)
5555
{
@@ -62,7 +62,7 @@ bool FListAllListingsForCollectible::RunTest(const FString& Parameters)
6262
else
6363
{
6464
FString Message;
65-
for(FSeqCollectibleOrder Order : Orders)
65+
for(FSeqOrder Order : Orders)
6666
{
6767
Message += USequenceSupport::StructToString(Order) + "\n";
6868
}

Plugins/SequenceTests/Source/SequenceTests/Private/MarketplaceEndToEndTests/ListAllOffersForCollectibleTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ bool FListAllOffersForCollectibleTest::RunTest(const FString& Parameters)
4949

5050
UMarketplaceRequestsTestData* MarketplaceTestData = UMarketplaceRequestsTestData::Make(1);
5151

52-
const TSuccessCallback<TArray<FSeqCollectibleOrder>> GenericSuccess = [this, MarketplaceTestData](TArray<FSeqCollectibleOrder> Orders)
52+
const TSuccessCallback<TArray<FSeqOrder>> GenericSuccess = [this, MarketplaceTestData](TArray<FSeqOrder> Orders)
5353
{
5454
if(Orders.Num() == 0)
5555
{
@@ -62,7 +62,7 @@ bool FListAllOffersForCollectibleTest::RunTest(const FString& Parameters)
6262
else
6363
{
6464
FString Message;
65-
for(FSeqCollectibleOrder Order : Orders)
65+
for(FSeqOrder Order : Orders)
6666
{
6767
Message += USequenceSupport::StructToString(Order) + "\n";
6868
}

0 commit comments

Comments
 (0)