Optimise trails data slice (#67)

Author: ScreamingHawk

.gas-snapshot

@@ -48,20 +48,20 @@ TrailsIntentEntrypointTest:testPermitAmountExcessiveWithFee() (gas: 83027)
 TrailsIntentEntrypointTest:testPermitAmountInsufficientWithFee() (gas: 82059)
 TrailsIntentEntrypointTest:testUsedIntentsMapping() (gas: 113770)
 TrailsIntentEntrypointTest:testVersionConstant() (gas: 10381)
-TrailsRouterDeploymentTest:test_DeployTrailsRouter_SameAddress() (gas: 1773856)
-TrailsRouterDeploymentTest:test_DeployTrailsRouter_Success() (gas: 1764409)
-TrailsRouterDeploymentTest:test_DeployedRouter_HasCorrectConfiguration() (gas: 1764205)
-TrailsRouterShimDeploymentTest:test_DeployRouterShim_SameAddress() (gas: 7285038)
-TrailsRouterShimDeploymentTest:test_DeployRouterShim_Success() (gas: 4709602)
-TrailsRouterShimDeploymentTest:test_DeployedContract_HasCorrectConfiguration() (gas: 4709648)
+TrailsRouterDeploymentTest:test_DeployTrailsRouter_SameAddress() (gas: 1722289)
+TrailsRouterDeploymentTest:test_DeployTrailsRouter_Success() (gas: 1712948)
+TrailsRouterDeploymentTest:test_DeployedRouter_HasCorrectConfiguration() (gas: 1712744)
+TrailsRouterShimDeploymentTest:test_DeployRouterShim_SameAddress() (gas: 7130985)
+TrailsRouterShimDeploymentTest:test_DeployRouterShim_Success() (gas: 4606895)
+TrailsRouterShimDeploymentTest:test_DeployedContract_HasCorrectConfiguration() (gas: 4606941)
 TrailsRouterShimTest:testConstructorValidation() (gas: 69336)
 TrailsRouterShimTest:testForwardToRouterReturnValue() (gas: 713355)
 TrailsRouterShimTest:testRouterAddressImmutable() (gas: 1391679)
 TrailsRouterShimTest:test_constructor_revert_zeroRouter() (gas: 68984)
-TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_sstore_inactive() (gas: 1766894)
+TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_sstore_inactive() (gas: 1715664)
 TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_tstore_active() (gas: 38392)
 TrailsRouterShimTest:test_delegatecall_router_revert_bubbles_as_RouterCallFailed() (gas: 82109)
-TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_sstore_when_no_tstore() (gas: 1749120)
+TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_sstore_when_no_tstore() (gas: 1697892)
 TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_tstore_when_supported() (gas: 20706)
 TrailsRouterShimTest:test_direct_handleSequenceDelegateCall_reverts_not_delegatecall() (gas: 9840)
 TrailsRouterShimTest:test_forwardToRouter_return_data_handling() (gas: 729052)
@@ -74,11 +74,11 @@ TrailsRouterShimTest:test_handleSequenceDelegateCall_with_eth_value() (gas: 3210
 TrailsRouterShimTest:test_handleSequenceDelegateCall_zero_call_value() (gas: 26873)
 TrailsRouterShimTest:test_sentinel_setting_with_different_op_hashes() (gas: 36405)
 TrailsRouterTest:testDelegateCallWithETH() (gas: 326063)
-TrailsRouterTest:testExecute_WithFailingMulticall() (gas: 520730)
-TrailsRouterTest:testHandleSequenceDelegateCall_InjectAndCall() (gas: 72512)
+TrailsRouterTest:testExecute_WithFailingMulticall() (gas: 450208)
+TrailsRouterTest:testHandleSequenceDelegateCall_InjectAndCall() (gas: 72545)
 TrailsRouterTest:testHandleSequenceDelegateCall_RefundAndSweep() (gas: 85300)
 TrailsRouterTest:testHandleSequenceDelegateCall_Sweep() (gas: 48605)
-TrailsRouterTest:testHandleSequenceDelegateCall_ValidateOpHashAndSweep() (gas: 59810)
+TrailsRouterTest:testHandleSequenceDelegateCall_ValidateOpHashAndSweep() (gas: 59682)
 TrailsRouterTest:testInjectAndCall_NoReplacementNeeded() (gas: 989297)
 TrailsRouterTest:testInjectAndCall_WithReplacement() (gas: 995954)
 TrailsRouterTest:testInjectAndCall_WithTokenZeroBalance() (gas: 647003)
@@ -88,7 +88,7 @@ TrailsRouterTest:testInjectSweepAndCall_WithETH_TargetCallFails() (gas: 57470)
 TrailsRouterTest:testInjectSweepAndCall_WithETH_ZeroBalance() (gas: 12588)
 TrailsRouterTest:testInjectSweepAndCall_WithToken_TargetCallFails() (gas: 995574)
 TrailsRouterTest:testInjectSweepAndCall_WithToken_ZeroBalance() (gas: 648071)
-TrailsRouterTest:testInsufficientEthValidation() (gas: 95772)
+TrailsRouterTest:testInsufficientEthValidation() (gas: 25250)
 TrailsRouterTest:testNativeTransferFailure() (gas: 86597)
 TrailsRouterTest:testRefundAndSweep_FullRefund() (gas: 56088)
 TrailsRouterTest:testRefundAndSweep_PartialRefundERC20() (gas: 88307)
@@ -99,20 +99,20 @@ TrailsRouterTest:testRevertWhen_injectSweepAndCall_InsufficientAllowance() (gas:
 TrailsRouterTest:testRevertWhen_injectSweepAndCall_NoEthSent() (gas: 15756)
 TrailsRouterTest:testSweepAndCallETH() (gas: 78594)
 TrailsRouterTest:testValidateOpHashAndSweep_WithoutSentinel() (gas: 16410)
-TrailsRouterTest:test_Execute_FromContract_ShouldPreserveContractAsSender() (gas: 95127)
-TrailsRouterTest:test_Execute_FromEOA_ShouldPreserveEOAAsSender() (gas: 99771)
-TrailsRouterTest:test_Execute_WithMultipleCalls() (gas: 156006)
+TrailsRouterTest:test_Execute_FromContract_ShouldPreserveContractAsSender() (gas: 24565)
+TrailsRouterTest:test_Execute_FromEOA_ShouldPreserveEOAAsSender() (gas: 29209)
+TrailsRouterTest:test_Execute_WithMultipleCalls() (gas: 30915)
 TrailsRouterTest:test_Multicall3Address_IsCorrect() (gas: 6570)
 TrailsRouterTest:test_ReceiveETH_ShouldAcceptETH() (gas: 18098)
-TrailsRouterTest:test_RevertWhen_allowFailure_true_allCalls() (gas: 281762)
-TrailsRouterTest:test_RevertWhen_allowFailure_true_firstOfMultipleCalls() (gas: 280264)
-TrailsRouterTest:test_RevertWhen_allowFailure_true_lastOfMultipleCalls() (gas: 280915)
-TrailsRouterTest:test_RevertWhen_allowFailure_true_middleOfMultipleCalls() (gas: 280480)
-TrailsRouterTest:test_RevertWhen_allowFailure_true_singleCall() (gas: 168096)
-TrailsRouterTest:test_RevertWhen_execute_withETH_allowFailure_true() (gas: 94756)
-TrailsRouterTest:test_RevertWhen_pullAmountAndExecute_InsufficientAllowance() (gas: 99156)
-TrailsRouterTest:test_RevertWhen_pullAndExecute_InsufficientAllowance() (gas: 101836)
-TrailsRouterTest:test_RevertWhen_pullAndExecute_allowFailure_true() (gas: 169275)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_allCalls() (gas: 102266)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_firstOfMultipleCalls() (gas: 100768)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_lastOfMultipleCalls() (gas: 101419)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_middleOfMultipleCalls() (gas: 100984)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_singleCall() (gas: 97574)
+TrailsRouterTest:test_RevertWhen_execute_withETH_allowFailure_true() (gas: 24234)
+TrailsRouterTest:test_RevertWhen_pullAmountAndExecute_InsufficientAllowance() (gas: 28634)
+TrailsRouterTest:test_RevertWhen_pullAndExecute_InsufficientAllowance() (gas: 31314)
+TrailsRouterTest:test_RevertWhen_pullAndExecute_allowFailure_true() (gas: 98753)
 TrailsRouterTest:test_amount_offset_out_of_bounds() (gas: 278820)
 TrailsRouterTest:test_direct_sweep_reverts_not_delegatecall() (gas: 12139)
 TrailsRouterTest:test_handleSequenceDelegateCall_dispatches_to_sweep_native() (gas: 50425)
@@ -121,21 +121,21 @@ TrailsRouterTest:test_native_transfer_failed() (gas: 89620)
 TrailsRouterTest:test_no_tokens_to_pull() (gas: 650574)
 TrailsRouterTest:test_no_tokens_to_sweep() (gas: 909059)
 TrailsRouterTest:test_placeholder_mismatch() (gas: 279474)
-TrailsRouterTest:test_pullAmountAndExecute_WithETH_InsufficientEthSent() (gas: 97367)
-TrailsRouterTest:test_pullAmountAndExecute_WithETH_ShouldTransferAndExecute() (gas: 107947)
-TrailsRouterTest:test_pullAmountAndExecute_WithToken_ShouldTransferAndExecute() (gas: 144603)
-TrailsRouterTest:test_pullAmountAndExecute_WithValidToken_ShouldTransferAndExecute() (gas: 144251)
+TrailsRouterTest:test_pullAmountAndExecute_WithETH_InsufficientEthSent() (gas: 26845)
+TrailsRouterTest:test_pullAmountAndExecute_WithETH_ShouldTransferAndExecute() (gas: 37385)
+TrailsRouterTest:test_pullAmountAndExecute_WithToken_ShouldTransferAndExecute() (gas: 74041)
+TrailsRouterTest:test_pullAmountAndExecute_WithValidToken_ShouldTransferAndExecute() (gas: 73689)
 TrailsRouterTest:test_pullAndExecute_WithETH_NoEthSent() (gas: 18411)
-TrailsRouterTest:test_pullAndExecute_WithETH_ShouldTransferAndExecute() (gas: 108961)
-TrailsRouterTest:test_pullAndExecute_WithFailingMulticall() (gas: 564910)
-TrailsRouterTest:test_pullAndExecute_WithValidToken_ShouldTransferFullBalanceAndExecute() (gas: 141710)
+TrailsRouterTest:test_pullAndExecute_WithETH_ShouldTransferAndExecute() (gas: 38399)
+TrailsRouterTest:test_pullAndExecute_WithFailingMulticall() (gas: 494387)
+TrailsRouterTest:test_pullAndExecute_WithValidToken_ShouldTransferFullBalanceAndExecute() (gas: 72465)
 TrailsRouterTest:test_refundAndSweep_erc20_partialRefund() (gas: 110365)
 TrailsRouterTest:test_refundAndSweep_native_partialRefund() (gas: 92161)
 TrailsRouterTest:test_success_sentinel_not_set() (gas: 15750)
 TrailsRouterTest:test_sweep_erc20Token() (gas: 77703)
 TrailsRouterTest:test_sweep_nativeToken() (gas: 49961)
-TrailsRouterTest:test_validateOpHashAndSweep_native_success() (gas: 62220)
-TrailsRouterTest:test_validateOpHashAndSweep_native_success_tstore() (gas: 130499)
+TrailsRouterTest:test_validateOpHashAndSweep_native_success() (gas: 62092)
+TrailsRouterTest:test_validateOpHashAndSweep_native_success_tstore() (gas: 130257)
 TrailsSentinelLibTest:test_Constants_DoNotChange() (gas: 735)
 TrailsSentinelLibTest:test_SentinelNamespace_Computation() (gas: 328)
 TrailsSentinelLibTest:test_SentinelNamespace_Constant() (gas: 548)

src/TrailsRouter.sol

@@ -370,22 +370,19 @@ contract TrailsRouter is IDelegatedExtension, ITrailsRouter, DelegatecallGuard,
     }
 
     /// forge-lint: disable-next-line(mixed-case-function)
-    function _validateRouterCall(bytes memory callData) internal pure {
+    function _validateRouterCall(bytes calldata callData) internal pure {
         // Extract function selector
         if (callData.length < 4) revert InvalidFunctionSelector(bytes4(0));
 
-        bytes4 selector;
-        assembly {
-            selector := mload(add(callData, 32))
-        }
+        bytes4 selector = bytes4(callData[0:4]);
 
         // Only allow `aggregate3Value` calls (0x174dea71)
         if (selector != 0x174dea71) {
             revert InvalidFunctionSelector(selector);
         }
 
         // Decode and validate the Call3Value[] array to ensure allowFailure=false for all calls
-        IMulticall3.Call3Value[] memory calls = abi.decode(_sliceCallData(callData, 4), (IMulticall3.Call3Value[]));
+        IMulticall3.Call3Value[] memory calls = abi.decode(callData[4:], (IMulticall3.Call3Value[]));
 
         // Iterate through all calls and verify allowFailure is false
         for (uint256 i = 0; i < calls.length; i++) {
@@ -394,13 +391,4 @@ contract TrailsRouter is IDelegatedExtension, ITrailsRouter, DelegatecallGuard,
             }
         }
     }
-
-    /// forge-lint: disable-next-line(mixed-case-function)
-    function _sliceCallData(bytes memory data, uint256 start) internal pure returns (bytes memory) {
-        bytes memory result = new bytes(data.length - start);
-        for (uint256 i = 0; i < result.length; i++) {
-            result[i] = data[start + i];
-        }
-        return result;
-    }
 }