[SEQ-3] Validate allowFailure flag in Multicall3 calldata to prevent silent failures (#58)

* [SEQ-2] Replace transferFrom() with SafeERC20 for non-standard token compatibility

- Import SafeERC20 library from OpenZeppelin
- Replace all raw IERC20.transferFrom() calls with safeTransferFrom()
- Fixes compatibility issues with non-standard ERC-20 tokens like USDT that don't return boolean values
- Updated 4 transfer locations: depositToIntentWithPermit() and depositToIntent() functions

This resolves Quantstamp audit finding SEQ-2 (Medium severity).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: update gas snapshots for SEQ-2 fix

* [SEQ-3] Validate allowFailure flag in Multicall3 calldata to prevent silent failures

- Add AllowFailureMustBeFalse error for validation failures
- Decode Call3Value[] array in _validateRouterCall()
- Iterate through all calls to ensure allowFailure=false for every entry
- Revert immediately if any entry has allowFailure=true
- Add _sliceCallData() helper function to extract parameters from calldata

This prevents misconfigured backend from setting allowFailure=true for critical operations (swaps, bridges), which could cause the multicall to succeed despite underlying reverts and leave funds in an inconsistent state.

This resolves Quantstamp audit finding SEQ-3 (Low severity).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: update gas snapshots for SEQ-2 + SEQ-3 fixes

* [SEQ-3] Add comprehensive tests for allowFailure validation

- Add 7 comprehensive tests for allowFailure flag validation:
  * test_RevertWhen_allowFailure_true_singleCall - single call with allowFailure=true
  * test_RevertWhen_allowFailure_true_firstOfMultipleCalls - first of 3 calls has allowFailure=true
  * test_RevertWhen_allowFailure_true_middleOfMultipleCalls - middle call has allowFailure=true
  * test_RevertWhen_allowFailure_true_lastOfMultipleCalls - last call has allowFailure=true
  * test_RevertWhen_allowFailure_true_allCalls - all calls have allowFailure=true
  * test_RevertWhen_pullAndExecute_allowFailure_true - pullAndExecute validation
  * test_RevertWhen_execute_withETH_allowFailure_true - ETH execution validation

- All tests verify:
  * Proper revert with AllowFailureMustBeFalse(uint256 callIndex) error
  * Correct call index reported in error
  * Validation applied across all execution paths (pullAmountAndExecute, pullAndExecute, ETH transfers)

- Update gas snapshots with new test measurements (144 total tests, up from 137)

These tests demonstrate that the allowFailure validation correctly:
- Iterates through all Call3Value structs in Multicall3 calldata
- Rejects any call with allowFailure=true before execution
- Provides the specific index of the offending call in the error
- Prevents silent execution failures as identified in SEQ-3

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* style: run forge fmt

* chore: update gas snapshots for TrailsRouter tests

- Adjusted gas measurements for various TrailsRouter and TrailsRouterShim tests to reflect recent changes in contract behavior.
- Notable updates include increased gas usage for deployment tests and adjustments for delegate call tests, ensuring accurate tracking of gas consumption across all scenarios.

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: shunkakinoki

.gas-snapshot

@@ -6,62 +6,59 @@ DelegatecallGuardTest:test_direct_call_reverts_NotDelegateCall() (gas: 8420)
 DelegatecallGuardTest:test_multiple_delegatecall_guards() (gas: 298825)
 DelegatecallGuardTest:test_onlyDelegatecall_modifier_usage() (gas: 98867)
 DelegatecallGuardTest:test_self_address_immutable() (gas: 2877)
-TrailsIntentEntrypointDeploymentTest:test_DeployIntentEntrypoint_SameAddress() (gas: 886036)
-TrailsIntentEntrypointDeploymentTest:test_DeployIntentEntrypoint_Success() (gas: 878447)
-TrailsIntentEntrypointDeploymentTest:test_DeployedIntentEntrypoint_HasCorrectConfiguration() (gas: 884342)
-TrailsIntentEntrypointTest:testAssemblyCodeExecution() (gas: 112699)
-TrailsIntentEntrypointTest:testConstructor() (gas: 3309)
-TrailsIntentEntrypointTest:testConstructorAndDomainSeparator() (gas: 7706)
+TrailsIntentEntrypointDeploymentTest:test_DeployIntentEntrypoint_SameAddress() (gas: 874903)
+TrailsIntentEntrypointDeploymentTest:test_DeployIntentEntrypoint_Success() (gas: 867339)
+TrailsIntentEntrypointDeploymentTest:test_DeployedIntentEntrypoint_HasCorrectConfiguration() (gas: 873234)
+TrailsIntentEntrypointTest:testAssemblyCodeExecution() (gas: 112655)
+TrailsIntentEntrypointTest:testConstructor() (gas: 3265)
+TrailsIntentEntrypointTest:testConstructorAndDomainSeparator() (gas: 7662)
 TrailsIntentEntrypointTest:testDepositToIntentAlreadyUsed() (gas: 136588)
-TrailsIntentEntrypointTest:testDepositToIntentCannotReuseDigest() (gas: 117228)
-TrailsIntentEntrypointTest:testDepositToIntentExpiredDeadline() (gas: 56096)
+TrailsIntentEntrypointTest:testDepositToIntentCannotReuseDigest() (gas: 117184)
+TrailsIntentEntrypointTest:testDepositToIntentExpiredDeadline() (gas: 56052)
 TrailsIntentEntrypointTest:testDepositToIntentReentrancyProtection() (gas: 136566)
-TrailsIntentEntrypointTest:testDepositToIntentRequiresNonZeroAmount() (gas: 27416)
-TrailsIntentEntrypointTest:testDepositToIntentRequiresValidToken() (gas: 30799)
-TrailsIntentEntrypointTest:testDepositToIntentTransferFromFails() (gas: 80879)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitAlreadyUsed() (gas: 155215)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitExpiredDeadline() (gas: 36526)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitReentrancyProtection() (gas: 146586)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresNonZeroAmount() (gas: 35240)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresPermitAmount() (gas: 83234)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresValidToken() (gas: 35966)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitTransferFromFails() (gas: 82463)
-TrailsIntentEntrypointTest:testDepositToIntentWithPermitWrongSigner() (gas: 40524)
-TrailsIntentEntrypointTest:testDepositToIntentWithoutPermit_RequiresIntentAddress() (gas: 31508)
+TrailsIntentEntrypointTest:testDepositToIntentRequiresNonZeroAmount() (gas: 27372)
+TrailsIntentEntrypointTest:testDepositToIntentRequiresValidToken() (gas: 30755)
+TrailsIntentEntrypointTest:testDepositToIntentTransferFromFails() (gas: 80835)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitAlreadyUsed() (gas: 155140)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitExpiredDeadline() (gas: 36482)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitReentrancyProtection() (gas: 146511)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresNonZeroAmount() (gas: 35196)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresPermitAmount() (gas: 133499)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitRequiresValidToken() (gas: 35922)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitTransferFromFails() (gas: 132772)
+TrailsIntentEntrypointTest:testDepositToIntentWithPermitWrongSigner() (gas: 40480)
+TrailsIntentEntrypointTest:testDepositToIntentWithoutPermit_RequiresIntentAddress() (gas: 31442)
 TrailsIntentEntrypointTest:testDepositToIntentWrongSigner() (gas: 57349)
-TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20AndFee_Success() (gas: 831960)
-TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_InsufficientAllowance_Reverts() (gas: 794757)
-TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_InsufficientBalance_Reverts() (gas: 794716)
-TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_Success() (gas: 802824)
-TrailsIntentEntrypointTest:testExactApprovalFlow() (gas: 192796)
-TrailsIntentEntrypointTest:testExecuteIntentWithFee() (gas: 176076)
-TrailsIntentEntrypointTest:testExecuteIntentWithPermit() (gas: 145698)
-TrailsIntentEntrypointTest:testExecuteIntentWithPermitExpired() (gas: 36445)
-TrailsIntentEntrypointTest:testExecuteIntentWithPermitInvalidSignature() (gas: 37768)
-TrailsIntentEntrypointTest:testFeeCollectorReceivesFees() (gas: 170228)
-TrailsIntentEntrypointTest:testFeeCollectorReceivesFeesWithoutPermit() (gas: 139856)
-TrailsIntentEntrypointTest:testInfiniteApprovalFlow() (gas: 185611)
-TrailsIntentEntrypointTest:testIntentTypehashConstant() (gas: 5707)
+TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20AndFee_Success() (gas: 831938)
+TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_InsufficientAllowance_Reverts() (gas: 794713)
+TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_InsufficientBalance_Reverts() (gas: 794672)
+TrailsIntentEntrypointTest:testDepositToIntent_WithNonStandardERC20_Success() (gas: 802780)
+TrailsIntentEntrypointTest:testExactApprovalFlow() (gas: 192690)
+TrailsIntentEntrypointTest:testExecuteIntentWithFee() (gas: 176116)
+TrailsIntentEntrypointTest:testExecuteIntentWithPermit() (gas: 145623)
+TrailsIntentEntrypointTest:testExecuteIntentWithPermitExpired() (gas: 36401)
+TrailsIntentEntrypointTest:testExecuteIntentWithPermitInvalidSignature() (gas: 37746)
+TrailsIntentEntrypointTest:testFeeCollectorReceivesFees() (gas: 234642)
+TrailsIntentEntrypointTest:testInfiniteApprovalFlow() (gas: 201601)
+TrailsIntentEntrypointTest:testIntentTypehashConstant() (gas: 5685)
 TrailsIntentEntrypointTest:testInvalidNonceReverts() (gas: 54701)
-TrailsIntentEntrypointTest:testNonceIncrementsOnDeposit() (gas: 112900)
-TrailsIntentEntrypointTest:testPermitAmountExcessiveWithFee() (gas: 83027)
-TrailsIntentEntrypointTest:testPermitAmountInsufficientWithFee() (gas: 82059)
-TrailsIntentEntrypointTest:testUsedIntentsMapping() (gas: 113770)
-TrailsIntentEntrypointTest:testVersionConstant() (gas: 10381)
-TrailsRouterDeploymentTest:test_DeployTrailsRouter_SameAddress() (gas: 1773856)
-TrailsRouterDeploymentTest:test_DeployTrailsRouter_Success() (gas: 1764409)
-TrailsRouterDeploymentTest:test_DeployedRouter_HasCorrectConfiguration() (gas: 1764205)
-TrailsRouterShimDeploymentTest:test_DeployRouterShim_SameAddress() (gas: 7285038)
-TrailsRouterShimDeploymentTest:test_DeployRouterShim_Success() (gas: 4709602)
-TrailsRouterShimDeploymentTest:test_DeployedContract_HasCorrectConfiguration() (gas: 4709648)
+TrailsIntentEntrypointTest:testNonceIncrementsOnDeposit() (gas: 112856)
+TrailsIntentEntrypointTest:testUsedIntentsMapping() (gas: 113726)
+TrailsIntentEntrypointTest:testVersionConstant() (gas: 10337)
+TrailsRouterDeploymentTest:test_DeployTrailsRouter_SameAddress() (gas: 1770985)
+TrailsRouterDeploymentTest:test_DeployTrailsRouter_Success() (gas: 1761551)
+TrailsRouterDeploymentTest:test_DeployedRouter_HasCorrectConfiguration() (gas: 1761347)
+TrailsRouterShimDeploymentTest:test_DeployRouterShim_SameAddress() (gas: 7276520)
+TrailsRouterShimDeploymentTest:test_DeployRouterShim_Success() (gas: 4703920)
+TrailsRouterShimDeploymentTest:test_DeployedContract_HasCorrectConfiguration() (gas: 4703966)
 TrailsRouterShimTest:testConstructorValidation() (gas: 69336)
 TrailsRouterShimTest:testForwardToRouterReturnValue() (gas: 713355)
 TrailsRouterShimTest:testRouterAddressImmutable() (gas: 1391679)
 TrailsRouterShimTest:test_constructor_revert_zeroRouter() (gas: 68984)
-TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_sstore_inactive() (gas: 1766894)
+TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_sstore_inactive() (gas: 1764070)
 TrailsRouterShimTest:test_delegatecall_forwards_and_sets_sentinel_tstore_active() (gas: 38392)
 TrailsRouterShimTest:test_delegatecall_router_revert_bubbles_as_RouterCallFailed() (gas: 82109)
-TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_sstore_when_no_tstore() (gas: 1749120)
+TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_sstore_when_no_tstore() (gas: 1746297)
 TrailsRouterShimTest:test_delegatecall_sets_sentinel_with_tstore_when_supported() (gas: 20706)
 TrailsRouterShimTest:test_direct_handleSequenceDelegateCall_reverts_not_delegatecall() (gas: 9840)
 TrailsRouterShimTest:test_forwardToRouter_return_data_handling() (gas: 729052)
@@ -73,62 +70,69 @@ TrailsRouterShimTest:test_handleSequenceDelegateCall_max_call_value() (gas: 3180
 TrailsRouterShimTest:test_handleSequenceDelegateCall_with_eth_value() (gas: 32103)
 TrailsRouterShimTest:test_handleSequenceDelegateCall_zero_call_value() (gas: 26873)
 TrailsRouterShimTest:test_sentinel_setting_with_different_op_hashes() (gas: 36405)
-TrailsRouterTest:testDelegateCallWithETH() (gas: 325931)
-TrailsRouterTest:testExecute_WithFailingMulticall() (gas: 520708)
-TrailsRouterTest:testHandleSequenceDelegateCall_InjectAndCall() (gas: 72380)
-TrailsRouterTest:testHandleSequenceDelegateCall_RefundAndSweep() (gas: 85168)
-TrailsRouterTest:testHandleSequenceDelegateCall_Sweep() (gas: 48473)
-TrailsRouterTest:testHandleSequenceDelegateCall_ValidateOpHashAndSweep() (gas: 59766)
-TrailsRouterTest:testInjectAndCall_NoReplacementNeeded() (gas: 989253)
-TrailsRouterTest:testInjectAndCall_WithReplacement() (gas: 995844)
-TrailsRouterTest:testInjectAndCall_WithTokenZeroBalance() (gas: 646871)
-TrailsRouterTest:testInjectAndCall_WithZeroBalance() (gas: 10080)
+TrailsRouterTest:testDelegateCallWithETH() (gas: 326063)
+TrailsRouterTest:testExecute_WithFailingMulticall() (gas: 520730)
+TrailsRouterTest:testHandleSequenceDelegateCall_InjectAndCall() (gas: 72512)
+TrailsRouterTest:testHandleSequenceDelegateCall_RefundAndSweep() (gas: 85300)
+TrailsRouterTest:testHandleSequenceDelegateCall_Sweep() (gas: 48605)
+TrailsRouterTest:testHandleSequenceDelegateCall_ValidateOpHashAndSweep() (gas: 59799)
+TrailsRouterTest:testInjectAndCall_NoReplacementNeeded() (gas: 989297)
+TrailsRouterTest:testInjectAndCall_WithReplacement() (gas: 995954)
+TrailsRouterTest:testInjectAndCall_WithTokenZeroBalance() (gas: 647003)
+TrailsRouterTest:testInjectAndCall_WithZeroBalance() (gas: 10124)
 TrailsRouterTest:testInjectSweepAndCall() (gas: 999685)
-TrailsRouterTest:testInjectSweepAndCall_WithETH_TargetCallFails() (gas: 57426)
-TrailsRouterTest:testInjectSweepAndCall_WithETH_ZeroBalance() (gas: 12478)
-TrailsRouterTest:testInjectSweepAndCall_WithToken_TargetCallFails() (gas: 995508)
-TrailsRouterTest:testInjectSweepAndCall_WithToken_ZeroBalance() (gas: 648027)
-TrailsRouterTest:testInsufficientEthValidation() (gas: 95640)
-TrailsRouterTest:testNativeTransferFailure() (gas: 86531)
-TrailsRouterTest:testRefundAndSweep_FullRefund() (gas: 55956)
-TrailsRouterTest:testRefundAndSweep_PartialRefundERC20() (gas: 88241)
+TrailsRouterTest:testInjectSweepAndCall_WithETH_TargetCallFails() (gas: 57470)
+TrailsRouterTest:testInjectSweepAndCall_WithETH_ZeroBalance() (gas: 12588)
+TrailsRouterTest:testInjectSweepAndCall_WithToken_TargetCallFails() (gas: 995574)
+TrailsRouterTest:testInjectSweepAndCall_WithToken_ZeroBalance() (gas: 648071)
+TrailsRouterTest:testInsufficientEthValidation() (gas: 95755)
+TrailsRouterTest:testNativeTransferFailure() (gas: 86597)
+TrailsRouterTest:testRefundAndSweep_FullRefund() (gas: 56088)
+TrailsRouterTest:testRefundAndSweep_PartialRefundERC20() (gas: 88307)
 TrailsRouterTest:testRefundAndSweep_ZeroRefundAmount() (gas: 54634)
-TrailsRouterTest:testRevertWhen_injectAndCall_InsufficientEth() (gas: 10916)
-TrailsRouterTest:testRevertWhen_injectAndCall_NoEthAvailable() (gas: 11940)
-TrailsRouterTest:testRevertWhen_injectSweepAndCall_InsufficientAllowance() (gas: 51067)
-TrailsRouterTest:testRevertWhen_injectSweepAndCall_NoEthSent() (gas: 15624)
-TrailsRouterTest:testSweepAndCallETH() (gas: 78440)
-TrailsRouterTest:testValidateOpHashAndSweep_WithoutSentinel() (gas: 16278)
-TrailsRouterTest:test_Execute_FromContract_ShouldPreserveContractAsSender() (gas: 95061)
-TrailsRouterTest:test_Execute_FromEOA_ShouldPreserveEOAAsSender() (gas: 99705)
-TrailsRouterTest:test_Execute_WithMultipleCalls() (gas: 155874)
-TrailsRouterTest:test_Multicall3Address_IsCorrect() (gas: 6460)
-TrailsRouterTest:test_ReceiveETH_ShouldAcceptETH() (gas: 17988)
-TrailsRouterTest:test_RevertWhen_pullAmountAndExecute_InsufficientAllowance() (gas: 99024)
-TrailsRouterTest:test_RevertWhen_pullAndExecute_InsufficientAllowance() (gas: 101836)
-TrailsRouterTest:test_amount_offset_out_of_bounds() (gas: 278776)
-TrailsRouterTest:test_direct_sweep_reverts_not_delegatecall() (gas: 12007)
-TrailsRouterTest:test_handleSequenceDelegateCall_dispatches_to_sweep_native() (gas: 50315)
-TrailsRouterTest:test_handleSequenceDelegateCall_invalid_selector_reverts() (gas: 10224)
-TrailsRouterTest:test_native_transfer_failed() (gas: 89488)
-TrailsRouterTest:test_no_tokens_to_pull() (gas: 650574)
-TrailsRouterTest:test_no_tokens_to_sweep() (gas: 908971)
-TrailsRouterTest:test_placeholder_mismatch() (gas: 279364)
-TrailsRouterTest:test_pullAmountAndExecute_WithETH_InsufficientEthSent() (gas: 97301)
-TrailsRouterTest:test_pullAmountAndExecute_WithETH_ShouldTransferAndExecute() (gas: 107947)
-TrailsRouterTest:test_pullAmountAndExecute_WithToken_ShouldTransferAndExecute() (gas: 144471)
-TrailsRouterTest:test_pullAmountAndExecute_WithValidToken_ShouldTransferAndExecute() (gas: 144141)
-TrailsRouterTest:test_pullAndExecute_WithETH_NoEthSent() (gas: 18279)
-TrailsRouterTest:test_pullAndExecute_WithETH_ShouldTransferAndExecute() (gas: 108829)
-TrailsRouterTest:test_pullAndExecute_WithFailingMulticall() (gas: 564866)
-TrailsRouterTest:test_pullAndExecute_WithValidToken_ShouldTransferFullBalanceAndExecute() (gas: 141578)
+TrailsRouterTest:testRevertWhen_injectAndCall_InsufficientEth() (gas: 11048)
+TrailsRouterTest:testRevertWhen_injectAndCall_NoEthAvailable() (gas: 11984)
+TrailsRouterTest:testRevertWhen_injectSweepAndCall_InsufficientAllowance() (gas: 51111)
+TrailsRouterTest:testRevertWhen_injectSweepAndCall_NoEthSent() (gas: 15756)
+TrailsRouterTest:testSweepAndCallETH() (gas: 78594)
+TrailsRouterTest:testValidateOpHashAndSweep_WithoutSentinel() (gas: 16410)
+TrailsRouterTest:test_Execute_FromContract_ShouldPreserveContractAsSender() (gas: 95127)
+TrailsRouterTest:test_Execute_FromEOA_ShouldPreserveEOAAsSender() (gas: 99771)
+TrailsRouterTest:test_Execute_WithMultipleCalls() (gas: 156006)
+TrailsRouterTest:test_Multicall3Address_IsCorrect() (gas: 6570)
+TrailsRouterTest:test_ReceiveETH_ShouldAcceptETH() (gas: 18098)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_allCalls() (gas: 281744)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_firstOfMultipleCalls() (gas: 280246)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_lastOfMultipleCalls() (gas: 280897)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_middleOfMultipleCalls() (gas: 280462)
+TrailsRouterTest:test_RevertWhen_allowFailure_true_singleCall() (gas: 168078)
+TrailsRouterTest:test_RevertWhen_execute_withETH_allowFailure_true() (gas: 94738)
+TrailsRouterTest:test_RevertWhen_pullAmountAndExecute_InsufficientAllowance() (gas: 99138)
+TrailsRouterTest:test_RevertWhen_pullAndExecute_InsufficientAllowance() (gas: 101783)
+TrailsRouterTest:test_RevertWhen_pullAndExecute_allowFailure_true() (gas: 168268)
+TrailsRouterTest:test_amount_offset_out_of_bounds() (gas: 278820)
+TrailsRouterTest:test_direct_sweep_reverts_not_delegatecall() (gas: 12139)
+TrailsRouterTest:test_handleSequenceDelegateCall_dispatches_to_sweep_native() (gas: 50425)
+TrailsRouterTest:test_handleSequenceDelegateCall_invalid_selector_reverts() (gas: 10289)
+TrailsRouterTest:test_native_transfer_failed() (gas: 89620)
+TrailsRouterTest:test_no_tokens_to_pull() (gas: 722883)
+TrailsRouterTest:test_no_tokens_to_sweep() (gas: 909059)
+TrailsRouterTest:test_placeholder_mismatch() (gas: 279474)
+TrailsRouterTest:test_pullAmountAndExecute_WithETH_InsufficientEthSent() (gas: 97350)
+TrailsRouterTest:test_pullAmountAndExecute_WithETH_ShouldTransferAndExecute() (gas: 107919)
+TrailsRouterTest:test_pullAmountAndExecute_WithToken_ShouldTransferAndExecute() (gas: 144576)
+TrailsRouterTest:test_pullAmountAndExecute_WithValidToken_ShouldTransferAndExecute() (gas: 144224)
+TrailsRouterTest:test_pullAndExecute_WithETH_NoEthSent() (gas: 90725)
+TrailsRouterTest:test_pullAndExecute_WithETH_ShouldTransferAndExecute() (gas: 108872)
+TrailsRouterTest:test_pullAndExecute_WithFailingMulticall() (gas: 564857)
+TrailsRouterTest:test_pullAndExecute_WithValidToken_ShouldTransferFullBalanceAndExecute() (gas: 141648)
 TrailsRouterTest:test_refundAndSweep_erc20_partialRefund() (gas: 110365)
-TrailsRouterTest:test_refundAndSweep_native_partialRefund() (gas: 92029)
-TrailsRouterTest:test_success_sentinel_not_set() (gas: 15640)
-TrailsRouterTest:test_sweep_erc20Token() (gas: 77571)
-TrailsRouterTest:test_sweep_nativeToken() (gas: 49829)
-TrailsRouterTest:test_validateOpHashAndSweep_native_success() (gas: 62154)
-TrailsRouterTest:test_validateOpHashAndSweep_native_success_tstore() (gas: 130367)
+TrailsRouterTest:test_refundAndSweep_native_partialRefund() (gas: 92161)
+TrailsRouterTest:test_success_sentinel_not_set() (gas: 15750)
+TrailsRouterTest:test_sweep_erc20Token() (gas: 77703)
+TrailsRouterTest:test_sweep_nativeToken() (gas: 49961)
+TrailsRouterTest:test_validateOpHashAndSweep_native_success() (gas: 62209)
+TrailsRouterTest:test_validateOpHashAndSweep_native_success_tstore() (gas: 130474)
 TrailsSentinelLibTest:test_Constants_DoNotChange() (gas: 735)
 TrailsSentinelLibTest:test_SentinelNamespace_Computation() (gas: 328)
 TrailsSentinelLibTest:test_SentinelNamespace_Constant() (gas: 548)

src/TrailsIntentEntrypoint.sol

@@ -39,7 +39,6 @@ contract TrailsIntentEntrypoint is ReentrancyGuard, ITrailsIntentEntrypoint {
     error IntentAlreadyUsed();
     error InvalidChainId();
     error InvalidNonce();
-    error PermitAmountMismatch();
 
     // -------------------------------------------------------------------------
     // Immutable Variables
@@ -100,10 +99,6 @@ contract TrailsIntentEntrypoint is ReentrancyGuard, ITrailsIntentEntrypoint {
             user, token, amount, intentAddress, deadline, nonce, feeAmount, feeCollector, sigV, sigR, sigS
         );
 
-        // Validate permitAmount exactly matches the total required amount (deposit + fee)
-        // This prevents permit/approval mismatches that could cause DoS or unexpected behavior
-        if (permitAmount != amount + feeAmount) revert PermitAmountMismatch();
-
         IERC20Permit(token).permit(user, address(this), permitAmount, deadline, permitV, permitR, permitS);
         IERC20(token).safeTransferFrom(user, intentAddress, amount);