Fix: You also need to pass the length of the name, the other method only works if the string in the variable length array is zero-terminated which can not be guaranteed.

Author: aentinger

src/util/registry/Registry.hpp

@@ -81,7 +81,7 @@ class Registry final : public registry::Registry
 
   TAccessResponse onAccess_1_0_Request_Received(TAccessRequest const &req)
   {
-    auto const req_name = std::string_view(reinterpret_cast<const char *>(req.name.name.cbegin()));
+    auto const req_name = std::string_view(reinterpret_cast<const char *>(req.name.name.cbegin()), req.name.name.size());
 
     /* Try to set the registers value. Note, if this is a RO register
      * this call will fail with SetError::Mutability.

src/util/storage/register_storage.hpp

@@ -30,7 +30,7 @@ namespace cyphal::support
     {
         // Find the next register in the registry.
         const auto reg_name_storage = rgy.index(index);  // This is a little suboptimal but we don't care.
-        const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()));
+        const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()), reg_name_storage.name.size());
         if (reg_name.empty())
         {
             break;  // No more registers to load.
@@ -89,7 +89,7 @@ template <typename ResetPredicate>
     for (std::size_t index = 0; index < rgy.size(); index++)
     {
         const auto reg_name_storage = rgy.index(index);  // This is a little suboptimal but we don't care.
-        const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()));
+        const auto reg_name = std::string_view(reinterpret_cast<const char *>(reg_name_storage.name.cbegin()), reg_name_storage.name.size());
         if (reg_name.empty())
         {
             break;  // No more registers to load.