Skip to content

[Question] Consistency and understanding of when dt_push_post should happen #1044

@aaronware

Description

@aaronware

Describe your question

I have been requesting various hooks and in doing so I started to think about if it was a matter of different hooks being utilized more consistently.

For example, from what I can tell on external connections dt_push_post only gets called on the first external push of a post but after doing a quick draft pull request #1043 I was wondering if instead of creating a new hook. Maybe infavor of more consistency do_action( 'dt_push_post'... should be utilized there as well?

I'm just not entirely understanding why ExternalConnection->push() isn't used when an already subscribed post is pushed when rest_insert_ is called. It seems to instead utilize send_notifications within includes/subscriptions.php

This is somewhat tied to the work that is being done in #712, #1018, #123

If we summarize a discussion here, I can gladly help w/ some documentation as well

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:questionFurther information is requested.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions