Add support for space or lowercase t for date time delimiter (RFC 9557 valid)

Author: zachleat

parse.js

@@ -6,7 +6,7 @@ export class IsoDateParts {
 	};
 
 	static FULL_DATE_REGEX = /^([+-]\d{6}|\d{4})-?([01]\d)-?([0-3]\d)$/;
-	static DATETIME_REGEX = /^([+-]\d{6}|\d{4})-?([01]\d)-?([0-3]\d)T([0-2]\d(?:[\.\,]\d+)?)(?::?([0-5]\d(?:[\.\,]\d+)?)(?::?([0-5]\d))?(?:[\.\,](\d+))?)?(Z|[+-][0-2]\d(?::?[0-5]\d)?)?$/;
+	static DATETIME_REGEX = /^([+-]\d{6}|\d{4})-?([01]\d)-?([0-3]\d)[Tt ]([0-2]\d(?:[\.\,]\d+)?)(?::?([0-5]\d(?:[\.\,]\d+)?)(?::?([0-5]\d))?(?:[\.\,](\d+))?)?(Z|[+-][0-2]\d(?::?[0-5]\d)?)?$/;
 	static TIMEZONE_REGEX = /^([+-]\d{2})(?::?(\d{2}))?$/;
 	static IS_FRACTIONAL_REGEX = /^\d+[\.\,]\d+$/;
 

parse.test.js

@@ -4,7 +4,7 @@ import { IsoDate, parse } from "./parse.js";
 import { parse as temporalParse } from "./test/temporal.js";
 
 // This test suite compares with Luxon output for maximum backwards compatibility
-import { shouldSkip, VALID_TEST_CASES, INVALID_TEST_CASES, SUPPLIED_TEST_CASES } from './test/utils.js';
+import { shouldSkip, VALID_TEST_CASES, VALID_BUT_INVALID_IN_LUXON_TEST_CASES, INVALID_TEST_CASES, SUPPLIED_TEST_CASES } from './test/utils.js';
 
 // Some test cases from https://moment.github.io/luxon/#/parsing?id=ad-hoc-parsing
 // ISO8601 date parsing https://github.com/11ty/eleventy/issues/3587
@@ -17,10 +17,26 @@ for(let line of VALID_TEST_CASES.split("\n")) {
     // assert.equal(received, expected)
 
     // Compare to luxon
-    assert.equal(parse(line).toUTCString(), DateTime.fromISO(line, {zone: "utc"}).toJSDate().toUTCString());
+    assert.equal(parse(line).toUTCString(), DateTime.fromISO(line, {zone: "utc"}).toJSDate().toUTCString(), `Invalid compared to luxon for '${line}'`);
 
     // Compare to Temporal
-    assert.equal(parse(line).toUTCString(), temporalParse(line).toString());
+    assert.equal(parse(line).toUTCString(), temporalParse(line).toString(), `Invalid compared to Temporal for '${line}'`);
+  });
+}
+
+for(let line of VALID_BUT_INVALID_IN_LUXON_TEST_CASES.split("\n")) {
+  if(shouldSkip(line)) {
+    continue;
+  }
+
+  test(`Parse ${line}`, () => {
+    // assert.equal(received, expected)
+
+    // Should not equal luxon
+    assert.notEqual(parse(line).toUTCString(), DateTime.fromISO(line, {zone: "utc"}).toJSDate().toUTCString(), `Should not match luxon for '${line}'`);
+
+    // Compare to Temporal
+    assert.equal(parse(line).toUTCString(), temporalParse(line).toString(), `Invalid compared to Temporal for '${line}'`);
   });
 }
 

test/utils.js

@@ -81,6 +81,14 @@ export const VALID_TEST_CASES = `
 -002000-01-01
 +0020000101
 -0020000101
+
+// case insensitive delimiter (RFC 9557-valid)
+2016-05-25t12:00:00
+`;
+
+export const VALID_BUT_INVALID_IN_LUXON_TEST_CASES = `
+// space  delimiter (RFC 9557-valid)
+2016-05-25 12:00:00
 `
 
 // Expected to fail
@@ -96,13 +104,9 @@ export const INVALID_TEST_CASES = `
 // Support removed (missing delimiters)
 201605
 202618
+2016-05-2501
 2016-05-25T01:
 
-// Bad date/time delimiter
-// These are supported by RFC 9337
-2016-05-25 12:00:00
-2016-05-25t12:00:00
-
 // Bad syntax, number of time digits
 2016-05-25T1:11
 2016-05-25T1:1:1