Merge pull request #12 from 123inkt/add_ppd_name_option_to_create_printer

Add the option to add a ppd-name to create printer operation

Author: RubenKluft

src/Entity/IppPrinter.php

@@ -10,6 +10,7 @@ class IppPrinter
     private string $deviceUri;
     private string $location;
     private ?string $trayName = null;
+    private ?string $ppdName = null;
 
     public function getHostname(): string
     {
@@ -58,4 +59,16 @@ public function setTrayName(?string $trayName): self
 
         return $this;
     }
+
+    public function getPpdName(): ?string
+    {
+        return $this->ppdName;
+    }
+
+    public function setPpdName(?string $ppdName): self
+    {
+        $this->ppdName = $ppdName;
+
+        return $this;
+    }
 }

src/Operations/Cups/CupsCreatePrinter.php

@@ -44,6 +44,9 @@ public function create(IppPrinter $printer): IppResponseInterface
         $operation->addPrinterAttribute(new IppAttribute(IppTypeEnum::Bool, 'printer-is-accepting-jobs', true));
         $operation->addPrinterAttribute(new IppAttribute(IppTypeEnum::Uri, 'device-uri', $printer->getDeviceUri()));
         $operation->addPrinterAttribute(new IppAttribute(IppTypeEnum::TextWithoutLang, 'printer-location', $printer->getLocation()));
+        if ($printer->getPpdName() !== null) {
+            $operation->addPrinterAttribute(new IppAttribute(IppTypeEnum::NameWithoutLang, 'ppd-name', $printer->getPpdName()));
+        }
 
         return $this->client->sendRequest($operation);
     }

tests/Unit/Operations/Cups/CupsCreatePrinterTest.php

@@ -22,7 +22,7 @@ class CupsCreatePrinterTest extends TestCase
     /**
      * @throws Throwable
      */
-    public function testPrint(): void
+    public function testCreate(): void
     {
         $cups   = 'https://cups';
         $server = new IppServer();
@@ -41,7 +41,7 @@ public function testPrint(): void
         $client->expects($this->once())->method('sendRequest')->with(static::callback(static function (IppOperation $operation) {
             static::assertSame(IppOperationEnum::CupsAddModifyPrinter, $operation->getOperation());
             static::assertCount(0, $operation->getJobAttributes(), 'Job attribute count incorrect');
-            static::assertCount(4, $operation->getPrinterAttributes(), 'Printer attribute count incorrect');
+            static::assertCount(5, $operation->getPrinterAttributes(), 'Printer attribute count incorrect');
             static::assertCount(4, $operation->getOperationAttributes(), 'Operation attribute count incorrect');
 
             return true;
@@ -51,6 +51,7 @@ public function testPrint(): void
         $printer->setHostname('test');
         $printer->setDeviceUri('socket://10.10.10.10:9100');
         $printer->setLocation('location');
+        $printer->setPpdName('file.ppd');
 
         $printerCreator->create($printer);
     }