Skip to content

Commit 5383086

Browse files
committed
TST: add test cases for viscm flavors
1 parent 617162a commit 5383086

File tree

2 files changed

+30
-6
lines changed

2 files changed

+30
-6
lines changed

.github/workflows/test.yml

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
jobs:
1818
build:
19-
name: ${{ matrix.os }}, Python ${{ matrix.python-version }}
19+
name: ${{ matrix.os }}, Python ${{ matrix.python-version }} ${{ matrix.viscm-flavor }}
2020
runs-on: ${{ matrix.os }}
2121
strategy:
2222
fail-fast: false
@@ -29,7 +29,7 @@ jobs:
2929
- '3.11'
3030
- '3.12'
3131
- '3.13'
32-
test-args: [viscm>=0.10]
32+
viscm-flavor: ['']
3333
venv-loc: [bin]
3434

3535
include:
@@ -50,8 +50,29 @@ jobs:
5050
python-version: '3.13'
5151
venv-loc: Scripts
5252

53+
# check with viscm + Python 3.12
54+
# note that 3.13 is not usable at the time of writing because
55+
# viscm 0.10.0 pin numpy<2, and numpy 1.x doesn't support Python 3.13
56+
# see https://github.com/matplotlib/viscm/pull/82
57+
- os: ubuntu-latest
58+
python-version: '3.12'
59+
venv-loc: bin
60+
viscm-flavor: Pyside
61+
- os: ubuntu-latest
62+
python-version: '3.12'
63+
venv-loc: bin
64+
viscm-flavor: PyQt
65+
- os: macos-latest
66+
python-version: '3.12'
67+
venv-loc: bin
68+
viscm-flavor: PyQt
69+
- os: windows-latest
70+
python-version: '3.12'
71+
venv-loc: Scripts
72+
viscm-flavor: PyQt
73+
5374
concurrency:
54-
group: ${{ github.ref }}-${{ matrix.os }}-${{ matrix.python-version }}-build
75+
group: ${{ github.ref }}-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.viscm-flavor }}-build
5576
cancel-in-progress: true
5677

5778
steps:
@@ -65,7 +86,11 @@ jobs:
6586
run: |
6687
uv venv --python ${{ matrix.python-version }}
6788
uv pip install . ${{ matrix.install-args }}
68-
uv pip install -r requirements/dev.txt ${{ matrix.test-args }}
89+
uv pip install -r requirements/dev.txt
90+
91+
- name: Inject viscm
92+
if: matrix.viscm-flavor != ''
93+
run: uv pip install "viscm[ ${{ matrix.viscm-flavor }} ]"
6994

7095
- run: uv pip list
7196

@@ -88,7 +113,7 @@ jobs:
88113
if: startsWith( matrix.os , 'ubuntu' )
89114
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
90115
with:
91-
name: cmasher_coverage_data-${{ matrix.os }}-${{ matrix.python-version }}
116+
name: cmasher_coverage_data-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.viscm-flavor }}
92117
path: .coverage.*
93118
if-no-files-found: ignore
94119
include-hidden-files: true

requirements/dev.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
coverage[toml]>=7.6.4
2-
pyqt5>=5.15.6
32
pytest>=4.6.0
43
pytest-mpl>=0.13.0

0 commit comments

Comments
 (0)