test(user): добавил проверку ассертов на короткий пароль

Author: 15webprokofiev

backend/src-dev/Tests/Functional/User/Site/ChangePasswordTest.php

@@ -224,5 +224,13 @@ public static function notValidPasswordDataProvider(): Iterator
                 'newPasswordConfirmation' => 'currentPassword',
             ],
         ];
+
+        yield 'Новый пароль короткий' => [
+            [
+                'currentPassword' => 'currentPassword',
+                'newPassword' => '1',
+                'newPasswordConfirmation' => '1',
+            ],
+        ];
     }
 }

backend/src-dev/Tests/Functional/User/Site/RecoverPasswordTest.php

@@ -104,7 +104,7 @@ public function testUserNotFound(): void
         self::assertNotFound($response);
     }
 
-    #[DataProvider('notValidPasswordDataProvider')]
+    #[DataProvider('notValidEmailDataProvider')]
     #[TestDox('Неверный запрос')]
     public function testBadRequest(?string $email): void
     {
@@ -118,12 +118,60 @@ public function testBadRequest(?string $email): void
         self::assertBadRequest($response);
     }
 
-    public static function notValidPasswordDataProvider(): Iterator
+    public static function notValidEmailDataProvider(): Iterator
     {
         yield 'null' => [null];
 
         yield 'Пустая строка' => [''];
 
         yield 'Неверный Email' => ['testEmail'];
     }
+
+    #[DataProvider('notValidPasswordDataProvider')]
+    #[TestDox('Неверный запрос')]
+    public function testConfirmBadRequest(?string $password): void
+    {
+        $body = [
+            'email' => $userEmail = 'first@example.com',
+            'password' => '123QWE',
+        ];
+
+        $response = self::request(
+            method: Request::METHOD_POST,
+            uri: '/api/sign-up',
+            body: json_encode($body, JSON_THROW_ON_ERROR),
+        );
+        self::assertSuccessResponse($response);
+
+        $response = self::request(
+            method: Request::METHOD_POST,
+            uri: '/api/request-password-recovery',
+            body: json_encode(['email' => $userEmail], JSON_THROW_ON_ERROR),
+        );
+        self::assertSuccessResponse($response);
+
+        /** @var Message $sentEmail */
+        $sentEmail = self::getMailerMessage();
+
+        /** @var string $recoverToken */
+        $recoverToken = $sentEmail->getHeaders()->get('recoverToken')?->getBody();
+
+        $response = self::request(
+            method: Request::METHOD_POST,
+            uri: \sprintf('/api/recover-password/%s', $recoverToken),
+            body: json_encode(['password' => $password], JSON_THROW_ON_ERROR),
+            validateRequestSchema: false,
+        );
+
+        self::assertBadRequest($response);
+    }
+
+    public static function notValidPasswordDataProvider(): Iterator
+    {
+        yield 'null' => [null];
+
+        yield 'Пустой пароль' => [''];
+
+        yield 'Короткий пароль' => ['1'];
+    }
 }

backend/src-dev/Tests/Functional/User/Site/SignUpTest.php

@@ -68,6 +68,7 @@ public function testCreationUserWithSameEmail(): void
     #[TestWith(['', 'password'], 'пустой емейл')]
     #[TestWith(['test', 'password'], 'невалидный емейл')]
     #[TestWith(['test@example.test', ''], 'пустой пароль')]
+    #[TestWith(['test@example.test', '1'], 'короткий пароль')]
     #[TestDox('Неправильный запрос')]
     public function testBadRequest(string $email, string $password): void
     {

backend/src/Infrastructure/Response/SerializeExceptionResponse.php

@@ -4,6 +4,7 @@
 
 namespace App\Infrastructure\Response;
 
+use App\Infrastructure\ApiException\ApiBadRequestException;
 use App\Infrastructure\ApiException\ApiErrorResponse;
 use App\Infrastructure\ApiException\ApiException;
 use App\Infrastructure\ApiException\ApiHeaders;
@@ -16,6 +17,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
+use Webmozart\Assert\InvalidArgumentException;
 
 /**
  * Формирование ответа при ошибках
@@ -36,6 +38,16 @@ public function __invoke(ExceptionEvent $event): void
     {
         $exception = $event->getThrowable();
 
+        if ($exception instanceof InvalidArgumentException) {
+            /** @var non-empty-string $message */
+            $message = $exception->getMessage();
+
+            $exception = new ApiBadRequestException(
+                errors: [$message],
+                previous: $exception,
+            );
+        }
+
         if ($exception instanceof HttpExceptionInterface) {
             $exception = new ApiSystemException(
                 errors: [\sprintf('Http ошибка: %s', $exception->getMessage())],