Skip to content

Commit 05e18bb

Browse files
first pass to update semantics for v2 routing
1 parent 9b3d8a6 commit 05e18bb

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/app.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,6 @@ app.get('/', (req, res) => {
7575
});
7676
});
7777

78-
// we need to support legacy route
79-
// app.get('/v1.1/domain/:domain/reports/:reportName/data', checkDomainFilter);
80-
// app.get('/v1.1/agencies/:reportAgency/reports/:reportName/data', fetchData);
81-
// app.get('/v1.1/reports/:reportName/data', fetchData);
82-
83-
// We need a way to set versions without breaking the request
84-
// Right now if we update '/v1/reports/:reportName/data' to '/v2/reports/:reportName/data' anyone requesting from '/v1/reports/:reportName/data' will have a broken application
85-
8678
// middleware
8779
router.use('/v:version/', function(req, res, next) {
8880
console.log('req', req.params.version)
@@ -94,19 +86,19 @@ router.use('/v:version/', function(req, res, next) {
9486
router.get('/v:version/reports/:reportName/data',
9587
routesVersioning({
9688
"1.1.0": respondV1, // legacy
97-
"~1.2.0": fetchData,
89+
"~2.0.0": fetchData,
9890
}, NoMatchFoundCallback));
9991

10092
router.get('/v:version/domain/:domain/reports/:reportName/data',
10193
routesVersioning({
10294
"1.1.0": respondDomainV1, // legacy
103-
"~1.2.0": checkDomainFilter,
95+
"~2.0.0": checkDomainFilter,
10496
}, NoMatchFoundCallback));
10597

10698
router.get('/v:version/agencies/:reportAgency/reports/:reportName/data',
10799
routesVersioning({
108100
"1.1.0": respondV1, // legacy
109-
"~1.2.0": fetchData,
101+
"~2.0.0": fetchData,
110102
}, NoMatchFoundCallback));
111103

112104
function NoMatchFoundCallback(req, res) {
@@ -128,5 +120,4 @@ function respondDomainV1(req, res) {
128120
return checkDomainFilter(req, res)
129121
}
130122

131-
132123
module.exports = app;

0 commit comments

Comments
 (0)