propose env values for local developement

Author: scottqueen-bixal

README.md

@@ -13,8 +13,7 @@ in response to HTTP requests.
 
 This Analytics API maintains the schema for the database that the
 [Analytics Reporter](https://github.com/18F/analytics-reporter)
-writes to.
-Thus, the Analytics API must be setup and
+writes to. Thus, the Analytics API must be setup and
 configured before the Analytics Reporter starts writing data.
 
 First, create the database:
@@ -23,6 +22,10 @@ First, create the database:
 createdb analytics-reporter
 ```
 
+````bash
+export NODE_ENV=development # developing locally
+````
+
 Once the database is created, clone the app and install the dependencies via NPM.
 The install script has a postinstall hook that will migrate
 the database.
@@ -48,6 +51,7 @@ is configured to write to the same database and run with the `--write-to-databas
 # Using the API
 
 The Analytics API exposes 3 API endpoints:
+include version in the request, ie `/v1.1/`
 
 - `/reports/:report_name/data`
 - `/agencies/:agency_name/reports/:reportName/data`

env.example

@@ -0,0 +1,4 @@
+export NODE_ENV=development
+export POSTGRES_USER=postgres
+export POSTGRES_PASSWORD=123abc
+POSTGRES_DATABASE=analytics-reporter

knexfile.js

@@ -2,7 +2,9 @@ module.exports = {
   development: {
     client: 'postgresql',
     connection: {
-      database: 'analytics-reporter'
+      user: process.env.POSTGRES_USER || 'postgres',
+      password: process.env.POSTGRES_PASSWORD || '123abc',
+      database: process.env.POSTGRES_DATABASE || 'analytics-reporter',
     }
   },
   production: {

src/api-data-gov-filter.js

@@ -3,13 +3,17 @@ const config = require('./config');
 const apiDataGovFilter = (req, res, next) => {
   if (!config.api_data_gov_secret || req.path === '/') {
     return next();
-  } else if (req.headers['api-data-gov-secret'] !== config.api_data_gov_secret) {
+  }
+  else if (process.env.NODE_ENV !== 'development') {
+  console.log('inside')
+    if (req.headers['api-data-gov-secret'] !== config.api_data_gov_secret) {
     res.status(403);
     return res.json({
       message: 'Unauthorized. See https://analytics.usa.gov/developer',
       status: 403
     });
   }
+}
   return next();
 };