Skip to content

Commit eff4b90

Browse files
author
Michael Levin
committed
[Tech Debt] Update header/select to use BEM and shared vars
1 parent dac3a3f commit eff4b90

38 files changed

+591
-597
lines changed

_includes/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<header id="analytics-header" class="grid-row">
1+
<header id="analytics-header" class="grid-row padding-3">
22
<h1>
33
<img
44
src="{{ site.baseurl }}/images/analytics.svg"

js/components/agency_select/AgencySelect.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ function AgencySelect({ mainAgencyName, agencies, pathSuffix = "" }) {
4444

4545
return (
4646
<>
47-
<label className="usa-label" htmlFor="analytics-agency-select">
47+
<label
48+
className="usa-label text--centered margin-y-1"
49+
htmlFor="analytics-agency-select"
50+
>
4851
Select an agency to display results
4952
</label>
5053
<select

js/components/agency_select/__tests__/__snapshots__/AgencySelect.spec.js.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
exports[`AgencySelect when all params are provided and subagencies do not exist renders 1`] = `
44
[
55
<label
6-
className="usa-label"
6+
className="usa-label text--centered margin-y-1"
77
htmlFor="analytics-agency-select"
88
>
99
Select an agency to display results
@@ -34,7 +34,7 @@ exports[`AgencySelect when all params are provided and subagencies do not exist
3434
exports[`AgencySelect when all params are provided and subagencies exist renders 1`] = `
3535
[
3636
<label
37-
className="usa-label"
37+
className="usa-label text--centered margin-y-1"
3838
htmlFor="analytics-agency-select"
3939
>
4040
Select an agency to display results
@@ -79,7 +79,7 @@ exports[`AgencySelect when all params are provided and subagencies exist renders
7979
exports[`AgencySelect when optional params are not provided renders 1`] = `
8080
[
8181
<label
82-
className="usa-label"
82+
className="usa-label text--centered margin-y-1"
8383
htmlFor="analytics-agency-select"
8484
>
8585
Select an agency to display results

js/components/chart/ConsolidatedBarChart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function ConsolidatedBarChart({ dataUrl, chartDataKey, maxItems }) {
4141

4242
return (
4343
<figure id={`chart_${chartDataKey}`} ref={ref}>
44-
<div className="data chart__bar-chart"></div>
44+
<div className="data chart__bar-chart margin-top-4"></div>
4545
</figure>
4646
);
4747
}

0 commit comments

Comments
 (0)