Merge pull request #578 from 18F/mitchellhenke/update-qex-validation

Improve q-expand data validation

Author: Mitchell Henke

config/q-expand.csv

@@ -1179,7 +1179,7 @@ Q1BA,Division 1
 Q1BB,Division 2
 Q1BBA,Branch A
 Q1BBB,Branch B
-Q2,"Deputy Commissioner/Director,"
+Q2,"Deputy Commissioner/Director"
 Q2A,Office of TTS Delivery
 Q2A0A,Technology Operations Division
 Q2AA,Office of Solutions

src/scripts/q-expand.test.js

@@ -245,8 +245,8 @@ describe("q-expand csv data", () => {
     }
   });
 
-  it("is formatted correctly", async () =>
-    new Promise((resolve) => {
+  it("is formatted correctly", async () => {
+    const invalidCount = await new Promise((resolve) => {
       const rows = [];
 
       fs.createReadStream("config/q-expand.csv")
@@ -255,9 +255,15 @@ describe("q-expand csv data", () => {
           rows.push(row);
         })
         .on("end", () => {
-          const invalid = rows.filter((row) => row.length !== 2);
-          expect(invalid.length).toBe(0);
-          resolve();
+          const invalid = rows.filter(
+            (row) =>
+              row.length !== 2 ||
+              row.filter((column) => column.endsWith(",")).length > 0,
+          );
+          resolve(invalid.length);
         });
-    }));
+    });
+
+    expect(invalidCount).toBe(0);
+  });
 });