change reportMailer definition and specs (DoNotMerge) (#12740)

shilenpatel1 · web-flow · commit 700a2e14ccf5 · 2026-01-05T14:02:14.000-06:00
* change reportMailer defination and specs changelog: Internal, Reporting, Update ReportMailer, and its caller see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367 * lint fix changelog: Internal, Reporting, Update ReportMailer, and its caller see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367 * add spec for BCC and CC * changelog: Internal, Reporting, add spec for BCC and CC see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/367
diff --git a/app/jobs/reports/ab_tests_report.rb b/app/jobs/reports/ab_tests_report.rb
@@ -26,7 +26,7 @@ def tables_report(ab_test)
       report = ab_tests_report(ab_test)
 
       ReportMailer.tables_report(
-        email: ab_test.report.email,
+        to: ab_test.report.email,
         subject:,
         message: [subject, report.participants_message].compact,
         reports: report.as_emailable_reports,
diff --git a/app/jobs/reports/api_transaction_count_report.rb b/app/jobs/reports/api_transaction_count_report.rb
@@ -28,7 +28,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
       end
 
       ReportMailer.tables_report(
-        email: email_addresses,
+        to: email_addresses,
         subject: "API Transaction Count Report - #{report_date.to_date}",
         reports: reports,
         message: preamble,
diff --git a/app/jobs/reports/authentication_report.rb b/app/jobs/reports/authentication_report.rb
@@ -20,7 +20,7 @@ def perform(report_date)
 
         report_hash['emails'].each do |email|
           ReportMailer.tables_report(
-            email:,
+            to: email,
             subject:,
             message:,
             reports:,
diff --git a/app/jobs/reports/drop_off_report.rb b/app/jobs/reports/drop_off_report.rb
@@ -18,7 +18,7 @@ def perform(report_date)
         reports = [report_maker(config['issuers']).as_emailable_reports].flatten
         config['emails'].each do |email|
           ReportMailer.tables_report(
-            email: email,
+            to: email,
             subject: subject,
             message: preamble,
             reports: reports,
diff --git a/app/jobs/reports/fraud_metrics_report.rb b/app/jobs/reports/fraud_metrics_report.rb
@@ -28,7 +28,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
       end
 
       ReportMailer.tables_report(
-        email: email_addresses,
+        to: email_addresses,
         subject: "Fraud Metrics Report - #{report_date.to_date}",
         reports: reports,
         message: preamble,
diff --git a/app/jobs/reports/identity_verification_outcomes_report.rb b/app/jobs/reports/identity_verification_outcomes_report.rb
@@ -27,7 +27,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
       end
 
       ReportMailer.tables_report(
-        email: email_addresses,
+        to: email_addresses,
         subject: "Identity Verification Outcomes Report - #{report_date.to_date}",
         reports: reports,
         message: preamble,
diff --git a/app/jobs/reports/identity_verification_report.rb b/app/jobs/reports/identity_verification_report.rb
@@ -23,7 +23,7 @@ def perform(report_date)
       end
 
       ReportMailer.tables_report(
-        email: email,
+        to: email,
         subject: "Daily Identity Verification Report - #{report_date.to_date}",
         reports: reports,
         message: message,
diff --git a/app/jobs/reports/irs_credential_tenure_report.rb b/app/jobs/reports/irs_credential_tenure_report.rb
@@ -29,7 +29,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
       end
 
       ReportMailer.tables_report(
-        email: email_addresses,
+        to: email_addresses,
         subject: "IRS Credential Tenure Report - #{date.to_date}",
         reports: reports,
         message: preamble,
diff --git a/app/jobs/reports/irs_fraud_metrics_report.rb b/app/jobs/reports/irs_fraud_metrics_report.rb
@@ -33,7 +33,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       end
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "IRS Fraud Metrics Report - #{report_date.to_date}",
         reports: reports,
diff --git a/app/jobs/reports/irs_monthly_cred_metrics_report.rb b/app/jobs/reports/irs_monthly_cred_metrics_report.rb
@@ -121,7 +121,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       # rubocop:enable Layout/LineLength
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "#{partner_strings.first} Monthly Credential Metrics - #{@report_date.to_date}",
         message: preamble,
diff --git a/app/jobs/reports/irs_registration_funnel_report.rb b/app/jobs/reports/irs_registration_funnel_report.rb
@@ -33,7 +33,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       end
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "IRS Registration Funnel Report - #{report_date.to_date}",
         reports: reports,
diff --git a/app/jobs/reports/irs_verification_demographics_report.rb b/app/jobs/reports/irs_verification_demographics_report.rb
@@ -33,7 +33,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       end
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "IRS Verification Demographics Metrics Report - #{report_date.to_date}",
         reports: reports,
diff --git a/app/jobs/reports/irs_verification_report.rb b/app/jobs/reports/irs_verification_report.rb
@@ -33,7 +33,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       end
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "IRS Verification Report - #{report_date.to_date}",
         reports: reports,
diff --git a/app/jobs/reports/mfa_report.rb b/app/jobs/reports/mfa_report.rb
@@ -20,7 +20,7 @@ def perform(report_date)
 
         report_hash['emails'].each do |email|
           ReportMailer.tables_report(
-            email:,
+            to: email,
             subject:,
             message:,
             reports:,
diff --git a/app/jobs/reports/monthly_irs_verification_report.rb b/app/jobs/reports/monthly_irs_verification_report.rb
@@ -33,7 +33,7 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       end
 
       ReportMailer.tables_report(
-        email: to_emails,
+        to: to_emails,
         bcc: bcc_emails,
         subject: "Monthly IRS Verification Report - #{report_date.to_date}",
         reports: reports,
diff --git a/app/jobs/reports/monthly_key_metrics_report.rb b/app/jobs/reports/monthly_key_metrics_report.rb
@@ -29,7 +29,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
       end
 
       ReportMailer.tables_report(
-        email: email_addresses,
+        to: email_addresses,
         subject: "Monthly Key Metrics Report - #{date.to_date}",
         reports: reports,
         message: preamble,
diff --git a/app/jobs/reports/protocols_report.rb b/app/jobs/reports/protocols_report.rb
@@ -20,7 +20,7 @@ def perform(date = Time.zone.yesterday.end_of_day)
 
         report_hash['emails'].each do |email|
           ReportMailer.tables_report(
-            email:,
+            to: email,
             subject:,
             message:,
             reports:,
diff --git a/app/jobs/reports/sp_idv_weekly_dropoff_report.rb b/app/jobs/reports/sp_idv_weekly_dropoff_report.rb
@@ -45,7 +45,7 @@ def send_report(report_config)
 
       emails.each do |email|
         ReportMailer.tables_report(
-          email: email,
+          to: email,
           subject: "#{agency_report_title} - #{report_date.to_date}",
           reports: report_maker.as_emailable_reports,
           message: message,
diff --git a/app/jobs/reports/sp_issuer_user_counts_report.rb b/app/jobs/reports/sp_issuer_user_counts_report.rb
@@ -30,7 +30,7 @@ def perform(_date)
 
         emails.each do |email|
           ReportMailer.tables_report(
-            email:,
+            to: email,
             subject:,
             message:,
             reports:,
diff --git a/app/jobs/reports/sp_proofing_events_by_uuid.rb b/app/jobs/reports/sp_proofing_events_by_uuid.rb
@@ -46,7 +46,7 @@ def send_report(report_config)
 
       emails.each do |email|
         ReportMailer.tables_report(
-          email: email,
+          to: email,
           subject: "#{agency_report_title} - #{report_date.to_date}",
           reports: report_maker.as_emailable_reports,
           message: email_message,
diff --git a/app/mailers/report_mailer.rb b/app/mailers/report_mailer.rb
@@ -32,7 +32,7 @@ def warn_error(email:, error:, env: Rails.env)
   #   an array of tables (which are arrays of rows (arrays of strings))
   #   each table can have a first "row" that is a hash with options
   def tables_report(
-    email:,
+    to:,
     subject:, reports:, attachment_format:, bcc: nil,
     cc: nil,
     message: nil,
@@ -73,6 +73,6 @@ def tables_report(
       raise ArgumentError, "unknown attachment_format=#{attachment_format}"
     end
 
-    mail(to: email, bcc: bcc, cc: cc, subject: "[#{env}] #{subject}")
+    mail(to: to, bcc: bcc, cc: cc, subject: "[#{env}] #{subject}")
   end
 end
diff --git a/spec/jobs/reports/ab_tests_report_spec.rb b/spec/jobs/reports/ab_tests_report_spec.rb
@@ -72,7 +72,7 @@
 
     it 'emails the table report with csv' do
       expect(ReportMailer).to receive(:tables_report).with(
-        email:,
+        to: email,
         subject: "A/B Tests Report - reCAPTCHA at Sign-In - #{report_date}",
         message: [
           "A/B Tests Report - reCAPTCHA at Sign-In - #{report_date}",
diff --git a/spec/jobs/reports/authentication_report_spec.rb b/spec/jobs/reports/authentication_report_spec.rb
@@ -60,7 +60,7 @@
 
     it 'emails the csv' do
       expect(ReportMailer).to receive(:tables_report).with(
-        email:,
+        to: email,
         subject: "Weekly Authentication Report - #{report_date}",
         message: "Report: authentication-report #{report_date}",
         reports:,
diff --git a/spec/jobs/reports/drop_off_report_spec.rb b/spec/jobs/reports/drop_off_report_spec.rb
@@ -28,7 +28,7 @@
 
     it 'sends a ReportMailer with data that matches an empty Reporting::DropOffReport' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: 'ursula@example.com',
+        to: 'ursula@example.com',
         subject: "Drop Off Report - #{report_date.to_date}",
         reports: satisfy do |value|
           expect(value.first).to eq(empty_emailable_report.first)
@@ -123,7 +123,7 @@
       ).and_return(report_maker)
 
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: 'ursula@example.com',
+        to: 'ursula@example.com',
         subject: "Drop Off Report - #{report_date.to_date}",
         reports: anything,
         message: "<h2>\n  Drop Off Report\n</h2>\n",
diff --git a/spec/jobs/reports/fraud_metrics_report_spec.rb b/spec/jobs/reports/fraud_metrics_report_spec.rb
@@ -89,7 +89,7 @@
 
   it 'sends out a report to just to team agnes' do
     expect(ReportMailer).to receive(:tables_report).once.with(
-      email: anything,
+      to: anything,
       subject: 'Fraud Metrics Report - 2021-03-02',
       reports: anything,
       message: report.preamble,
@@ -104,7 +104,7 @@
 
     it 'sends out a report to everybody' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: anything,
+        to: anything,
         subject: 'Fraud Metrics Report - 2021-02-28',
         reports: anything,
         message: report.preamble,
diff --git a/spec/jobs/reports/identity_verification_outcomes_report_spec.rb b/spec/jobs/reports/identity_verification_outcomes_report_spec.rb
@@ -120,7 +120,7 @@
 
   it 'sends out a report to just to team data' do
     expect(ReportMailer).to receive(:tables_report).once.with(
-      email: anything,
+      to: anything,
       subject: 'Identity Verification Outcomes Report - 2021-03-02',
       reports: anything,
       message: report.preamble,
diff --git a/spec/jobs/reports/identity_verification_report_spec.rb b/spec/jobs/reports/identity_verification_report_spec.rb
@@ -53,7 +53,7 @@
       )
 
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: IdentityConfig.store.team_ada_email,
+        to: IdentityConfig.store.team_ada_email,
         subject: 'Daily Identity Verification Report - 2023-12-12',
         reports: anything,
         message: anything,
diff --git a/spec/jobs/reports/irs_credential_tenure_report_spec.rb b/spec/jobs/reports/irs_credential_tenure_report_spec.rb
@@ -50,7 +50,7 @@
     it 'uploads each report to S3 and sends an email' do
       expect_any_instance_of(described_class).to receive(:upload_to_s3).exactly(3).times
       expect(ReportMailer).to receive(:tables_report).with(
-        email: emails,
+        to: emails,
         subject: "IRS Credential Tenure Report - #{report_date}",
         reports: reports,
         message: kind_of(String),
diff --git a/spec/jobs/reports/irs_fraud_metrics_report_spec.rb b/spec/jobs/reports/irs_fraud_metrics_report_spec.rb
@@ -72,7 +72,7 @@
     subject(:report) { described_class.new(report_date, :both) }
     it 'sends out a report to just to team data and partner' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: ['mock_feds@example.com', 'mock_contractors@example.com'],
+        to: ['mock_feds@example.com', 'mock_contractors@example.com'],
         bcc: ['mock_internal@example.com'],
         subject: 'IRS Fraud Metrics Report - 2025-09-30',
         reports: anything,
@@ -102,7 +102,7 @@
       )
 
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: ['mock_internal@example.com'],
+        to: ['mock_internal@example.com'],
         bcc: [],
         subject: 'IRS Fraud Metrics Report - 2025-09-30',
         reports: anything,
@@ -143,7 +143,7 @@
     subject(:report) { described_class.new(report_date, :internal) }
     it 'sends out a report to just to team data' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: ['mock_internal@example.com'],
+        to: ['mock_internal@example.com'],
         bcc: [],
         subject: 'IRS Fraud Metrics Report - 2025-09-26',
         reports: anything,
@@ -160,7 +160,7 @@
 
     it 'sends out a report to everybody' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: ['mock_feds@example.com', 'mock_contractors@example.com'],
+        to: ['mock_feds@example.com', 'mock_contractors@example.com'],
         bcc: ['mock_internal@example.com'],
         subject: 'IRS Fraud Metrics Report - 2021-02-28',
         reports: anything,
diff --git a/spec/jobs/reports/irs_monthly_cred_metrics_report_spec.rb b/spec/jobs/reports/irs_monthly_cred_metrics_report_spec.rb
@@ -87,7 +87,7 @@
 
     it 'sends out a report to team_data and PARTNER' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: mock_reports_partner_emails,
+        to: mock_reports_partner_emails,
         bcc: mock_reports_internal_emails,
         subject: "#{mock_partner.first} Monthly Credential Metrics - #{report_date.to_date}",
         reports: anything,
@@ -105,7 +105,7 @@
 
     it 'sends out a report to internal receivers' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: mock_reports_internal_emails,
+        to: mock_reports_internal_emails,
         bcc: [],
         subject: "#{mock_partner.first} Monthly Credential Metrics - #{report_date}",
         reports: anything,
@@ -135,7 +135,7 @@
       )
 
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: mock_reports_internal_emails,
+        to: mock_reports_internal_emails,
         bcc: [],
         subject: "#{mock_partner.first} Monthly Credential Metrics - #{report_date.to_date}",
         reports: anything,
diff --git a/spec/jobs/reports/irs_registration_funnel_report_spec.rb b/spec/jobs/reports/irs_registration_funnel_report_spec.rb
@@ -82,7 +82,7 @@
       )
 
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: mock_reports_internal_emails,
+        to: mock_reports_internal_emails,
         bcc: [],
         subject: 'IRS Registration Funnel Report - 2025-10-19',
         reports: anything,
@@ -120,7 +120,7 @@
 
   it 'sends out a report to just to team data' do
     expect(ReportMailer).to receive(:tables_report).once.with(
-      email: ['mock_internal@example.com'],
+      to: ['mock_internal@example.com'],
       bcc: [],
       subject: 'IRS Registration Funnel Report - 2021-03-02',
       reports: anything,
@@ -158,7 +158,7 @@
     subject(:report) { described_class.new(report_date, :both) }
     it 'sends out a report to just to team data and partner' do
       expect(ReportMailer).to receive(:tables_report).once.with(
-        email: ['mock_partner@example.com'],
+        to: ['mock_partner@example.com'],
         bcc: ['mock_internal@example.com'],
         subject: 'IRS Registration Funnel Report - 2025-10-19',
         reports: anything,
diff --git a/spec/jobs/reports/irs_verification_demographics_report_spec.rb b/spec/jobs/reports/irs_verification_demographics_report_spec.rb
diff --git a/spec/jobs/reports/irs_verification_report_spec.rb b/spec/jobs/reports/irs_verification_report_spec.rb
diff --git a/spec/jobs/reports/mfa_report_spec.rb b/spec/jobs/reports/mfa_report_spec.rb
diff --git a/spec/jobs/reports/monthly_irs_verification_report_spec.rb b/spec/jobs/reports/monthly_irs_verification_report_spec.rb
diff --git a/spec/jobs/reports/monthly_key_metrics_report_spec.rb b/spec/jobs/reports/monthly_key_metrics_report_spec.rb
diff --git a/spec/jobs/reports/protocols_report_spec.rb b/spec/jobs/reports/protocols_report_spec.rb
diff --git a/spec/jobs/reports/sp_idv_weekly_dropoff_report_spec.rb b/spec/jobs/reports/sp_idv_weekly_dropoff_report_spec.rb
diff --git a/spec/jobs/reports/sp_issuer_user_counts_report_spec.rb b/spec/jobs/reports/sp_issuer_user_counts_report_spec.rb
diff --git a/spec/jobs/reports/sp_proofing_events_by_uuid_spec.rb b/spec/jobs/reports/sp_proofing_events_by_uuid_spec.rb
diff --git a/spec/mailers/previews/report_mailer_preview.rb b/spec/mailers/previews/report_mailer_preview.rb
diff --git a/spec/mailers/report_mailer_spec.rb b/spec/mailers/report_mailer_spec.rb
