Add refactor for 'plain' verification report

See ##12670

Author: astrogeco

app/jobs/reports/irs_verification_report.rb

@@ -5,9 +5,9 @@
 
 module Reports
   class IrsVerificationReport < BaseReport
-    REPORT_NAME = 'irs-verification-report'
+    # REPORT_NAME = 'sp-verification-report'
 
-    attr_reader :report_date, :report_receiver
+    attr_reader :report_date, :report_receiver, :report_name, :report_title
 
     def initialize(init_date = nil, init_receiver = :internal, *args, **rest)
       @report_date = init_date
@@ -19,24 +19,40 @@ def perform(perform_date = Time.zone.yesterday.end_of_day, perform_receiver = :i
       @report_date = perform_date
       @report_receiver = perform_receiver.to_sym
 
-      email_addresses = emails
+      IdentityConfig.store.sp_verification_report_configs.each do |report_config|
+        send_report(report_config)
+      end
+    end
+
+    def send_report(report_config)
+      issuers = report_config['issuers']
+      agency_abbreviation = report_config['agency_abbreviation']
+      partner_emails = report_config['partner_emails']
+      internal_emails = report_config['internal_emails']
+
+      @report_name = "#{agency_abbreviation.downcase}_verification_report"
+      @report_title = "#{agency_abbreviation} Verification Report"
+
+      email_addresses = emails(internal_emails, partner_emails)
       to_emails = email_addresses[:to].select(&:present?)
       bcc_emails = email_addresses[:bcc].select(&:present?)
 
       if to_emails.empty? && bcc_emails.empty?
-        Rails.logger.warn 'No email addresses received - IRS Verification Report NOT SENT'
+        Rails.logger.warn "No email addresses received - #{@report_title} NOT SENT"
         return false
       end
 
-      reports.each do |report|
+      emailable_reports = reports(issuers, agency_abbreviation)
+
+      emailable_reports.each do |report|
         upload_to_s3(report.table, report_name: report.filename)
       end
 
       ReportMailer.tables_report(
         to: to_emails,
         bcc: bcc_emails,
-        subject: "IRS Verification Report - #{report_date.to_date}",
-        reports: reports,
+        subject: "#{@report_title} - #{report_date.to_date}",
+        reports: emailable_reports,
         message: preamble,
         attachment_format: :csv,
       ).deliver_now
@@ -61,41 +77,39 @@ def preamble(env: Identity::Hostdata.env || 'local')
       ERB
     end
 
-    def reports
-      @reports ||= irs_verification_report.as_emailable_reports
+    def reports(issuers, agency_abbreviation)
+      sp_verification_report(issuers, agency_abbreviation).as_emailable_reports
     end
 
     def previous_week_range
       @report_date.beginning_of_week(:sunday).prev_occurring(:sunday).all_week(:sunday)
     end
 
-    def irs_verification_report
-      @irs_verification_report ||= Reporting::IrsVerificationReport.new(
+    def sp_verification_report(issuers, agency_abbreviation)
+      Reporting::IrsVerificationReport.new(
         time_range: previous_week_range,
-        issuers: IdentityConfig.store.irs_verification_report_issuers || [],
+        issuers: issuers || [],
+        agency_abbreviation: agency_abbreviation,
       )
     end
 
-    def emails
-      internal_emails = [*IdentityConfig.store.team_daily_reports_emails].select(&:present?)
-      irs_emails      = [*IdentityConfig.store.irs_verification_report_config].select(&:present?)
-
-      if report_receiver == :both && irs_emails.empty?
+    def emails(internal_emails, partner_emails)
+      if report_receiver == :both && partner_emails.empty?
         Rails.logger.warn(
-          'IRS Verification Report: recipient is :both ' \
-          'but no external email specified',
+          "#{@report_title}: recipient is :both " \
+          "but no external email specified",
         )
       end
 
-      if report_receiver == :both && irs_emails.present?
-        { to: irs_emails, bcc: internal_emails }
+      if report_receiver == :both && partner_emails.present?
+        { to: partner_emails, bcc: internal_emails }
       else
         { to: internal_emails, bcc: [] }
       end
     end
 
     def upload_to_s3(report_body, report_name: nil)
-      _latest, path = generate_s3_paths(REPORT_NAME, 'csv', subname: report_name, now: report_date)
+      _latest, path = generate_s3_paths(@report_name, 'csv', subname: report_name, now: report_date)
 
       if bucket_name.present?
         upload_file_to_s3_bucket(

config/initializers/job_configurations.rb

@@ -195,6 +195,11 @@
         cron: cron_every_monday_5am,
         args: -> { [Time.zone.yesterday.end_of_day, :both] },
       },
+      sp_weekly_verification_report: {
+        class: 'Reports::IrsVerificationReport',
+        cron: cron_every_monday_5am,
+        args: -> { [Time.zone.yesterday.end_of_day, :internal] },
+      },
       # Send Identity Verification report to S3
       identity_verification_report: {
         class: 'Reports::IdentityVerificationReport',