fix: correct lint issues

Author: 1995parham

internal/infra/http/handler/student.go

@@ -47,7 +47,9 @@ func (s *Student) GetByID(c echo.Context) error {
 
 func (s *Student) Get(c echo.Context) error {
 	var idPtr *uint64
-	if id, err := strconv.ParseUint(c.QueryParam("id"), 10, 64); err == nil {
+
+	id, err := strconv.ParseUint(c.QueryParam("id"), 10, 64)
+	if err == nil {
 		idPtr = &id
 	}
 
@@ -77,23 +79,27 @@ func (s *Student) Get(c echo.Context) error {
 func (s *Student) Create(c echo.Context) error {
 	var req request.StudentCreate
 
-	if err := c.Bind(&req); err != nil {
+	err := c.Bind(&req)
+	if err != nil {
 		return echo.ErrBadRequest
 	}
 	// we have the filled request
-	if err := req.Validate(); err != nil {
+	err = req.Validate()
+	if err != nil {
 		return echo.ErrBadRequest
 	}
 
 	// nolint: gosec, mnd
 	id := rand.Uint64() % 1_000_000
-	if err := s.repo.Add(c.Request().Context(), model.Student{
+
+	err = s.repo.Add(c.Request().Context(), model.Student{
 		ID:           id,
 		FirstName:    req.Name,
 		LastName:     req.Family,
 		EntranceYear: 0,
 		Courses:      []model.Course{},
-	}); err != nil {
+	})
+	if err != nil {
 		if errors.Is(err, studentrepo.ErrStudentIDDuplicate) {
 			return echo.ErrBadRequest
 		}

internal/infra/http/request/student.go

@@ -14,7 +14,8 @@ type StudentCreate struct {
 func (sc StudentCreate) Validate() error {
 	validate := validator.New(validator.WithRequiredStructEnabled())
 
-	if err := validate.Struct(sc); err != nil {
+	err := validate.Struct(sc)
+	if err != nil {
 		return fmt.Errorf("create request validation failed %w", err)
 	}
 

internal/infra/repository/studentmem/student.go

@@ -24,9 +24,11 @@ func New() *Repository {
 
 func (r *Repository) Add(_ context.Context, model model.Student) error {
 	r.lock.RLock()
+
 	if _, ok := r.students[model.ID]; ok {
 		return studentrepo.ErrStudentIDDuplicate
 	}
+
 	r.lock.RUnlock()
 
 	r.lock.Lock()

internal/infra/repository/studentsql/student.go

@@ -12,6 +12,7 @@ import (
 
 type StudentDTO struct {
 	model.Student
+
 	CreatedAt time.Time
 	UpdatedAt time.Time
 	DeletedAt gorm.DeletedAt `gorm:"index"`

main.go

@@ -18,7 +18,8 @@ func main() {
 		log.Fatalf("failed to connect database %v", err)
 	}
 
-	if err := db.AutoMigrate(new(studentsql.StudentDTO)); err != nil {
+	err = db.AutoMigrate(new(studentsql.StudentDTO))
+	if err != nil {
 		log.Fatalf("failed to run migrations %v", err)
 	}
 
@@ -29,7 +30,8 @@ func main() {
 	h := handler.NewStudent(repo)
 	h.Register(app.Group("students/"))
 
-	if err := app.Start("0.0.0.0:1373"); err != nil {
+	err = app.Start("0.0.0.0:1373")
+	if err != nil {
 		log.Fatalf("server failed to start %v", err)
 	}
 }