Skip to content

Commit 8b9e7ae

Browse files
authored
fix: Fix container image cleanup count display abnormality issue (#11649)
1 parent 15e499c commit 8b9e7ae

File tree

12 files changed

+14
-20
lines changed

12 files changed

+14
-20
lines changed

agent/app/service/container.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -435,29 +435,25 @@ func (u *ContainerService) Prune(req dto.ContainerPrune) error {
435435
}
436436
}
437437
taskItem.Log(i18n.GetMsgByKey("PruneStart"))
438-
DeletedNumber := 0
439438
SpaceReclaimed := 0
440439
switch req.PruneType {
441440
case "container":
442441
rep, err := client.ContainersPrune(context.Background(), pruneFilters)
443442
if err != nil {
444443
return err
445444
}
446-
DeletedNumber = len(rep.ContainersDeleted)
447445
SpaceReclaimed = int(rep.SpaceReclaimed)
448446
case "image":
449447
rep, err := client.ImagesPrune(context.Background(), pruneFilters)
450448
if err != nil {
451449
return err
452450
}
453-
DeletedNumber = len(rep.ImagesDeleted)
454451
SpaceReclaimed = int(rep.SpaceReclaimed)
455452
case "network":
456-
rep, err := client.NetworksPrune(context.Background(), pruneFilters)
453+
_, err := client.NetworksPrune(context.Background(), pruneFilters)
457454
if err != nil {
458455
return err
459456
}
460-
DeletedNumber = len(rep.NetworksDeleted)
461457
case "volume":
462458
versions, err := client.ServerVersion(context.Background())
463459
if err != nil {
@@ -470,7 +466,6 @@ func (u *ContainerService) Prune(req dto.ContainerPrune) error {
470466
if err != nil {
471467
return err
472468
}
473-
DeletedNumber = len(rep.VolumesDeleted)
474469
SpaceReclaimed = int(rep.SpaceReclaimed)
475470
case "buildcache":
476471
opts := build.CachePruneOptions{}
@@ -479,10 +474,9 @@ func (u *ContainerService) Prune(req dto.ContainerPrune) error {
479474
if err != nil {
480475
return err
481476
}
482-
DeletedNumber = len(rep.CachesDeleted)
483477
SpaceReclaimed = int(rep.SpaceReclaimed)
484478
}
485-
taskItem.Log(i18n.GetMsgWithMap("PruneHelper", map[string]interface{}{"name": i18n.GetMsgByKey(name), "count": DeletedNumber, "size": common.LoadSizeUnit2F(float64(SpaceReclaimed))}))
479+
taskItem.Log(i18n.GetMsgWithMap("PruneHelper", map[string]interface{}{"name": i18n.GetMsgByKey(name), "size": common.LoadSizeUnit2F(float64(SpaceReclaimed))}))
486480
return nil
487481
}, nil)
488482
go func() {

agent/i18n/lang/en.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ ErrObjectInUsed: "This object is in use and cannot be deleted!"
212212
ErrObjectBeDependent: "This image is depended on by other images and cannot be deleted!"
213213
ErrPortRules: 'Port number does not match, please re-enter!'
214214
ErrPgImagePull: 'Image pull timed out, please configure image acceleration or manually pull the {{ .name }} image and try again'
215-
PruneHelper: "This cleanup removed {{ .name }} {{ .count }} items, freeing {{ .size }} disk space"
215+
PruneHelper: "This cleanup {{ .name }} freed disk space {{ .size }}"
216216
ImageRemoveHelper: "Deleted image {{ .name }}, freeing {{ .size }} disk space"
217217
BuildCache: "Build cache"
218218
Volume: "Storage volume"

agent/i18n/lang/es-ES.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ ErrObjectInUsed: "Este objeto está en uso y no se puede eliminar!"
211211
ErrObjectBeDependent: "Esta imagen es dependida por otras imágenes y no se puede eliminar!"
212212
ErrPortRules: 'El número de puerto no coincide, ingrese de nuevo'
213213
ErrPgImagePull: 'Tiempo de espera al descargar la imagen, configure la aceleración o descárguela manualmente ({{ .name }}) e intente de nuevo'
214-
PruneHelper: "Esta limpieza eliminó {{ .name }} {{ .count }} elementos, liberando {{ .size }} de espacio en disco"
214+
PruneHelper: "Esta limpieza {{ .name }} liberó espacio en disco {{ .size }}"
215215
ImageRemoveHelper: "Imagen {{ .name }} eliminada, liberando {{ .size }} de espacio en disco"
216216
BuildCache: "Caché de compilación"
217217
Volume: "Volumen de almacenamiento"

agent/i18n/lang/ja.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ ErrObjectInUsed: "このオブジェクトは使用中であり、削除でき
211211
ErrObjectBeDependent: "このイメージは他のイメージに依存されているため、削除できません!"
212212
ErrPortRules: 'ポート番号が一致しません。再入力してください。'
213213
ErrPgImagePull: 'イメージのプルがタイムアウトしました。イメージのアクセラレーションを設定するか、{{ .name }} イメージを手動でプルして再試行してください'
214-
PruneHelper: "今回のクリーンアップで{{ .name }} {{ .count }}個を削除し、{{ .size }}のディスク領域を解放しました"
214+
PruneHelper: "今回のクリーンアップ {{ .name }} でディスク領域 {{ .size }} を解放しました"
215215
ImageRemoveHelper: "イメージ{{ .name }}を削除し、{{ .size }}のディスク領域を解放しました"
216216
BuildCache: "ビルドキャッシュ"
217217
Volume: "ストレージボリューム"

agent/i18n/lang/ko.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ ErrObjectInUsed: "이 객체는 사용 중이어서 삭제할 수 없습니다!"
212212
ErrObjectBeDependent: "이 이미지는 다른 이미지에 의존되어 있어 삭제할 수 없습니다!"
213213
ErrPortRules: '포트 번호가 일치하지 않습니다. 다시 입력하세요!'
214214
ErrPgImagePull: '이미지 풀링 시간이 초과되었습니다. 이미지 가속을 구성하거나 {{ .name }} 이미지를 수동으로 풀링한 다음 다시 시도하세요.'
215-
PruneHelper: "이번 정리에서 {{ .name }} {{ .count }}개를 제거하여 {{ .size }} 디스크 공간을 확보했습니다"
215+
PruneHelper: "이번 정리 {{ .name }}가 디스크 공간 {{ .size }}을(를) 확보했습니다"
216216
ImageRemoveHelper: "이미지 {{ .name }} 삭제, {{ .size }} 디스크 공간 확보"
217217
BuildCache: "빌드 캐시"
218218
Volume: "스토리지 볼륨"

agent/i18n/lang/ms.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ ErrObjectInUsed: "Objek ini sedang digunakan dan tidak boleh dipadam!"
212212
ErrObjectBeDependent: "Imej ini digantungkan oleh imej lain dan tidak boleh dipadam!"
213213
ErrPortRules: 'Nombor port tidak sepadan, sila masukkan semula!'
214214
ErrPgImagePull: 'Tarikh imej tamat masa, sila konfigurasikan pecutan imej atau tarik imej {{ .name }} secara manual dan cuba lagi'
215-
PruneHelper: "Pembersihan ini membuang {{ .name }} {{ .count }} item, membebaskan {{ .size }} ruang cakera"
215+
PruneHelper: "Pembersihan ini {{ .name }} membebaskan ruang cakera {{ .size }}"
216216
ImageRemoveHelper: "Padam imej {{ .name }}, membebaskan {{ .size }} ruang cakera"
217217
BuildCache: "Cache binaan"
218218
Volume: "Jilid storan"

agent/i18n/lang/pt-BR.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ ErrObjectInUsed: "Este objeto está em uso e não pode ser excluído!"
212212
ErrObjectBeDependent: "Esta imagem é dependida por outras imagens e não pode ser excluída!"
213213
ErrPortRules: 'O número da porta não corresponde, digite novamente!'
214214
ErrPgImagePull: 'Tempo limite para extração de imagem. Configure a aceleração de imagem ou extraia manualmente a imagem {{ .name }} e tente novamente'
215-
PruneHelper: "Esta limpeza removeu {{ .name }} {{ .count }} itens, liberando {{ .size }} de espaço em disco"
215+
PruneHelper: "Esta limpeza {{ .name }} liberou espaço em disco {{ .size }}"
216216
ImageRemoveHelper: "Excluída a imagem {{ .name }}, liberando {{ .size }} de espaço em disco"
217217
BuildCache: "Cache de construção"
218218
Volume: "Volume de armazenamento"

agent/i18n/lang/ru.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ ErrObjectInUsed: "Этот объект используется и не мож
212212
ErrObjectBeDependent: "Этот образ зависит от других образов и не может быть удален!"
213213
ErrPortRules: 'Номер порта не совпадает, введите заново!'
214214
ErrPgImagePull: 'Время извлечения изображения истекло. Настройте ускорение изображения или вручную извлеките изображение {{ .name }} и повторите попытку'
215-
PruneHelper: "Очистка удалила {{ .name }} в количестве {{ .count }}, освободив {{ .size }} дискового пространства"
215+
PruneHelper: "Эта очистка {{ .name }} освободила дисковое пространство {{ .size }}"
216216
ImageRemoveHelper: "Удалён образ {{ .name }}, освобождено {{ .size }} дискового пространства"
217217
BuildCache: "Кэш сборки"
218218
Volume: "Том хранилища"

agent/i18n/lang/tr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ ErrObjectInUsed: "Bu nesne kullanımda ve silinemez!"
213213
ErrObjectBeDependent: "Bu görüntü diğer görüntüler tarafından bağımlıdır ve silinemez!"
214214
ErrPortRules: 'Port numarası eşleşmiyor, lütfen yeniden girin!'
215215
ErrPgImagePull: 'Image çekme zaman aşımı, lütfen image hızlandırma yapılandırın veya manuel olarak {{ .name }} imageını çekin ve tekrar deneyin'
216-
PruneHelper: "Bu temizleme {{ .name }} {{ .count }} öğe kaldırdı, {{ .size }} disk alanı boşalttı"
216+
PruneHelper: "Bu temizlik {{ .name }} disk alanı {{ .size }} boşalttı"
217217
ImageRemoveHelper: "{{ .name }} imajı silindi, {{ .size }} disk alanı boşalttı"
218218
BuildCache: "Derleme önbelleği"
219219
Volume: "Depolama hacmi"

agent/i18n/lang/zh-Hant.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ ErrObjectInUsed: "該對象正被使用,無法刪除!"
211211
ErrObjectBeDependent: "該映像正被其他映像所依賴,無法刪除!"
212212
ErrPortRules: '連接埠數目不匹配,請重新輸入!'
213213
ErrPgImagePull: '鏡像拉取逾時,請配置鏡像加速或手動拉取{{ .name }} 鏡像後重試'
214-
PruneHelper: "本次清理 {{ .name }} {{ .count }} 個,釋放磁碟空間 {{ .size }}"
214+
PruneHelper: "本次清理 {{ .name }} 釋放磁碟空間 {{ .size }}"
215215
ImageRemoveHelper: "刪除鏡像 {{ .name }} ,釋放磁碟空間 {{ .size }}"
216216
BuildCache: "構建快取"
217217
Volume: "磁碟區"

0 commit comments

Comments
 (0)