Skip to content

Commit 9822427

Browse files
authored
fix: Fix the issue of abnormal token refreshing on alipan (#8747)
1 parent 658db55 commit 9822427

File tree

12 files changed

+28
-21
lines changed

12 files changed

+28
-21
lines changed

agent/app/service/backup.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ func (u *BackupService) RefreshToken(req dto.OperateByID) error {
281281
}
282282
varMap := make(map[string]interface{})
283283
if err := json.Unmarshal([]byte(backup.Vars), &varMap); err != nil {
284-
return fmt.Errorf("Failed to refresh %s - %s token, please retry, err: %v", backup.Type, backup.Name, err)
284+
return fmt.Errorf("failed to refresh %s - %s token, please retry, err: %v", backup.Type, backup.Name, err)
285285
}
286286
var (
287287
refreshToken string
@@ -298,7 +298,7 @@ func (u *BackupService) RefreshToken(req dto.OperateByID) error {
298298
if err != nil {
299299
varMap["refresh_status"] = constant.StatusFailed
300300
varMap["refresh_msg"] = err.Error()
301-
return fmt.Errorf("Failed to refresh %s-%s token, please retry, err: %v", backup.Type, backup.Name, err)
301+
return fmt.Errorf("failed to refresh %s-%s token, please retry, err: %v", backup.Type, backup.Name, err)
302302
}
303303
varMap["refresh_status"] = constant.StatusSuccess
304304
varMap["refresh_time"] = time.Now().Format(constant.DateTimeLayout)

agent/cron/job/backup.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (b *backup) Run() {
2929
global.LOG.Infof("Start to refresh %s-%s access_token ...", backupItem.Type, backupItem.Name)
3030
varMap := make(map[string]interface{})
3131
if err := json.Unmarshal([]byte(backupItem.Vars), &varMap); err != nil {
32-
global.LOG.Errorf("Failed to refresh %s - %s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
32+
global.LOG.Errorf("failed to refresh %s - %s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
3333
continue
3434
}
3535
var (
@@ -47,7 +47,7 @@ func (b *backup) Run() {
4747
if err != nil {
4848
varMap["refresh_status"] = constant.StatusFailed
4949
varMap["refresh_msg"] = err.Error()
50-
global.LOG.Errorf("Failed to refresh OneDrive token, please retry, err: %v", err)
50+
global.LOG.Errorf("failed to refresh OneDrive token, please retry, err: %v", err)
5151
continue
5252
}
5353
varMap["refresh_status"] = constant.StatusSuccess

agent/utils/cloud_storage/client/ali.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ func (a *aliClient) completeUpload(uploadID, fileID string) error {
477477
}
478478

479479
type tokenResp struct {
480-
AccessToken string `json:"access_token"`
480+
RefreshToken string `json:"refresh_token"`
481481
}
482482

483483
func loadToken(refresh_token string) (string, error) {
@@ -502,7 +502,7 @@ func loadToken(refresh_token string) (string, error) {
502502
if err := json.Unmarshal(resp.Body(), &respItem); err != nil {
503503
return "", err
504504
}
505-
return respItem.AccessToken, nil
505+
return respItem.RefreshToken, nil
506506
}
507507

508508
func RefreshALIToken(varMap map[string]interface{}) (string, error) {
@@ -531,5 +531,5 @@ func RefreshALIToken(varMap map[string]interface{}) (string, error) {
531531
if err := json.Unmarshal(resp.Body(), &respItem); err != nil {
532532
return "", err
533533
}
534-
return respItem.AccessToken, nil
534+
return respItem.RefreshToken, nil
535535
}

core/app/service/backup.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ func (u *BackupService) RefreshToken(req dto.OperateByName) error {
259259
}
260260
varMap := make(map[string]interface{})
261261
if err := json.Unmarshal([]byte(backup.Vars), &varMap); err != nil {
262-
return fmt.Errorf("Failed to refresh %s - %s token, please retry, err: %v", backup.Type, backup.Name, err)
262+
return fmt.Errorf("failed to refresh %s - %s token, please retry, err: %v", backup.Type, backup.Name, err)
263263
}
264264
var (
265265
refreshToken string
@@ -276,7 +276,7 @@ func (u *BackupService) RefreshToken(req dto.OperateByName) error {
276276
if err != nil {
277277
varMap["refresh_status"] = constant.StatusFailed
278278
varMap["refresh_msg"] = err.Error()
279-
return fmt.Errorf("Failed to refresh %s-%s token, please retry, err: %v", backup.Type, backup.Name, err)
279+
return fmt.Errorf("failed to refresh %s-%s token, please retry, err: %v", backup.Type, backup.Name, err)
280280
}
281281
varMap["refresh_status"] = constant.StatusSuccess
282282
varMap["refresh_time"] = time.Now().Format(constant.DateTimeLayout)

core/init/cron/job/backup.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func (b *backup) Run() {
3030
global.LOG.Infof("Start to refresh %s-%s access_token ...", backupItem.Type, backupItem.Name)
3131
varMap := make(map[string]interface{})
3232
if err := json.Unmarshal([]byte(backupItem.Vars), &varMap); err != nil {
33-
global.LOG.Errorf("Failed to refresh %s - %s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
33+
global.LOG.Errorf("failed to refresh %s - %s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
3434
continue
3535
}
3636
var (
@@ -48,7 +48,7 @@ func (b *backup) Run() {
4848
if err != nil {
4949
varMap["refresh_status"] = constant.StatusFailed
5050
varMap["refresh_msg"] = err.Error()
51-
global.LOG.Errorf("Failed to refresh %s-%s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
51+
global.LOG.Errorf("failed to refresh %s-%s token, please retry, err: %v", backupItem.Type, backupItem.Name, err)
5252
continue
5353
}
5454
varMap["refresh_status"] = constant.StatusSuccess

core/utils/cloud_storage/client/ali.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ func (a *aliClient) completeUpload(uploadID, fileID string) error {
338338
}
339339

340340
type tokenResp struct {
341-
AccessToken string `json:"access_token"`
341+
RefreshToken string `json:"refresh_token"`
342342
}
343343

344344
func RefreshALIToken(varMap map[string]interface{}) (string, error) {
@@ -367,5 +367,5 @@ func RefreshALIToken(varMap map[string]interface{}) (string, error) {
367367
if err := json.Unmarshal(resp.Body(), &respItem); err != nil {
368368
return "", err
369369
}
370-
return respItem.AccessToken, nil
370+
return respItem.RefreshToken, nil
371371
}

frontend/src/lang/modules/en.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ const message = {
154154
createSuccess: 'Create Success',
155155
updateSuccess: 'Update Success',
156156
uploadSuccess: 'Update Success',
157-
operateConfirm: 'If you are sure about the operation, please input it manually',
157+
operateConfirm: 'If you are sure about the operation, please input it manually ',
158158
inputOrSelect: 'Please select or enter',
159159
copyFailed: 'Copy failed',
160160
operatorHelper: 'Would you like to continue performing {1} operation on {0}?',

frontend/src/lang/modules/ms.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const message = {
146146
createSuccess: 'Berjaya dicipta',
147147
updateSuccess: 'Berjaya dikemas kini',
148148
uploadSuccess: 'Berjaya dimuat naik',
149-
operateConfirm: 'Jika anda pasti dengan operasi ini, sila masukkan secara manual:',
149+
operateConfirm: 'Jika anda pasti dengan operasi ini, sila masukkan secara manual: ',
150150
inputOrSelect: 'Sila pilih atau masukkan',
151151
copyFailed: 'Gagal disalin',
152152
operatorHelper:

frontend/src/lang/modules/pt-br.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ const message = {
146146
createSuccess: 'Criado com sucesso',
147147
updateSuccess: 'Atualizado com sucesso',
148148
uploadSuccess: 'Enviado com sucesso',
149-
operateConfirm: 'Se você tem certeza da operação, insira-a manualmente:',
149+
operateConfirm: 'Se você tem certeza da operação, insira-a manualmente: ',
150150
inputOrSelect: 'Por favor, selecione ou insira',
151151
copyFailed: 'Falha ao copiar',
152152
operatorHelper: 'A operação "{1}" será realizada em "{0}" e não poderá ser desfeita. Deseja continuar?',

frontend/src/lang/modules/zh-Hant.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ const message = {
151151
createSuccess: '創建成功',
152152
updateSuccess: '更新成功',
153153
uploadSuccess: '上傳成功',
154-
operateConfirm: '如果確認操作,請手動輸入',
154+
operateConfirm: '如果確認操作,請手動輸入 ',
155155
inputOrSelect: '請選擇或輸入',
156156
copyFailed: '復製失敗',
157157
operatorHelper: '將對以下{0}進行{1}操作,是否繼續?',

0 commit comments

Comments
 (0)