Skip to content

Commit c8673b6

Browse files
authored
fix: Fix the issue of abnormal cache cleanup display (#11547)
1 parent 21975df commit c8673b6

File tree

14 files changed

+12
-87
lines changed

14 files changed

+12
-87
lines changed

agent/app/repo/monitor.go

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -73,28 +73,13 @@ func (u *MonitorRepo) CreateMonitorBase(model model.MonitorBase) error {
7373
return global.MonitorDB.Create(&model).Error
7474
}
7575
func (s *MonitorRepo) BatchCreateMonitorGPU(list []model.MonitorGPU) error {
76-
for _, item := range list {
77-
if err := global.GPUMonitorDB.Create(&item).Error; err != nil {
78-
global.LOG.Errorf("create Monitor GPU record failed, err: %v", err)
79-
}
80-
}
81-
return nil
76+
return global.GPUMonitorDB.CreateInBatches(&list, len(list)).Error
8277
}
83-
func (u *MonitorRepo) BatchCreateMonitorIO(list []model.MonitorIO) error {
84-
for _, item := range list {
85-
if err := global.MonitorDB.Create(&item).Error; err != nil {
86-
global.LOG.Errorf("create Monitor IO record failed, err: %v", err)
87-
}
88-
}
89-
return nil
78+
func (u *MonitorRepo) BatchCreateMonitorIO(ioList []model.MonitorIO) error {
79+
return global.MonitorDB.CreateInBatches(ioList, len(ioList)).Error
9080
}
91-
func (u *MonitorRepo) BatchCreateMonitorNet(list []model.MonitorNetwork) error {
92-
for _, item := range list {
93-
if err := global.MonitorDB.Create(&item).Error; err != nil {
94-
global.LOG.Errorf("create Monitor Network record failed, err: %v", err)
95-
}
96-
}
97-
return nil
81+
func (u *MonitorRepo) BatchCreateMonitorNet(ioList []model.MonitorNetwork) error {
82+
return global.MonitorDB.CreateInBatches(ioList, len(ioList)).Error
9883
}
9984
func (u *MonitorRepo) DelMonitorBase(timeForDelete time.Time) error {
10085
return global.MonitorDB.Where("created_at < ?", timeForDelete).Delete(&model.MonitorBase{}).Error

agent/app/service/device_clean.go

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"github.com/1Panel-dev/1Panel/agent/global"
2020
"github.com/1Panel-dev/1Panel/agent/i18n"
2121
"github.com/1Panel-dev/1Panel/agent/utils/common"
22-
"github.com/1Panel-dev/1Panel/agent/utils/controller"
2322
"github.com/1Panel-dev/1Panel/agent/utils/docker"
2423
fileUtils "github.com/1Panel-dev/1Panel/agent/utils/files"
2524
"github.com/docker/docker/api/types"
@@ -30,7 +29,6 @@ import (
3029

3130
const (
3231
rollbackPath = "1panel/tmp"
33-
cachePath = "1panel/cache"
3432
upgradePath = "1panel/tmp/upgrade"
3533
uploadPath = "1panel/uploads"
3634
downloadPath = "1panel/download"
@@ -56,16 +54,6 @@ func (u *DeviceService) Scan() dto.CleanData {
5654
})
5755
treeData = append(treeData, loadUpgradeTree(fileOp))
5856
treeData = append(treeData, loadAgentPackage(fileOp))
59-
cachePath := path.Join(global.Dir.BaseDir, cachePath)
60-
cacheSize, _ := fileOp.GetDirSize(cachePath)
61-
treeData = append(treeData, dto.CleanTree{
62-
ID: uuid.NewString(),
63-
Label: "cache",
64-
Size: uint64(cacheSize),
65-
IsCheck: false,
66-
IsRecommend: false,
67-
Type: "cache",
68-
})
6957

7058
SystemClean.BackupClean = loadBackupTree(fileOp)
7159

@@ -102,7 +90,6 @@ func (u *DeviceService) Scan() dto.CleanData {
10290

10391
func (u *DeviceService) Clean(req []dto.Clean) {
10492
size := uint64(0)
105-
restart := false
10693
for _, item := range req {
10794
size += item.Size
10895
switch item.TreeType {
@@ -131,10 +118,6 @@ func (u *DeviceService) Clean(req []dto.Clean) {
131118
case "rollback_website":
132119
dropFileOrDir(path.Join(global.Dir.BaseDir, rollbackPath, "website", item.Name))
133120

134-
case "cache":
135-
dropFileOrDir(path.Join(global.Dir.BaseDir, cachePath, item.Name))
136-
restart = true
137-
138121
case "upload":
139122
dropFileOrDir(path.Join(global.Dir.BaseDir, uploadPath, item.Name))
140123
case "upload_app":
@@ -202,10 +185,6 @@ func (u *DeviceService) Clean(req []dto.Clean) {
202185
_ = settingRepo.Update("LastCleanTime", time.Now().Format(constant.DateTimeLayout))
203186
_ = settingRepo.Update("LastCleanSize", fmt.Sprintf("%v", size))
204187
_ = settingRepo.Update("LastCleanData", fmt.Sprintf("%v", len(req)))
205-
206-
if restart {
207-
go controller.RestartPanel(false, true, false)
208-
}
209188
}
210189

211190
func doSystemClean(taskItem *task.Task) func(t *task.Task) error {
@@ -327,6 +306,7 @@ func loadAgentPackage(fileOp fileUtils.FileOp) dto.CleanTree {
327306
itemTree.Size += uint64(itemSize)
328307
itemTree.Children = append(itemTree.Children, dto.CleanTree{
329308
ID: uuid.NewString(),
309+
Label: file.Name(),
330310
Name: file.Name(),
331311
Size: uint64(itemSize),
332312
IsCheck: true,
@@ -342,6 +322,7 @@ func loadAgentPackage(fileOp fileUtils.FileOp) dto.CleanTree {
342322
itemTree.Children = append(itemTree.Children, dto.CleanTree{
343323
ID: uuid.NewString(),
344324
Label: file.Name(),
325+
Name: file.Name(),
345326
Size: uint64(itemSize.Size()),
346327
IsCheck: true,
347328
IsRecommend: true,
@@ -598,6 +579,9 @@ func loadBackupIsCheck(treeData *dto.CleanTree) {
598579
treeData.Children[i].IsRecommend = true
599580
continue
600581
}
582+
if treeData.Label != "unknown_database" && treeData.Label != "unknown_app" {
583+
continue
584+
}
601585
for j := 0; j < len(treeData.Children[i].Children); j++ {
602586
if len(treeData.Children[i].Children[j].Children) == 0 {
603587
treeData.Children[i].Children[j].IsCheck = true

core/constant/common.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ var WebUrlMap = map[string]struct{}{
5959
"/ai": {},
6060
"/ai/model": {},
6161
"/ai/gpu": {},
62+
"/ai/gpu/current": {},
6263
"/ai/mcp": {},
6364
"/ai/model/tensorrt": {},
6465
"/ai/model/ollama": {},
@@ -165,6 +166,7 @@ var WebUrlMap = map[string]struct{}{
165166
"/xpack/alert/log": {},
166167
"/xpack/alert/setting": {},
167168
"/xpack/setting": {},
169+
"/xpack/node/dashboard": {},
168170
"/xpack/node": {},
169171
"/xpack/simple-node": {},
170172
"/xpack/exchange/file": {},

frontend/src/lang/modules/en.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2202,8 +2202,6 @@ const message = {
22022202
upgrade: 'System upgrade backup files',
22032203
agentPackages: 'Historical version child node upgrade/installation packages',
22042204
upgradeHelper: '(Recommend keeping the latest upgrade backup for system rollback)',
2205-
cache: 'System cache files',
2206-
cacheHelper: '(Proceed with caution, cleaning requires a service restart)',
22072205
snapshot: 'System snapshot temporary files',
22082206
rollback: 'Backup files before recover',
22092207

frontend/src/lang/modules/es-es.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2215,8 +2215,6 @@ const message = {
22152215
upgrade: 'Archivos de copia de seguridad de actualización del sistema',
22162216
agentPackages: 'Paquetes de actualización/instalación de nodos secundarios de versiones históricas',
22172217
upgradeHelper: '(Mantenga el último respaldo para restaurar el sistema)',
2218-
cache: 'Archivos de caché',
2219-
cacheHelper: '(Precaución, limpiar requiere reiniciar servicios)',
22202218
snapshot: 'Archivos temporales de instantáneas',
22212219
rollback: 'Archivos de respaldo antes de recuperación',
22222220

frontend/src/lang/modules/ja.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2122,8 +2122,6 @@ const message = {
21222122
upgrade: 'システムアップグレードのバックアップファイル',
21232123
agentPackages: '履歴バージョンの子ノードアップグレード/インストールパッケージ',
21242124
upgradeHelper: '(システムロールバックのために最新のアップグレードバックアップを保持することをお勧めします)',
2125-
cache: 'システムキャッシュファイル',
2126-
cacheHelper: '(注意を払って進むには、クリーニングにはサービスの再起動が必要です)',
21272125
rollback: '回復する前にファイルをバックアップします',
21282126

21292127
backup: 'システムバックアップ',

frontend/src/lang/modules/ko.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,8 +2087,6 @@ const message = {
20872087
upgrade: '시스템 업그레이드 백업 파일',
20882088
agentPackages: '이전 버전 자식 노드 업그레이드/설치 패키지',
20892089
upgradeHelper: '(시스템 롤백을 위해 최신 업그레이드 백업을 유지하는 것이 좋습니다)',
2090-
cache: '시스템 캐시 파일',
2091-
cacheHelper: '(주의하여 진행, 정리 후 서비스 재시작 필요)',
20922090
rollback: '복구 전 백업 파일',
20932091

20942092
backup: '시스템 백업',

frontend/src/lang/modules/ms.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,8 +2182,6 @@ const message = {
21822182
upgrade: 'Fail sandaran naik taraf sistem',
21832183
agentPackages: 'Pakej naik taraf/pemasangan nod anak versi sejarah',
21842184
upgradeHelper: '(Disarankan untuk mengekalkan sandaran peningkatan terbaru untuk pemulihan sistem)',
2185-
cache: 'Fail cache sistem',
2186-
cacheHelper: '(Berhati-hati, pembersihan memerlukan permulaan semula perkhidmatan)',
21872185
rollback: 'Fail sandaran sebelum pemulihan',
21882186

21892187
backup: 'Sandaran Sistem',

frontend/src/lang/modules/pt-br.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2176,8 +2176,6 @@ const message = {
21762176
upgrade: 'Arquivos de backup de atualização do sistema.',
21772177
agentPackages: 'Pacotes de atualização/instalação de nós filhos de versões históricas.',
21782178
upgradeHelper: '(Recomenda-se manter o backup de atualização mais recente para rollback do sistema)',
2179-
cache: 'Arquivos de cache do sistema',
2180-
cacheHelper: '(Prossiga com cautela, a limpeza exige reinício do serviço)',
21812179
rollback: 'Arquivos de backup antes da recuperação',
21822180

21832181
backup: 'Backup do Sistema',

frontend/src/lang/modules/ru.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2171,8 +2171,6 @@ const message = {
21712171
upgrade: 'Файлы резервных копий обновления системы',
21722172
agentPackages: 'Пакеты обновления/установки дочерних узлов исторических версий',
21732173
upgradeHelper: '(Рекомендуется сохранять последнюю резервную копию обновления для отката системы)',
2174-
cache: 'Системные файлы кэша',
2175-
cacheHelper: '(Действуйте с осторожностью, очистка требует перезапуска службы)',
21762174
rollback: 'Файлы резервных копий перед восстановлением',
21772175

21782176
backup: 'Резервная Копия Системы',

0 commit comments

Comments
 (0)