fix: Fix version upgrade failure in some scenarios

Author: ssongliu

core/app/service/upgrade.go

@@ -156,18 +156,31 @@ func (u *UpgradeService) Upgrade(req dto.Upgrade) error {
 
 		global.LOG.Info("backup original data successful, now start to upgrade!")
 
-		if err := files.CopyItem(false, true, path.Join(tmpDir, "1panel-core"), "/usr/local/bin"); err != nil {
+		if err := files.CopyItem(false, true, path.Join(tmpDir, "1panel-core"), "/usr/local/bin/1panel-core.tmp"); err != nil {
 			global.LOG.Errorf("upgrade 1panel-core failed, err: %v", err)
 			_ = settingRepo.Update("SystemStatus", "Free")
 			u.handleRollback(originalDir, 1)
 			return
 		}
-		if err := files.CopyItem(false, true, path.Join(tmpDir, "1panel-agent"), "/usr/local/bin"); err != nil {
+		if err := files.RenameFile("/usr/local/bin/1panel-core.tmp", "/usr/local/bin/1panel-core"); err != nil {
+			global.LOG.Errorf("rename 1panel-core failed, err: %v", err)
+			_ = settingRepo.Update("SystemStatus", "Free")
+			u.handleRollback(originalDir, 1)
+			return
+		}
+
+		if err := files.CopyItem(false, true, path.Join(tmpDir, "1panel-agent"), "/usr/local/bin/1panel-agent.tmp"); err != nil {
 			global.LOG.Errorf("upgrade 1panel-agent failed, err: %v", err)
 			_ = settingRepo.Update("SystemStatus", "Free")
 			u.handleRollback(originalDir, 1)
 			return
 		}
+		if err := files.RenameFile("/usr/local/bin/1panel-agent.tmp", "/usr/local/bin/1panel-agent"); err != nil {
+			global.LOG.Errorf("rename 1panel-agent failed, err: %v", err)
+			_ = settingRepo.Update("SystemStatus", "Free")
+			u.handleRollback(originalDir, 1)
+			return
+		}
 
 		if err := files.CopyItem(false, true, path.Join(tmpDir, "1pctl"), "/usr/local/bin"); err != nil {
 			global.LOG.Errorf("upgrade 1pctl failed, err: %v", err)

core/utils/files/files.go

@@ -49,6 +49,22 @@ func CopyFile(src, dst string, withName bool) error {
 	return nil
 }
 
+func RenameFile(src, dst string) error {
+	if _, err := os.Stat(src); err != nil {
+		return err
+	}
+	if _, err := os.Stat(path.Dir(dst)); err != nil {
+		if os.IsNotExist(err) {
+			_ = os.MkdirAll(path.Dir(dst), os.ModePerm)
+		}
+	}
+	stdout, err := cmd.RunDefaultWithStdoutBashCf("mv '%s' '%s'", src, dst)
+	if err != nil {
+		return fmt.Errorf("handle mv '%s' '%s' failed, stdout: %s, err: %v", src, dst, stdout, err)
+	}
+	return nil
+}
+
 func CopyItem(isDir, withName bool, src, dst string) error {
 	if path.Base(src) != path.Base(dst) && !withName {
 		dst = path.Join(dst, path.Base(src))