Skip to content

Conversation

@xcr1234
Copy link
Contributor

@xcr1234 xcr1234 commented Jun 15, 2025

What this PR does / why we need it?

This PR fixes a resource leak issue where Docker logs processes would continue to run after a client disconnects from the streaming logs API. This could lead to accumulation of zombie processes and unnecessary system resource consumption.

Summary of your change

Added a mechanism to detect when a client disconnects from the StreamLogs endpoint
Implemented proper cleanup of the Docker logs process when the client connection is terminated
Ensured all resources are properly released by adding appropriate channel closing and process termination logic
Maintained the original code structure while adding minimal necessary changes to fix the issue

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 15, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud
Copy link
Member

感谢支持。

@ssongliu ssongliu merged commit 5e549fd into 1Panel-dev:dev-v2 Jun 16, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants