Skip to content

Commit 2b05ca6

Browse files
shaohuzhang1liuruibin
authored andcommitted
fix: When the execution fails, the execution details still show as successful in the [Knowledge Base Workflow] (#4494)
1 parent 222ca03 commit 2b05ca6

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

apps/application/flow/step_node/image_understand_step_node/i_image_understand_node.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,23 @@ class ImageUnderstandNodeSerializer(serializers.Serializer):
3131

3232
class IImageUnderstandNode(INode):
3333
type = 'image-understand-node'
34-
support = [WorkflowMode.APPLICATION, WorkflowMode.APPLICATION_LOOP]
34+
support = [WorkflowMode.APPLICATION, WorkflowMode.APPLICATION_LOOP, WorkflowMode.KNOWLEDGE,
35+
WorkflowMode.KNOWLEDGE_LOOP]
3536

3637
def get_node_params_serializer_class(self) -> Type[serializers.Serializer]:
3738
return ImageUnderstandNodeSerializer
3839

3940
def _run(self):
4041
res = self.workflow_manage.get_reference_field(self.node_params_serializer.data.get('image_list')[0],
4142
self.node_params_serializer.data.get('image_list')[1:])
42-
return self.execute(image=res, **self.node_params_serializer.data, **self.flow_params_serializer.data)
43-
44-
def execute(self, model_id, system, prompt, dialogue_number, dialogue_type, history_chat_record, stream, chat_id,
43+
if [WorkflowMode.KNOWLEDGE, WorkflowMode.KNOWLEDGE_LOOP].__contains__(
44+
self.workflow_manage.flow.workflow_mode):
45+
return self.execute(image=res, **self.node_params_serializer.data, **self.flow_params_serializer.data,
46+
**{'history_chat_record': [], 'stream': True, 'chat_record_id': None})
47+
else:
48+
return self.execute(image=res, **self.node_params_serializer.data, **self.flow_params_serializer.data)
49+
50+
def execute(self, model_id, system, prompt, dialogue_number, dialogue_type, history_chat_record, stream,
4551
model_params_setting,
4652
chat_record_id,
4753
image,

apps/application/flow/step_node/image_understand_step_node/impl/base_image_understand_node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def save_context(self, details, workflow_manage):
7171
if self.node_params.get('is_result', False):
7272
self.answer_text = details.get('answer')
7373

74-
def execute(self, model_id, system, prompt, dialogue_number, dialogue_type, history_chat_record, stream, chat_id,
74+
def execute(self, model_id, system, prompt, dialogue_number, dialogue_type, history_chat_record, stream,
7575
model_params_setting,
7676
chat_record_id,
7777
image,

0 commit comments

Comments
 (0)