Skip to content

Commit 4be3080

Browse files
committed
refactor: remove redundant validation logic from tool serializer
--bug=1058282 --user=刘瑞斌 【工具】在工具模块,添加工具商店中的mysql查询工具,报错:Tool id does not exist https://www.tapd.cn/62980211/s/1725592
1 parent b6cf80d commit 4be3080

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

apps/tools/serializers/tool.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -498,15 +498,6 @@ class AddInternalTool(serializers.Serializer):
498498
workspace_id = serializers.CharField(required=True, label=_("workspace id"))
499499
tool_id = serializers.UUIDField(required=True, label=_("tool id"))
500500

501-
def is_valid(self, *, raise_exception=False):
502-
super().is_valid(raise_exception=True)
503-
workspace_id = self.data.get('workspace_id')
504-
query_set = QuerySet(Tool).filter(id=self.data.get('tool_id'))
505-
if workspace_id:
506-
query_set = query_set.filter(workspace_id=workspace_id)
507-
if not query_set.exists():
508-
raise AppApiException(500, _('Tool id does not exist'))
509-
510501
def add(self, instance, with_valid=True):
511502
if with_valid:
512503
self.is_valid(raise_exception=True)

0 commit comments

Comments
 (0)