Skip to content

Commit 622a8e5

Browse files
committed
refactor: add early return for invalid document type in document_serializers.py
--bug=1057562 --user=王孝刚 【知识库】飞书知识库对接,设置命中处理方式保存报错 https://www.tapd.cn/57709429/s/1736833
1 parent f568c68 commit 622a8e5

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

apps/dataset/serializers/document_serializers.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,8 @@ def is_valid(self, *, document: Document = None):
141141
if 'meta' in self.data and self.data.get('meta') is not None:
142142
dataset_meta_valid_map = self.get_meta_valid_map()
143143
valid_class = dataset_meta_valid_map.get(document.type)
144-
if valid_class is None:
145-
return
146-
valid_class(data=self.data.get('meta')).is_valid(raise_exception=True)
144+
if valid_class is not None:
145+
valid_class(data=self.data.get('meta')).is_valid(raise_exception=True)
147146

148147

149148
class DocumentWebInstanceSerializer(ApiMixin, serializers.Serializer):

0 commit comments

Comments
 (0)